codestyle adjustments: function declaration braces/spaces

codestyle adjustments: function argument spacing

Apply rector fixes to the rest of inc

removed outdated version check

use samesite=Lax cookie attribute #2849

Since this has been the default in Chrome for a while, no sideeffects
are to be expected.

updated repo links

Don't send notifications if no save happend.

A page save might not actually save a new revision. For example when no
changes were detected or a plugin cancelled the saving action. In that
case no no

Don't send notifications if no save happend.

A page save might not actually save a new revision. For example when no
changes were detected or a plugin cancelled the saving action. In that
case no notifications should be sent and the cache does not need any
updates.

Fixes #3871

show more ...

Fix for PHP 8.1 Warning

I am running Dokuwiki Release 2022-07-31a "Igor" and I noticed the following variety of PHP logs generated:
[01-Feb-2023 07:21:37 Asia/Kolkata] PHP Warning: Undefined array

Fix for PHP 8.1 Warning

I am running Dokuwiki Release 2022-07-31a "Igor" and I noticed the following variety of PHP logs generated:
[01-Feb-2023 07:21:37 Asia/Kolkata] PHP Warning: Undefined array key "host" in /home/ekvastra/wiki.ekvastra.in/inc/common.php on line 1362

show more ...

avoid warning in formText when no text is given

Check if SE referrer url actually has a query part

Move IP functions into a class

Merge branch 'master' into fix-clientip

Factor out IP address functions; all proxies must be trusted

Update core code to make use of sexplode()

This makes use of our own explode mechanism everywhere were we expect a
fixed number of results.

Fix clientIP() returning the wrong address

introduce sexplode() as a PHP8 safe explode()

We often have constructs like

list($foo, $bar) = explode(',', $input, 2);

In PHP8+ this will throw warnings when the explode returns fewer than 2
elem

introduce sexplode() as a PHP8 safe explode()

We often have constructs like

list($foo, $bar) = explode(',', $input, 2);

In PHP8+ this will throw warnings when the explode returns fewer than 2
elements. Our code usually (always?) will anticipate missing elements so
the construct isn't really problematic.

The implementation here wraps the solution suggested at
https://stackoverflow.com/a/56971347 into a new utility function.

I anticipate that people might object to the function name. It was
chosen as a short form of "safe explode". This makes fixing the warning
easy by simply adding a single letter. I also find it slightly amusing
and would be open to change it to just sex() just for the fun of it.

show more ...

Replace direct calls to strftime with dformat calls

This is in preparation for fixing #3573

Merge pull request #3574 from splitbrain/php81

Some PHP 8.1 compatibility fixes

import classes, replace dbglog, simplify, remove unused statements, and other warnings from IntelliJ

update phpdocs,
rename dokuwiki/Ui/Draft to PageDraft

guard against unset parameters

Many string function will throw a deprecation warning in PHP 8.1 when
null is passed. This adds a few guards in some of our methods (not all,
yet)

always use the same htmlspecialchars setup

defaults for htmlspecialchars change in PHP 8.1

All calls should always use our hsc() method to ensure comparability
(especially when testing)

Merge branch 'master' into revisionHandle3

guard against unsert user name. fixes #3455

Merge pull request #3270 from adakaleh/simplify_clientIP

Simplify clientIP() function

Merge pull request #3269 from adakaleh/clientIP_page_locking

Remove clientIP() verification from page locking