en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/inc/common.php#a5debd11989e592856f864bfca820c4e918e8843 remove valid_input_set(), inline the only remaining callersThe Input::valid() method on $INPUT already provides the cleaner APIoriginally requested in #667. The last two callers in Subscribe.phpvalidated against a local $params array (not $_POST/$_GET) and needto throw a specific exception, so inline a small in_array + throw atthose call sites rather than carry the legacy helper.The class could probably be made cleaner but that's beyond the scope ofthis change.Closes #667 List of files: /dokuwiki/inc/common.php Thu, 14 May 2026 20:27:11 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#71d1aa000928e9ee40ec367aeaa1eb5956340f2c Merge pull request #4626 from dokuwiki/flakytestrefactor(changelog): persist external-edit detection on first read List of files: /dokuwiki/inc/common.php Wed, 06 May 2026 19:11:19 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#15ed40bb31687e8902a55957b715f099a1b49b7f Merge branch 'searchIndex-finish'* searchIndex-finish: (143 commits) SearchIndex: fix comment position Replace deprecated idx_addPage/ft_backlinks calls in ApiCoreTest SearchIndex: fix IntegrityTest not re-indexing between tests SearchIndex: remove write side effect from retrieveRow() SearchIndex: fix TypeError when $QUERY global is null SearchIndex: fix TypeError when $highlight is passed uninitialized SearchIndex: increase index version SearchIndex: rector, phpcs, type hint fixes SearchIndex: review fixes — auto-save MemoryIndex, cast TupleOps counts, style cleanups SearchIndex: document Tokenizer::isValidSearchTerm() in concept.txt SearchIndex: unify CollectionSearch API and optimize search pipeline SearchIndex: updated documentation SearchIndex: use FileIndex for title token index SearchIndex: move search() function tests back to tests/inc/search/ SearchIndex: add backward compatibility wrappers SearchIndex: remove legacy intermediate classes from PR #2943 SearchIndex: add integrity checking to Collection architecture SearchIndex: rewrite MetadataSearch to use Collection classes SearchIndex: reorganize and expand test suite SearchIndex: rewrite FulltextSearch to use FrequencyCollectionSearch ... List of files: /dokuwiki/inc/common.php Wed, 06 May 2026 19:07:22 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#01e8d739c8b53aeb1d0a653331d65eb1f8394002 refactor(changelog): persist external-edit detection on first readThis addresses the flaky test that makes tests randomly fail (mostly onwindows runners).The flake in common_saveWikiText_test::test_savesequence5 came fromthis line in ChangeLog::getCurrentRevisionInfo(): 'date' => max($lastRev + 1, time() - 1)The synthesized "external delete" entry was kept in memory only andonly persisted later, when saveWikiText next called detectExternalEdit.That meant the formula was evaluated twice on different ChangeLoginstances — once during the test's inspection, and again during thefollowing saveWikiText — and the two evaluations could pick differentseconds depending on how long the surrounding I/O took. The testcached the first result in $expectExternal and asserted it against theon-disk entry written during the second call. On the slower Windowsrunner the second call sometimes crossed a second boundary, producingthe off-by-one date mismatch.The questions I had was, why are we persisting external file deletions(or edits) only when a page is saved when we are obviously alreadydetecting it earlier during the changelog read already?Instead of recording the external delete at the time a new page iswritten, it makes sense to record it as soon as we detect it (when thechangelog is requested by a user or a bot). This will make the recodedtimestamp closer to the actual deletion.This patch refactors the changelog accordingly, but still tries to beminimal invasive (I think the changelog handling would need much morerefactoring, but that's beyond the scope of this change).To enable proper locking (when logging an external edit and copyingthe attic file), locking had to be moved to the Changelog class,duplicating some code of io_saveFile.PageFile::detectExternalEdit() and the deprecated procedural wrapperdetectExternalEdit() in inc/common.php are removed. A codesearch.dokuwiki.orgcheck confirmed no plugin calls the method directly; the only externalcaller of the procedural function is the farmsync plugin, which needsa parallel update. List of files: /dokuwiki/inc/common.php Sat, 25 Apr 2026 15:30:23 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#85cddb538a58d7b2cfc0a3b41359a9310d6a6843 Merge branch 'client_ip_header'* client_ip_header: Clean up stale realip references after client_ip_header rename remove realip option, add default in conf/dokuwiki.php convert tests to data provider add comment to the real-ip test add custom client_ip_header List of files: /dokuwiki/inc/common.php Sat, 18 Apr 2026 19:29:36 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#90c2f6e39ea5f0855d81ad8451f2288d642a1ed0 Clean up stale realip references after client_ip_header renameUpdate docblocks in Ip.php and common.php, fix old tests to usethe new config key, remove outdated translations, fix method casingin test, and add example to English config description. List of files: /dokuwiki/inc/common.php Sat, 18 Apr 2026 19:28:49 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#db8be586414d0dc05ca5131baddfa84f08c55520 SearchIndex: review fixes — auto-save MemoryIndex, cast TupleOps counts, style cleanups- MemoryIndex: auto-save dirty data on unlock/destruction to prevent silent index corruption when indexes are used in tandem- TupleOps::parseTuples(): cast exploded count strings to int- FileIndex::retrieveRow(): document the write-on-read padding behavior- Fix whitespace issues in ApiCore, common.php, Sitemap/Mapper- Update concept.txt to reflect MemoryIndex auto-save behavior List of files: /dokuwiki/inc/common.php Wed, 08 Apr 2026 17:50:08 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#6734bb8cef71e8b4af23e627d4db5430304d55a2 SearchIndex: rewrite MetadataSearch to use Collection classesReplace MetadataIndex usage in MetadataSearch with the new Collection/Indexarchitecture. This completes the read-path migration so data written by theCollection-based Indexer is read back correctly using TupleOps tuple format.Generalize FrequencyCollectionSearch into CollectionSearch that works with anyAbstractCollection type (Frequency, Lookup, Direct) and handles bothsplit-by-length and non-split index layouts transparently. DirectCollectionparticipates via resolveTokenFrequencies() which maps token RID = entity RID.Key changes:- AbstractCollection gains isSplitByLength(), resolveTokenFrequencies(), getEntitiesWithData(), and groupToSuffix() with validation- Index groups are now int (0 = non-split, positive = token length)- CollectionSearch provides both addTerm()/execute() for fulltext and lookup() for metadata-style search (exact/wildcard/callback)- MetadataSearch delegates entirely to collection APIs- Shared filterPages() replaces duplicated page filtering logic- All callers updated from MetadataIndex to MetadataSearch- Tests moved to Search namespace with full coverage for new APIs List of files: /dokuwiki/inc/common.php Tue, 07 Apr 2026 13:33:54 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#7f394dd683d14aba9f6131a7f9d011383c280834 Merge branch 'master' into searchIndex-finish* master: (55 commits) Translation update (pt-br) Bump phpseclib/phpseclib from 3.0.49 to 3.0.50 �� Update deleted files strict value comparison in auth session check. fixes #4602 Translation update (pt-br) Translation update (pt-br) remove utf8_encode() from authad plugin todo checker action: ignore vendor updated rector and applied it removed another php 7.4 workaround removed an old PHP 5 workaround in HTTPClient remove checks for mbstring.func_overload removed php 8 polyfills ignore HTML validation issue with skipped headline levels declare PrefCookie constant visibility update slika which fixes another php 8.5 deprecation issue fix http tests fix destructuring false returns from changelog functions avoid using null as cache key Fix deprecation warning in UTF8/Conversion ... List of files: /dokuwiki/inc/common.php Sun, 05 Apr 2026 09:15:35 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#093fe67e98c0cdb4b73fd46938e49b64971483c2 updated rector and applied it List of files: /dokuwiki/inc/common.php Sat, 07 Mar 2026 20:26:13 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#9df9f0c8d11cfaadf321a358ea52a8328f6661ad Merge branch 'master' into searchIndex-finishThere were a lot of conflicts to resolve. Not all of them may have beenresolved correctly...* master: (1094 commits) Login accessibility improvements Translation update (it) translation update translation update translation update translation update translation update translation update translation update translation update translation update translation update translation update translation update Remove HTML from strings based on title and tagline SECURITY: fix XSS vulnerability. fixes #4512 translation update Fix typos in usermanager English strings Replace hardcoded message by localized string set DOKU_INC in rector ... List of files: /dokuwiki/inc/common.php Mon, 27 Oct 2025 13:09:16 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#3f108b378b26a51a8deb0e3ec08ce3ed6342d5af refactor preference cookie handling. fixes #4544This refactors the DOKU_PREF cookie handling on the PHP side into aclass. It makes encoding/decoding more explicit and easier tounderstand.The new class is used in set_doku_pref() and get_doku_pref() which havenot been deprecated for now. List of files: /dokuwiki/inc/common.php Thu, 23 Oct 2025 09:11:38 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#33cb4e0125bb3ea66842b52c5d02739268775800 Make is_ssl and baseurl use proper proxy checksThis should not only address #4455 but also ensures that the relatedheaders are only used when they come from a trusted reverse proxy chain. List of files: /dokuwiki/inc/common.php Tue, 03 Jun 2025 12:22:14 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#564b5cbf370a22bf1f5bb693e30c5d97499d8a90 Merge pull request #4389 from dokuwiki/buildqueryuse http_build_query() in buildURLparams() List of files: /dokuwiki/inc/common.php Mon, 13 Jan 2025 10:20:09 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#98b599a697d5188f9a6c1080fc70144e37061abe �� Rector and PHPCS fixes List of files: /dokuwiki/inc/common.php Thu, 09 Jan 2025 17:46:40 +0000 splitbrain <86426+splitbrain@users.noreply.github.com> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#d5dd5d1b1d2bd9d3299e5d0114855dae264944df use renamed trustedproxies setting in tests List of files: /dokuwiki/inc/common.php Thu, 09 Jan 2025 15:33:07 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#2f828abfb5c80097dfa52bc797301aa0223c1b87 style fix List of files: /dokuwiki/inc/common.php Thu, 09 Jan 2025 15:26:14 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#2aba9aed6bcd4e96ff6988f6d1ff730503a2c6d5 Merge branch 'pr/3815' into clientIP* pr/3815: Move IP functions into a class Factor out IP address functions; all proxies must be trusted Fix clientIP() returning the wrong address List of files: /dokuwiki/inc/common.php Thu, 09 Jan 2025 14:42:15 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#6cc6a0d2d8cfd4379f05b92c2dd838275d7f1edd use http_build_query() in buildURLparams()buildURLparams() is used all throughout the code, but its implementationwas overly simplistic. This changes it to use the much better builtinhttp_build_query() function. This allows for correct encoding of arrayvalues or deeper nested structures. List of files: /dokuwiki/inc/common.php Thu, 09 Jan 2025 08:55:40 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/common.php#8407f251434f578d07231a3f252ce6276d9e0b05 �� Rector and PHPCS fixes List of files: /dokuwiki/inc/common.php Mon, 02 Dec 2024 13:22:00 +0000 splitbrain <86426+splitbrain@users.noreply.github.com>