Searched hist:"7717 c082e7685f74d7eb1592595a7a2ef6225f8c" (Results 1 – 4 of 4) sorted by relevance
| /plugin/struct/types/ |
| H A D | Lookup.php | 7717c082e7685f74d7eb1592595a7a2ef6225f8c Tue Mar 14 11:38:47 UTC 2017 Michael Große <grosse@cosmocode.de> Add compareValue() abstract base type & lookup
This fixes a bug, that caused the $STRUCT.table.field$ filter syntax to
be broken for lookup fields. Struct was comparing the row-id of the
argument-column to the raw value of the referenced column at the
filtered lookup.
There were multiple options to fix this bug:
1. Add a new function to the AbstractBaseType() that return raw value by
default (this is the approach implemented by this commit)
2. Add a function to the lookup type only and use introspection to call
it if it exists.
3. Do not compare the values in the referenced columns, but compare only
the row-ids
The problem with approach 3: It is not possible to compare such
lookup-column to any other column except lookups and this is not what we
want.
Approaches 1 and 2 have different trade-offs on where additional
code/complexity is created. I decided for approach 1 because it is the
cleaner overall approach and we might want to use this functionality for future
types as well.
SPR-875
|
| H A D | AbstractBaseType.php | 7717c082e7685f74d7eb1592595a7a2ef6225f8c Tue Mar 14 11:38:47 UTC 2017 Michael Große <grosse@cosmocode.de> Add compareValue() abstract base type & lookup
This fixes a bug, that caused the $STRUCT.table.field$ filter syntax to
be broken for lookup fields. Struct was comparing the row-id of the
argument-column to the raw value of the referenced column at the
filtered lookup.
There were multiple options to fix this bug:
1. Add a new function to the AbstractBaseType() that return raw value by
default (this is the approach implemented by this commit)
2. Add a function to the lookup type only and use introspection to call
it if it exists.
3. Do not compare the values in the referenced columns, but compare only
the row-ids
The problem with approach 3: It is not possible to compare such
lookup-column to any other column except lookups and this is not what we
want.
Approaches 1 and 2 have different trade-offs on where additional
code/complexity is created. I decided for approach 1 because it is the
cleaner overall approach and we might want to use this functionality for future
types as well.
SPR-875
|
| /plugin/struct/meta/ |
| H A D | Value.php | 7717c082e7685f74d7eb1592595a7a2ef6225f8c Tue Mar 14 11:38:47 UTC 2017 Michael Große <grosse@cosmocode.de> Add compareValue() abstract base type & lookup
This fixes a bug, that caused the $STRUCT.table.field$ filter syntax to
be broken for lookup fields. Struct was comparing the row-id of the
argument-column to the raw value of the referenced column at the
filtered lookup.
There were multiple options to fix this bug:
1. Add a new function to the AbstractBaseType() that return raw value by
default (this is the approach implemented by this commit)
2. Add a function to the lookup type only and use introspection to call
it if it exists.
3. Do not compare the values in the referenced columns, but compare only
the row-ids
The problem with approach 3: It is not possible to compare such
lookup-column to any other column except lookups and this is not what we
want.
Approaches 1 and 2 have different trade-offs on where additional
code/complexity is created. I decided for approach 1 because it is the
cleaner overall approach and we might want to use this functionality for future
types as well.
SPR-875
|
| H A D | SearchConfig.php | 7717c082e7685f74d7eb1592595a7a2ef6225f8c Tue Mar 14 11:38:47 UTC 2017 Michael Große <grosse@cosmocode.de> Add compareValue() abstract base type & lookup
This fixes a bug, that caused the $STRUCT.table.field$ filter syntax to
be broken for lookup fields. Struct was comparing the row-id of the
argument-column to the raw value of the referenced column at the
filtered lookup.
There were multiple options to fix this bug:
1. Add a new function to the AbstractBaseType() that return raw value by
default (this is the approach implemented by this commit)
2. Add a function to the lookup type only and use introspection to call
it if it exists.
3. Do not compare the values in the referenced columns, but compare only
the row-ids
The problem with approach 3: It is not possible to compare such
lookup-column to any other column except lookups and this is not what we
want.
Approaches 1 and 2 have different trade-offs on where additional
code/complexity is created. I decided for approach 1 because it is the
cleaner overall approach and we might want to use this functionality for future
types as well.
SPR-875
|