some automatic rector fixes

$NSORID$ filter place holder. implements #712

This filter will return the current page unless when called on a
namespace start page where it will return the namespace instead.

apply #670 and manually cleanup afterwards

fixes some failing tests
uses sexplode over array_pad
reformats multiline arrays

�� Automatic code style fixes

Merge remote-tracking branch 'saggi-dw/date-filter'

Move 'if' to 'elseif'
move assignment of '$timestamp' outside of condition
format adjusted to the styleguide

fixed style errors

refactoring dynamic parameter handling, part 4

This finally adjusts the tests. It also adds getLimit and getOffset in
the search class.

refactoring dynamic parameter handling, part 3

This moves SQL building into it's own class, splitting it into separate
methods. This allows for reusing the filter handling a second time to
separate

refactoring dynamic parameter handling, part 3

This moves SQL building into it's own class, splitting it into separate
methods. This allows for reusing the filter handling a second time to
separate out the dynamic filters.

Still no work on tests

show more ...

refactoring dynamic parameter handling, part 1

Instead of modifying the configuration array, we now call the
appropriate methods on the SearchConfig object in the apply() method
which replaces the u

refactoring dynamic parameter handling, part 1

Instead of modifying the configuration array, we now call the
appropriate methods on the SearchConfig object in the apply() method
which replaces the updateConfig() method.

A constructor parameter on SearchConfig allows to ignore the
dynamicParameters alltogether.

Tests are broken

show more ...

Add variable date filter based on strtotime

Multiple fixes for PHP 8 (#600)

Use $INPUT to access server variables

PHP code sniffer autofixes

Fix bug in struct filter variable evaluation

When a search contains a struct variable expression for filtering and
the variable references a schema that is not assigned to the current
search but has

Fix bug in struct filter variable evaluation

When a search contains a struct variable expression for filtering and
the variable references a schema that is not assigned to the current
search but has a column with the same name like one from the assigned
schemas, the evaluation of the variable doesn't return the correct
value.

This patch fixes the bug by ensuring that findColumn() returns false
in case the requested schema wasn't found within the assigned schemas.

To make sure the behavior of other callers of findColumn() remains the
same, we introduce a parameter 'strict' to trigger this new behavior
in applyFilterVarsStruct().

There is also a unit test added in a separate commit that explicitely
checks this case.

Signed-off-by: Frieder Schrempf <dev@fris.de>

show more ...

Fix code style violations

Eliminate warnings in PHP 8

Introduce new factory methods for data access and deprecate old ones

Automatic coding style fixes

Pass current time instead of 0 to fetch data of latest page revision

method splitted, test provided

Adds userinfo to value placeholders

The commit introduces 3 additional placeholders to be used in filters:
* $USER.name$
* $USER.mail$
* $USER.grps$

This may be particularly useful with struc

Adds userinfo to value placeholders

The commit introduces 3 additional placeholders to be used in filters:
* $USER.name$
* $USER.mail$
* $USER.grps$

This may be particularly useful with structgroup plugin.

show more ...

Fix typo

At least it was consistent...

Throw on missing column

This happens if the user explicitly enters a column that does not exist in the
schema. This error was previously silently ignored.

This adjustment notifies the user that the

Throw on missing column

This happens if the user explicitly enters a column that does not exist in the
schema. This error was previously silently ignored.

This adjustment notifies the user that there is an error.

show more ...

Add compareValue() abstract base type & lookup

This fixes a bug, that caused the $STRUCT.table.field$ filter syntax to
be broken for lookup fields. Struct was comparing the row-id of the
argument-c

Add compareValue() abstract base type & lookup

This fixes a bug, that caused the $STRUCT.table.field$ filter syntax to
be broken for lookup fields. Struct was comparing the row-id of the
argument-column to the raw value of the referenced column at the
filtered lookup.

There were multiple options to fix this bug:
1. Add a new function to the AbstractBaseType() that return raw value by
default (this is the approach implemented by this commit)
2. Add a function to the lookup type only and use introspection to call
it if it exists.
3. Do not compare the values in the referenced columns, but compare only
the row-ids

The problem with approach 3: It is not possible to compare such
lookup-column to any other column except lookups and this is not what we
want.
Approaches 1 and 2 have different trade-offs on where additional
code/complexity is created. I decided for approach 1 because it is the
cleaner overall approach and we might want to use this functionality for future
types as well.

SPR-875

show more ...