| a5b145eb | 18-Jun-2026 |
Andreas Gohr <gohr@cosmocode.de> |
Use real Apache Tika sample files and trim the test suite
Replace the generated fixtures with real documents from the Apache Tika test corpus (tika-* files plus download.sh and a short README) and r
Use real Apache Tika sample files and trim the test suite
Replace the generated fixtures with real documents from the Apache Tika test corpus (tika-* files plus download.sh and a short README) and rework the tests to run against them:
- Samples.php: drop the tempDir()/cleanup() single-call wrappers, let withoutPart() and corrupt() manage their own temp files, and build the "container missing a member" input with php-archive instead of ext-zip. - ExtractorFactoryTest: stop re-typing the EXTRACTORS map; keep only the case/path normalisation cases and own the missing-file/corrupt error paths centrally. - Per-format extractor tests: drop the duplicated shared error tests and their setUp/tearDown, keeping the format-specific assertions; move the multibyte-UTF8 check into DocxExtractorTest. - Remove HelperTest and SampleFilesTest as redundant. - Add a real-sample test for the plain-text extractor.
show more ...
|
| 6b6a7c2c | 17-Jun-2026 |
Andreas Gohr <gohr@cosmocode.de> |
Test against real files instead of generated fixtures
A hand-built fixture only encodes our belief about a file format; if that belief is wrong the extractor is written to match it and both agree on
Test against real files instead of generated fixtures
A hand-built fixture only encodes our belief about a file format; if that belief is wrong the extractor is written to match it and both agree on a fiction that never matches reality. Replace the synthetic FixtureBuilder with real files produced by real applications.
- _test/data/regenerate.sh rebuilds the edge-case samples from inline plain-text sources: LibreOffice converts flat-ODF to the office formats, ImageMagick + exiftool produce images with real IPTC/EXIF metadata. - New samples cover headers/footers, tab/line-break handling, multi-sheet name resolution, speaker notes, merged/covered cells and image metadata. - Error-path tests derive broken inputs from real files (Samples::withoutPart removes one ZIP member, Samples::corrupt writes garbage) rather than fabricating containers. - Scenarios real tools never emit (unnamed sheet, repeated filled-text cell, the synthetic MAX_REPEAT extreme) are dropped rather than faked.
Delete FixtureBuilder; add the Samples helper. _test is export-ignored so the sample binaries never ship in release tarballs.
show more ...
|
| 37c5feaa | 17-Jun-2026 |
Andreas Gohr <gohr@cosmocode.de> |
Use DokuWiki's temp dir and clean up in destructor
Allocate the archive-unpack temp dir in DokuWiki's own temp dir ($conf['tmpdir']) via core's io_mktmpdir(), and remove it with io_rmdir(), instead
Use DokuWiki's temp dir and clean up in destructor
Allocate the archive-unpack temp dir in DokuWiki's own temp dir ($conf['tmpdir']) via core's io_mktmpdir(), and remove it with io_rmdir(), instead of the system temp dir. Add a destructor that repeats the cleanup as a safety net so the dir is removed even if the process dies before extract()'s finally block runs. Align the test FixtureBuilder on the same core helpers.
show more ...
|
| e3bf24fb | 17-Jun-2026 |
Andreas Gohr <gohr@cosmocode.de> |
Expand test coverage and fix two extractor bugs
Broaden the test suite from happy-path fixtures to the branching logic that was previously unexercised, and fix two real bugs the new coverage exposed
Expand test coverage and fix two extractor bugs
Broaden the test suite from happy-path fixtures to the branching logic that was previously unexercised, and fix two real bugs the new coverage exposed:
- XlsxExtractor: resolve sheet name->file mapping and tab order through xl/workbook.xml + xl/_rels/workbook.xml.rels instead of pairing sorted worksheet filenames with names positionally, which mismatched them whenever tab order differed from file numbering. Falls back to positional/SheetN naming when the workbook or its rels are absent. - ImageExtractor: PHP's exif reader decodes Windows XP tags into a WINXP section under short names (Title/Comment/Author/Keywords/Subject), not as XPTitle etc., so those fields were silently dropped. List the short names first, keep the XP* raw names as a cross-version fallback.
Tests: - FixtureBuilder gains DOCX header/footer, PPTX notes, multi-sheet XLSX (+ no-workbook/no-worksheet variants), rich ODS (repeated columns, covered cells, multi-paragraph cells, MAX_REPEAT cap, unnamed-sheet fallback), a hand-packed TIFF with EXIF incl. a UTF-16LE XPTitle, and a public zip() helper for composing broken containers. - New critical-path coverage: header/footer, speaker notes, ODS edge cases, XLSX multi-sheet/fallback/no-worksheet guards, EXIF/TIFF incl. XP decode, and per-format missing-part/missing-file error paths. - Routing, reject and supports() tests converted to data providers, plus a drift guard that routes every supportedExtensions() entry through forFile(). - Real-world LibreOffice samples under _test/data covered by SampleFilesTest.
47 -> 155 tests, 104 -> 231 assertions.
show more ...
|