extension: don't crash on malformed conflict/dependency ids

The conflicts and depends fields in the repository metadata are free
form text entered by extension authors and may contain values that ar

extension: don't crash on malformed conflict/dependency ids

The conflicts and depends fields in the repository metadata are free
form text entered by extension authors and may contain values that are
not valid extension ids, such as "sprintdoc template". Since 9af82229f
routed every Extension construction through the strict setBase()
validation, such a value made Extension::createFromId() throw an
uncaught RuntimeException while building the notices, taking down the
whole extension manager.

Skip entries that cannot be parsed into an extension id when checking
for missing dependencies and conflicts.

As an immeadiate fix this will also be fixed in the repository API to
avoid sending invalid extension IDs to the extension manager.

Fixes #4691

show more ...

fix(extension): skip invalid directories when listing extensions

A leftover directory whose name is not a valid extension base (e.g.
"myplugin (copy)") made Extension::setBase() throw, which propaga

fix(extension): skip invalid directories when listing extensions

A leftover directory whose name is not a valid extension base (e.g.
"myplugin (copy)") made Extension::setBase() throw, which propagated
out of the unguarded getPlugins()/getTemplates() calls and fataled the
whole Extension Manager page and the extension list CLI.

Catch the exception per-directory in readExtensionsFromDirectory() so a
single stray directory is skipped and logged instead of breaking every
caller. The throw is kept for the install path.

show more ...

extension: validate base name to prevent path traversal on install

The extension base name flowed unsanitized from an uploaded archive's
plugin.info.txt (or an extension id) into getInstallDir(), wh

extension: validate base name to prevent path traversal on install

The extension base name flowed unsanitized from an uploaded archive's
plugin.info.txt (or an extension id) into getInstallDir(), where
fullpath() collapses '..' segments. A crafted base such as
'../../../../evil' therefore resolved outside lib/plugins/, letting
dircopy() write the archive contents to an arbitrary web-writable path.

Route every base assignment through a new setBase() that rejects
anything other than a bare extension name.

Note: this is not really a security concern since plugins can execute
arbitrary code by design. The is mostly to make sure, plugin code is not
installed accidentally at the wrong location.

show more ...

ExtensionManager: get base from plugin classes. fixes #4484

When installing a plugin that has no plugin.info.txt, we need to figure
out where it belongs from other data. Previously we checked the ar

ExtensionManager: get base from plugin classes. fixes #4484

When installing a plugin that has no plugin.info.txt, we need to figure
out where it belongs from other data. Previously we checked the archive
name or folder within. This will fail for archives generated from github
branches as the plugin would be named "dokuwiki-plugin-foobar" or "master".

This implements looking for known plugin type php files, parsing them
with PHP's parser and extracting the class name. The base name is in
that class name.

Seems to work fine in my unit and manual tests.

show more ...

Extension Manager: adjust test

Since we now protect the currently used template, the test needs to be
adjusted.

Extension Manager: small language adjustments

Extension Manager: updated tests

First start at refactoring the extension manager

The aim is to readd the existing functionality into proper classes, then
extend from there.

Update extension.test.php

fix for failing test due to aligned url entry

ref https://github.com/dokuwiki/dokuwiki/issues/4270#issuecomment-2088208289