Preventing auto-filling of passwords in config #4362

We previously had set autocomplete="off" on password fields, but
browsers seem to ignore that now.

MDN suggests [1] to use autocomplete="new-pas

Preventing auto-filling of passwords in config #4362

We previously had set autocomplete="off" on password fields, but
browsers seem to ignore that now.

MDN suggests [1] to use autocomplete="new-password", so that's what's
used now. In addition autocomplete="off" is set on the form as a whole.

Will that fix the issue once and for all? Doubtful:

> This attribute is a hint to browsers; some may not comply with it.

[1] https://developer.mozilla.org/en-US/docs/Web/Security/Practical_implementation_guides/Turning_off_form_autocompletion

show more ...

code style: line breaks

coding style: control flow whitespaces

codestyle adjustments: function declaration braces/spaces

codestyle adjustments: class declaration braces

Apply rector renames

Apply remaining rector fixes to lib

Apply rector fixes to config plugin

fix no error message was shown on input errors

Merge branch 'master' into psr2

Added an ID to config manager form

Goal is to make it easy to create an alternate "save" button with a 'form' attribute pointing to that ID, be it in pagetools or anywhere else (related to https://g

Added an ID to config manager form

Goal is to make it easy to create an alternate "save" button with a 'form' attribute pointing to that ID, be it in pagetools or anywhere else (related to https://github.com/splitbrain/dokuwiki/issues/764)

show more ...

prefer array rather than string with the wl() parameter

fix typo of extra bracket

unify send_redirect(wl()) parameters
- always use absolute URL
- use static string instead of array if no concat is required
- use '&' instead of '&'

do not initialize the configuration in constructor

The class gets instantiated for showing the admin menu. There's no need
to always load the whole configuration there. It's only needed when the
Con

do not initialize the configuration in constructor

The class gets instantiated for showing the admin menu. There's no need
to always load the whole configuration there. It's only needed when the
Config screen is actually shown. So loading it in handler() instead
should be good enough.

show more ...

make undefined settings output work again

removed fixme that had been fixed

fix language and TOC handling

sucess is green

Moved settings to their own namespace

replaced ptln() with echo

We used to use ptln to ensure the produced HTML source code is somewhat
readable, but with modern HTML inspectors this is no longer necessary
and makes the PHP source code

replaced ptln() with echo

We used to use ptln to ensure the produced HTML source code is somewhat
readable, but with modern HTML inspectors this is no longer necessary
and makes the PHP source code ugly.

show more ...

PSR2 adjustments for admin class

first go over the settings classes for PSR-2

introduce getType for Settings

moved language loading to the loader