| 08b5f5eb | 14-May-2026 |
Andreas Gohr <andi@splitbrain.org> |
fix(authad): avoid warning when initAdLdap is called before opts is populated
$this->opts is initialized as an empty array, so the is_array() guard in
initAdLdap() passed even when no domain had bee
fix(authad): avoid warning when initAdLdap is called before opts is populated
$this->opts is initialized as an empty array, so the is_array() guard in
initAdLdap() passed even when no domain had been loaded yet, producing an
"Undefined array key 'domain'" warning on PHP 8 (e.g. from getUserCount()
called by the Popularity admin page).
Fixes #4501
show more ...
|
| 73dc0a89 | 06-May-2026 |
Andreas Gohr <andi@splitbrain.org> |
fix(mail): keep '&' intact in mailto links with multiple query params
Move the email-handling helpers (obfuscate, mail_isvalid,
mail_quotedprintable_encode, mail_setup) out of the procedural
inc/mai
fix(mail): keep '&' intact in mailto links with multiple query params
Move the email-handling helpers (obfuscate, mail_isvalid,
mail_quotedprintable_encode, mail_setup) out of the procedural
inc/mail.php into a namespaced dokuwiki\MailUtils class plus a new
Mailer::configInit(), and add a separate MailUtils::obfuscateUrl() for
the mailto-href context.
The xhtml renderer and PluginTrait now build the link label and the
href separately: the address half is run through the mailguard
obfuscation, the query string is preserved verbatim with only HTML
escaping applied. This fixes #1690 — in 'visible' mode the previous
code rawurlencoded the entire address+query, turning '?' into '%3F' and
breaking multi-parameter mailto links; in all modes the query string is
no longer mangled by the [at]/[dot] substitution.
Core call sites (Mailer, auth, LegacyApiCore, common, the xhtml
renderer, the parser, the bundled config/styling/usermanager plugins)
are migrated to MailUtils directly. The old top-level functions and
PREG_PATTERN_VALID_EMAIL constant remain as deprecated shims with
rector mappings.
Tests for obfuscate / mail_isvalid / mail_quotedprintable_encode are
consolidated into a single _test/tests/MailUtilsTest.php and extended
with regression coverage for the multi-parameter, double-escape and
URL-shape cases.
Closes #1690
Replaces #1964
show more ...
|
| 90c2f6e3 | 18-Apr-2026 |
Andreas Gohr <andi@splitbrain.org> |
Clean up stale realip references after client_ip_header rename
Update docblocks in Ip.php and common.php, fix old tests to use
the new config key, remove outdated translations, fix method casing
in
Clean up stale realip references after client_ip_header rename
Update docblocks in Ip.php and common.php, fix old tests to use
the new config key, remove outdated translations, fix method casing
in test, and add example to English config description.
show more ...
|
| 6ebc01d8 | 23-Mar-2026 |
Matt Van Horn <455140+mvanhorn@users.noreply.github.com> |
feat: add diff to disableactions config option
Add 'diff' as a checkbox option in the disableactions configuration
setting, allowing admins to disable the diff action separately from
other actions l
feat: add diff to disableactions config option
Add 'diff' as a checkbox option in the disableactions configuration
setting, allowing admins to disable the diff action separately from
other actions like revisions or edit.
When diff is disabled, diff icon links in revision lists and recent
changes are hidden, and the "compare" submit button on page and media
revision pages is removed.
Fixes #4504
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
show more ...
|