line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

remove DOKU_INC checks

There is no need for this check, since these files should not have any
main code that is executed on direct call.

Fixes PSR1.Files.SideEffects.FoundWithSymbols

Fix PHP Notices: Reduce error log noise

While DokuWiki suppresses PHP Notices they are still a code smell and
should be fixed. This fixes some PHP Notices that occurred.

Some of these fixes could b

Fix PHP Notices: Reduce error log noise

While DokuWiki suppresses PHP Notices they are still a code smell and
should be fixed. This fixes some PHP Notices that occurred.

Some of these fixes could be refactored into nicer code once we move to
PHP 7 and get access to the `??` operator.

show more ...

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

do not accept empty or root $base in search. fixes #1452

You really never want to search the whole filesystem, so something must
have gone wrong. Better abort than go on.

Many PHPDocs, some unused and dyn declared vars

many PHPDocs
some unused variables
some dynamically declared variables declared

more scrutinizer issue improvements

add defaults to phpdocs of search universal

another instance of empty() where an array key might not exist

use \!empty() rather than error suppression

refactor to take into account missing value

use isset() + ?: or error suppression where value may not be set

use empty() where array values might not be set

Merge pull request #380 from splitbrain/phpstrict

Php strict

replace boolean conditional checks on possibly uninitialized vars with \!empty/empty/isset as appropriate

inc/search.php phpdocs

update phpdocs inc/search.php

Remove search_references() and the refshow configuration option

The refshow configuration option wasn't used as described anymore
already in the latest release and after the introduction of the medi

Remove search_references() and the refshow configuration option

The refshow configuration option wasn't used as described anymore
already in the latest release and after the introduction of the media
usage index the parameter is also no longer relevant for internal
optimization. The only place where it was still used is the no longer
used search_references()-function which is removed here, too.

show more ...

Revert the search depth behavior changes from #154

This reverts parts of the changes from #154: Before merging the pull
request, a depth of 1 returned just the pages in the root namespace.
With the

Revert the search depth behavior changes from #154

This reverts parts of the changes from #154: Before merging the pull
request, a depth of 1 returned just the pages in the root namespace.
With the changes in the pull request, a depth of 1 also returned pages
in subnamespaces of the root namespace (as it was also tested in the test case).
This reverts this part of the changes and a depth of 1 returns just the
pages in the root namespace again.

show more ...

removed a bunch of functions which were deprecated in 2005/2006

search: pass empty $sort to skip sorting

change to use natural order sorting

ensure parameter is passed down during recursion

add documentation for sort parameter, change false to 'natural'

sp.