Cleanup of function sort_filenames() [name changed]

Name changed from natural_sort() to sort_filenames().
Fixed behavior without collator: page name sorting reflected in filename array.
Fix of searc

Cleanup of function sort_filenames() [name changed]

Name changed from natural_sort() to sort_filenames().
Fixed behavior without collator: page name sorting reflected in filename array.
Fix of search() function in "search.php".

Functions that call search() and now have the expected results:
Ajax.php:188, callMedians(): Return subnamespaces for the Mediamanager
Ajax.php:322, callIndex(): Return sub index for index view
Ajax.php:392, callLinkwiz(): List matching namespaces and pages for the link wizard
html.php:908, html_index(): Display page index
media.php:713, media_filelist(): List all files in a given Media namespace
media.php:1528, media_searchlist(): List all files found by the search request
media.php:1966, media_nstree(): Build a tree outline of available media namespaces
Remote\ApiCore.php:349, readNamespace(): List all pages in the given namespace (and below)
Remote\ApiCore.php:432, listAttachments(): List all media files

Screens fixed:
- Index
- All media lists (including fullscreen)
- Internal link suggestion when editing a page

show more ...

Reimplementation of strcmp() [continued]

Fix of sort_search_fulltext() function in "search.php".
This function does not seem to be used anywhere.

Bootstrap and reimplementation of natsort()

New file "sort.php" for sort functions.
Inclusion of "sort.php" in the bootstrap ("load.php").
Reimplementation of natsort() using collator.
Fix of search

Bootstrap and reimplementation of natsort()

New file "sort.php" for sort functions.
Inclusion of "sort.php" in the bootstrap ("load.php").
Reimplementation of natsort() using collator.
Fix of search() function in "search.php".

Functions that call search() and now have the expected results:
Ajax.php:188, callMedians(): Return subnamespaces for the Mediamanager
Ajax.php:322, callIndex(): Return sub index for index view
Ajax.php:392, callLinkwiz(): List matching namespaces and pages for the link wizard
html.php:908, html_index(): Display page index
media.php:713, media_filelist(): List all files in a given Media namespace
media.php:1528, media_searchlist(): List all files found by the search request
media.php:1966, media_nstree(): Build a tree outline of available media namespaces
Remote\ApiCore.php:349, readNamespace(): List all pages in the given namespace (and below)
Remote\ApiCore.php:432, listAttachments(): List all media files

Screens fixed:
- Index
- All media lists (including fullscreen)
- Internal link suggestion when editing a page

show more ...

coding style PSR-12

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

Merge branch 'master' into psr2

Security: Fix ACL check in search_allpages

Due to the changes in 8f34cf3d32c9c091caa658472bd4e3a8270969a8, the ACL
check in search_allpages was only executed when 'skipacl' has been
explicitly set t

Security: Fix ACL check in search_allpages

Due to the changes in 8f34cf3d32c9c091caa658472bd4e3a8270969a8, the ACL
check in search_allpages was only executed when 'skipacl' has been
explicitly set to false. Otherwise, only ACLs for namespaces were
checked (unless the sneakyacl option was passed). The documentation
states that the default for 'skipacl' is false, so setting it to false
shouldn't be necessary.

From all I can see, this does not concern DokuWiki itself as
search_allpages is never used without the 'skipacl' option explicitly
set to true or false. However, this causes serious security issues in
plugins that rely on this ACL check in search_allpages like the include
plugin.

show more ...

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

remove DOKU_INC checks

There is no need for this check, since these files should not have any
main code that is executed on direct call.

Fixes PSR1.Files.SideEffects.FoundWithSymbols

Fix PHP Notices: Reduce error log noise

While DokuWiki suppresses PHP Notices they are still a code smell and
should be fixed. This fixes some PHP Notices that occurred.

Some of these fixes could b

Fix PHP Notices: Reduce error log noise

While DokuWiki suppresses PHP Notices they are still a code smell and
should be fixed. This fixes some PHP Notices that occurred.

Some of these fixes could be refactored into nicer code once we move to
PHP 7 and get access to the `??` operator.

show more ...

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

do not accept empty or root $base in search. fixes #1452

You really never want to search the whole filesystem, so something must
have gone wrong. Better abort than go on.

Many PHPDocs, some unused and dyn declared vars

many PHPDocs
some unused variables
some dynamically declared variables declared

more scrutinizer issue improvements

add defaults to phpdocs of search universal

another instance of empty() where an array key might not exist

use \!empty() rather than error suppression

refactor to take into account missing value

use isset() + ?: or error suppression where value may not be set

use empty() where array values might not be set

Merge pull request #380 from splitbrain/phpstrict

Php strict

replace boolean conditional checks on possibly uninitialized vars with \!empty/empty/isset as appropriate

inc/search.php phpdocs

update phpdocs inc/search.php

Remove search_references() and the refshow configuration option

The refshow configuration option wasn't used as described anymore
already in the latest release and after the introduction of the medi

Remove search_references() and the refshow configuration option

The refshow configuration option wasn't used as described anymore
already in the latest release and after the introduction of the media
usage index the parameter is also no longer relevant for internal
optimization. The only place where it was still used is the no longer
used search_references()-function which is removed here, too.

show more ...