Use str_starts_with/str_ends_with

�� Rector and PHPCS fixes

siplify isset check

unused items, phpdocs

code style: line breaks

code style: operator spacing

coding style: control flow line breaks

coding style: control flow whitespaces

codestyle adjustments: function declaration braces/spaces

codestyle adjustments: function argument spacing

Apply rector fixes to the rest of inc

some more fixes for undefined vars

This makes more use of $INPUT to access $_SERVER and fixes a warning in
one of the search methods.

Merge pull request #3372 from splitbrain/mediaitems

Media Manager Refactoring

Fix Undefined array key "ns" in search.php

Shown when expanding namespaces in Media Manager.

rename namespace Media to File

This is a bit more generic and allows us to have additional File
abstractions in here later.

make use of the new media file classes

This just crudely replaces the calls to the old functions with usage of
the new classes. This however already works and makes (manual) testing
of these classes

make use of the new media file classes

This just crudely replaces the calls to the old functions with usage of
the new classes. This however already works and makes (manual) testing
of these classes easier.

Next steps: remove the old media_printfile and media_printfile_thumbs
methods and fix/drop/replace the tests depending on them. search_media
might be obsolete, too already.

For search results the display classes need to show full namespaces.
This needs to be fixed again. No idea about the jump mechanism, yet.

show more ...

wrap sorting functions into their own class

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to in

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to intl_ksort()
- new function intl_asort()
- sort_filenames() renamed to intl_asortFN()
Updated documentation.

show more ...

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is us

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is used by ft_pageLookup().

Functions that call ft_pageLookup() and now have the expected results:
Action\Search.php:69, execute(): run the search
Ajax.php:50, callQsearch(): Searches for matching pagenames
Ajax.php:352, callLinkwiz(): List matching namespaces and pages for the link wizard

Screens fixed:
- Search (list of matching pagenames)
- Quick search (when typing)
- Internal link suggestion when editing a page (when nothing was typed)

Fix of menuSort() function in "Ui/Admin.php".

Screens fixed:
- Administration

Fix of sort_search_fulltext() function in "search.php".
This function does not seem to be used anywhere.

show more ...

Cleanup of function sort_filenames() [name changed]

Name changed from natural_sort() to sort_filenames().
Fixed behavior without collator: page name sorting reflected in filename array.
Fix of searc

Cleanup of function sort_filenames() [name changed]

Name changed from natural_sort() to sort_filenames().
Fixed behavior without collator: page name sorting reflected in filename array.
Fix of search() function in "search.php".

Functions that call search() and now have the expected results:
Ajax.php:188, callMedians(): Return subnamespaces for the Mediamanager
Ajax.php:322, callIndex(): Return sub index for index view
Ajax.php:392, callLinkwiz(): List matching namespaces and pages for the link wizard
html.php:908, html_index(): Display page index
media.php:713, media_filelist(): List all files in a given Media namespace
media.php:1528, media_searchlist(): List all files found by the search request
media.php:1966, media_nstree(): Build a tree outline of available media namespaces
Remote\ApiCore.php:349, readNamespace(): List all pages in the given namespace (and below)
Remote\ApiCore.php:432, listAttachments(): List all media files

Screens fixed:
- Index
- All media lists (including fullscreen)
- Internal link suggestion when editing a page

show more ...

Reimplementation of strcmp() [continued]

Fix of sort_search_fulltext() function in "search.php".
This function does not seem to be used anywhere.

Bootstrap and reimplementation of natsort()

New file "sort.php" for sort functions.
Inclusion of "sort.php" in the bootstrap ("load.php").
Reimplementation of natsort() using collator.
Fix of search

Bootstrap and reimplementation of natsort()

New file "sort.php" for sort functions.
Inclusion of "sort.php" in the bootstrap ("load.php").
Reimplementation of natsort() using collator.
Fix of search() function in "search.php".

Functions that call search() and now have the expected results:
Ajax.php:188, callMedians(): Return subnamespaces for the Mediamanager
Ajax.php:322, callIndex(): Return sub index for index view
Ajax.php:392, callLinkwiz(): List matching namespaces and pages for the link wizard
html.php:908, html_index(): Display page index
media.php:713, media_filelist(): List all files in a given Media namespace
media.php:1528, media_searchlist(): List all files found by the search request
media.php:1966, media_nstree(): Build a tree outline of available media namespaces
Remote\ApiCore.php:349, readNamespace(): List all pages in the given namespace (and below)
Remote\ApiCore.php:432, listAttachments(): List all media files

Screens fixed:
- Index
- All media lists (including fullscreen)
- Internal link suggestion when editing a page

show more ...

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

Merge branch 'master' into psr2

Security: Fix ACL check in search_allpages

Due to the changes in 8f34cf3d32c9c091caa658472bd4e3a8270969a8, the ACL
check in search_allpages was only executed when 'skipacl' has been
explicitly set t

Security: Fix ACL check in search_allpages

Due to the changes in 8f34cf3d32c9c091caa658472bd4e3a8270969a8, the ACL
check in search_allpages was only executed when 'skipacl' has been
explicitly set to false. Otherwise, only ACLs for namespaces were
checked (unless the sneakyacl option was passed). The documentation
states that the default for 'skipacl' is false, so setting it to false
shouldn't be necessary.

From all I can see, this does not concern DokuWiki itself as
search_allpages is never used without the 'skipacl' option explicitly
set to true or false. However, this causes serious security issues in
plugins that rely on this ACL check in search_allpages like the include
plugin.

show more ...