remove deprecated code

This removes code that has been marked as deprecated before 2020.

Apply rector fixes to inc/parser

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had legitimate use of these options.

If someone needs the functionality, it can easily be added back using a
plugin. But I prefer to give users one less option to shoot themselves
in the foot.

Removal of the translations for the config strings can follow after this
has been merged.

show more ...

Restore backwards compatibility for Doku_Parser

Apparently, #2358 introduced a breaking change to the constructor and
usage of Doku_Parser, which broke some plugins, e.g. the move plugin in
michitux

Restore backwards compatibility for Doku_Parser

Apparently, #2358 introduced a breaking change to the constructor and
usage of Doku_Parser, which broke some plugins, e.g. the move plugin in
michitux/dokuwiki-plugin-move#176

This patch should restore the legacy behavior of this deprecated class.

show more ...

moved Parser to Parsing namespace

moved all parsing related namespaces to their own

cleaned up Doku_Handler for PSR-2

adjusted the Lexer for PSR-2

adjusted Doku_Parser for PSR-2

All properties are declared protected. The handler is now set via the
constructor.

split out parser modes into their own files

This moves all the parser classes into their own namespace and files.
Next up are the handler classes.

I'm not sure about the namespace, yet. A nested na

split out parser modes into their own files

This moves all the parser classes into their own namespace and files.
Next up are the handler classes.

I'm not sure about the namespace, yet. A nested namepspace Parser\Modes
would probably make more sense... we'll see.

This also removes the duplicated coded in the Plugin mode. We now use
the plugin trait and can inherit from AbstractMode instead.

show more ...

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

remove DOKU_INC checks

There is no need for this check, since these files should not have any
main code that is executed on direct call.

Fixes PSR1.Files.SideEffects.FoundWithSymbols

fix regex character class. fixes #2301

Merge pull request #1988 from LarsGit223/issue936

Corrected external link syntax, now requires preceding whitespace.

Corrected external link syntax, now requires preceding whitespace. Fixes #936.

Corrected internal link pattern to properly handle included square brackets. Fixes #829.

Adjusted pattern for matching media links to properly handle a single '}' in the link text. Fixes #1587.

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

more object type hints and removal of '&' operator before objects

Changes for PHP 7 Compatibility
- replace PHP4 style class constructor function names (based on
class name) with php 5 __construct()
Also remove some '&' reference operators used with objects
And a

Changes for PHP 7 Compatibility
- replace PHP4 style class constructor function names (based on
class name) with php 5 __construct()
Also remove some '&' reference operators used with objects
And add some object type hints

show more ...

Scrutinizer Auto-Fixes

This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

just some more doc blocks

reintroduce a tiny bit of duplication

This reads some duplication in the from of haveing a Doku_Parser_Mode
and Doku_Parser_Mode_Plugin class which are basically the same but only
the latter extends

reintroduce a tiny bit of duplication

This reads some duplication in the from of haveing a Doku_Parser_Mode
and Doku_Parser_Mode_Plugin class which are basically the same but only
the latter extends DokuWiki_Plugin. This avoids the performance/RAM
problems mentioned in my previous commit. An interface keeps both
logically together.

With PHP 5.4 further deduplication could be done via Traits.

show more ...

remove duplicate plugin code for syntax plugins

This makes Doku_Parser_Mode inherit from DokuWiki_Plugin which allows
for the removal of a bunch of duplicate code form
DokuWiki_Syntax_Plugin. This m

remove duplicate plugin code for syntax plugins

This makes Doku_Parser_Mode inherit from DokuWiki_Plugin which allows
for the removal of a bunch of duplicate code form
DokuWiki_Syntax_Plugin. This makes the code easier to maintain and makes
sure all DokuWiki plugins are actual instances of DokuWiki_Plugin.

However this adds a bunch of functions to the "normal" parser modes that
don't need them which could have performance/RAM implications.

show more ...

FS#1833 (b)
Prevent table entry syntax swallowing multiple preceeding blank lines
(a) this shouldn't be necessary, blank lines are handled by paragraph
processing
(b) avoids issues with greedy ta

FS#1833 (b)
Prevent table entry syntax swallowing multiple preceeding blank lines
(a) this shouldn't be necessary, blank lines are handled by paragraph
processing
(b) avoids issues with greedy table syntax competing with plugins

show more ...