eliminate warnings in OR search

fix error on phrase search with no results. fixes #4355

When no pages for a phrase can be found, eg. because the index is still
empty, end($stack) returns false instead of an array, breaking the
fol

fix error on phrase search with no results. fixes #4355

When no pages for a phrase can be found, eg. because the index is still
empty, end($stack) returns false instead of an array, breaking the
following loop.

show more ...

�� Rector and PHPCS fixes

inc/fulltext Result from splice could be empty

The code for `AND` and `OR` assumes the call to splice will always
return 2 elements, which isn't the case if no terms are found.

Example log messages

inc/fulltext Result from splice could be empty

The code for `AND` and `OR` assumes the call to splice will always
return 2 elements, which isn't the case if no terms are found.

Example log messages:

PHP Warning: Undefined array key 0 in .../dokuwiki/inc/fulltext.php on line 134
PHP Warning: Undefined array key 1 in .../dokuwiki/inc/fulltext.php on line 134
PHP Warning: foreach() argument must be of type array|object, null given in .../dokuwiki/inc/fulltext.php on line 614

Simplified example, via `php -a`:

php > $arr = [];
php > [$a, $b] = array_splice($arr, -2);
PHP Warning: Undefined array key 0 in php shell code on line 1
PHP Warning: Undefined array key 1 in php shell code on line 1

To clear the warning we check if the result is empty and break early,
otherwise we pass the result into `ft_resultCombine` or
`ft_resultUnite`, which both handle the length 1 arrays.

show more ...

Use str_starts_with/str_ends_with

code style: line breaks

code style: operator spacing

code style: indent fixes

coding style: control flow line breaks

coding style: control flow whitespaces

coding style: function call spacing

codestyle adjustments: function declaration braces/spaces

codestyle adjustments: function argument spacing

Apply rector fixes to the rest of inc

Fix unititialized string offset access in query parser

The code always tried to access positon 2 of the parsed token, even for
tokens shorter than that (like OR)

fixes #3896

Properly quick search in titles with UTF-8 chars.

Fixes #3808

exclude ns in pagelook ups

Enables excluding namespaces in the quick search of the searchform
https://github.com/Klap-in/dokuwiki-plugin-searchform/issues/7

fix undefined array warning in fulltext indexer

This was surfaced on PHP8 and might actually have been a bug before.

wrap sorting functions into their own class

Page sort added in _ft_pageSearch()

_ft_pageLookup() provided sorted results, but _ft_pageSearch() did not.

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to in

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to intl_ksort()
- new function intl_asort()
- sort_filenames() renamed to intl_asortFN()
Updated documentation.

show more ...

Cleanup of function sort_pagenames() [name changed]

Name changed from sort_pages() to sort_pagenames().
Fixed behavior without collator: sort() with flags SORT_NATURAL and SORT_FLAG_CASE.

Fix of ft

Cleanup of function sort_pagenames() [name changed]

Name changed from sort_pages() to sort_pagenames().
Fixed behavior without collator: sort() with flags SORT_NATURAL and SORT_FLAG_CASE.

Fix of ft_backlinks() and ft_mediause() function in "fulltext.php".

Functions that call ft_backlinks() and now have the expected results:
html.php:1085, html_backlinks(): display backlinks
Remote\ApiCore.php:456, listBackLinks(): Return a list of backlinks

Functions that call ft_mediause() and now have the expected results:
media.php:222, media_inuse(): Convenience function to check if a media file is still in use
media.php:1199, media_details(): Prints mediafile tags

Screens fixed:
- Backlinks
- List of pages that references a media file (View tab in the 3rd column of Media Manager)

Fix of callSuggestions() function in "Ajax.php".

Screens fixed:
- OpenSearch suggestions: /lib/exe/ajax.php?call=suggestions&q={query}

show more ...

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is us

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is used by ft_pageLookup().

Functions that call ft_pageLookup() and now have the expected results:
Action\Search.php:69, execute(): run the search
Ajax.php:50, callQsearch(): Searches for matching pagenames
Ajax.php:352, callLinkwiz(): List matching namespaces and pages for the link wizard

Screens fixed:
- Search (list of matching pagenames)
- Quick search (when typing)
- Internal link suggestion when editing a page (when nothing was typed)

Fix of menuSort() function in "Ui/Admin.php".

Screens fixed:
- Administration

Fix of sort_search_fulltext() function in "search.php".
This function does not seem to be used anywhere.

show more ...

Reimplementation of sort()

Reimplementation of sort() using collator.
Fix of ft_backlinks() and ft_mediause() function in "fulltext.php".

Functions that call ft_backlinks() and now have the expecte

Reimplementation of sort()

Reimplementation of sort() using collator.
Fix of ft_backlinks() and ft_mediause() function in "fulltext.php".

Functions that call ft_backlinks() and now have the expected results:
html.php:1085, html_backlinks(): display backlinks
Remote\ApiCore.php:456, listBackLinks(): Return a list of backlinks

Functions that call ft_mediause() and now have the expected results:
media.php:222, media_inuse(): Convenience function to check if a media file is still in use
media.php:1199, media_details(): Prints mediafile tags

Screens fixed:
- Backlinks
- List of pages that references a media file (View tab in the 3rd column of Media Manager)

show more ...

Reimplementation of strcmp()

Reimplementation of strcmp() using collator.
Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is used by ft_pageLook

Reimplementation of strcmp()

Reimplementation of strcmp() using collator.
Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is used by ft_pageLookup().

Functions that call ft_pageLookup() and now have the expected results:
Action\Search.php:69, execute(): run the search
Ajax.php:50, callQsearch(): Searches for matching pagenames
Ajax.php:352, callLinkwiz(): List matching namespaces and pages for the link wizard

Screens fixed:
- Search (list of Matching pagenames)
- Quick search (when typing)
- Internal link suggestion when editing a page (when nothing was typed)

show more ...