check if user is empty in userSubscription, fixes #2003

This makes sure SubscriberRegexBuilder is used properly and won't throw exception in userSubscription.

Renamed constant to RECENTS_ONLY_CREATION

This clarifies that it also works when requesting media changelog.

Implemented only_new option for RSS feed, so you can request RSS feed that contains only new files.

♻️ Rename flag to better show actual effect

This flag only causes parameters with empty strings to be skipped,
not all empty() values.

PHP8 fix part 5: Trying to access array offset on value of type bool/null

PHP8 fix part 3: Trying to access array offset on value of type bool/null

PHP8 fix part 1: Trying to access array offset on value of type bool/null

Fix curly brace syntax. PHP 7.3 deprecations in inc/ directory.

Merge pull request #2892 from splitbrain/trusted-proxies

clientIP: add trustedproxy, return first untrusted IP instead of the last one

Merge pull request #2067 from BS666/dontshowpageintracewhenrestricted

prevent pages to be shown in trace if you don't have rights to read

Merge pull request #2890 from splitbrain/email-with-revid

Include rev_id in new revision link in notification email

Merge branch 'master' into dontshowpageintracewhenrestricted

clientIP: add trustedproxy, return first untrusted IP instead of the last one

This fixes #2828, where malicious clients passed in customized HTTP header to keep its IP address off records.

This is

clientIP: add trustedproxy, return first untrusted IP instead of the last one

This fixes #2828, where malicious clients passed in customized HTTP header to keep its IP address off records.

This is inspired by Sympony's Request::setTrustedProxies, but I don't want to implement everything including IP CIDR matching (IPv4 + IPv6), so I decided to reuse the local IP checker in place powered by regexp. Now admins can customize this "local" (trusted) proxy list using $conf['trustedproxy'], and by default it will allow any local IPs.

If in the future there is a need to implement array-based CIDR matching, $conf['trustedproxies'] can be used for the new config name.

show more ...

getGoogleQuery: remove legacy code for PHP 5.3

https://bugs.php.net/bug.php?id=49733 while we have 5.6+ minimum

getGoogleQuery: ignore if query includes a full URL

We don't want to split the URL to highlight the "query", especially when q is the URL of the page itself - e.g. Google Form's redirect https://www

getGoogleQuery: ignore if query includes a full URL

We don't want to split the URL to highlight the "query", especially when q is the URL of the page itself - e.g. Google Form's redirect https://www.google.com/url

This will also ignore queries like `syntax site:https://www.dokuwiki.org` but it should be fine. Just don't want to use a full parser here.

This fixes #2848.

show more ...

Include rev_id in new revision link in notification email

Older versions have a "This is an old revision of the document!" message on the top of the page. By including rev_id, user can always see th

Include rev_id in new revision link in notification email

Older versions have a "This is an old revision of the document!" message on the top of the page. By including rev_id, user can always see the version the email is referring to, while knowing if it is the latest version by looking at the wiki page.

A hint about this is also added to email text.

This fixes #2196.

show more ...

Merge branch 'master' into psr2

changes from commit b15f23f6735eabb6dc7e4a996e4ae164139ab7f5 may have
been lost, because the code changed to much.

changes from commit df81ca99eeaf4753d6f09cbddbb529

Merge branch 'master' into psr2

changes from commit b15f23f6735eabb6dc7e4a996e4ae164139ab7f5 may have
been lost, because the code changed to much.

changes from commit df81ca99eeaf4753d6f09cbddbb529afe7ef71c7 need to be
verified. we might need to do some more adjustments.

* master: (49 commits)
translation update
translation update
translation update
translation update
translation update
translation update
translation update
Update config.class.php
translation update
translation update
Update lang.php
Add ugc hint to nofollow
add UGC hint
translation update
translation update
use a script to fetch the correct phpunit
Revert "output travis php version for easier debugging"
setup databases for unit tests in travis
output travis php version for easier debugging
translation update
...

show more ...

Merge pull request #2671 from splitbrain/issue2665

obfuscate: use utf8_tohtml for hex mode encoding

fixed some line length errors

Merge branch 'utf8refactor' into psr2

* utf8refactor:
replaced deprecated utf8 functions
formatting cleanup
mark old utf8 functions deprecated
Some cleanup for the UTF-8 stuff
Moved all ut

Merge branch 'utf8refactor' into psr2

* utf8refactor:
replaced deprecated utf8 functions
formatting cleanup
mark old utf8 functions deprecated
Some cleanup for the UTF-8 stuff
Moved all utf8 methods to their own namespaced classes
Create separate table files for UTF-8 handling

show more ...

fix PSR2 error in switch statement

Merge branch 'master' into psr2

* master: (34 commits)
fix color for noninstalled extensions
show disabled extensions in gray
warn about inaccessible repo api
bugfix: access check was never

Merge branch 'master' into psr2

* master: (34 commits)
fix color for noninstalled extensions
show disabled extensions in gray
warn about inaccessible repo api
bugfix: access check was never cached
First go on a CLI component for the extension manager
use strict type comparison
translation update
translation update
fix #dokuwiki__sitetools current item not in highlight due to Greebo change
authplain: Add tests for group retrieval
authplain: Add a simple method for retrieving user groups
translation update
Negative string offsets are allowed in PHP 7.1+ only
improve memory check output
fix and test php_to_byte() related to #2756 #2556
translation update
translation update
translation update
translation update
translation update
...

show more ...

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

Merge branch 'psr2-pluginredux' into psr2

* psr2-pluginredux:
Minor optimizations in PluginController
Snake to Camel case fixes inn PluginController
Fix snake->camel case, doc blocks
minor c

Merge branch 'psr2-pluginredux' into psr2

* psr2-pluginredux:
Minor optimizations in PluginController
Snake to Camel case fixes inn PluginController
Fix snake->camel case, doc blocks
minor code simplification
snake to camel case fixes in EventHandler
Move list of plugin types to plugin controller constant
Avoid accessing the evet system before it's intialized
Avoid processing events before the Event System is intiialized
isEnabled instead of isDisabled
removed get_directory() method from PluginController
fix type hints
moved plugin controller to Extension namespace
removed deleted file from autoloader
deprecated trigger_event() in favor of a static method on Event
First go at moving the plugin classes into their own namespace

show more ...

Merge pull request #2760 from splitbrain/phpsizeshorthand

better php size parsing