Fix various errors in PHPUnit tests on PHP 8

Remove ! operator causing unit tests to fail

Fix undefined array keys when displaying images

Fix Undefined array key "DOKU_PREFS" in common.php

Minor optimization of clientIP()

Remove unnecessary assignment, check the output of filter_var() directly.

Remove $match, as it's no longer used

Simplify clientIP() function

Replace regexps with FILTER_VALIDATE_IP

Remove clientIP() verification from page locking

For editing without a user account, session_id() verification is
more appropriate.

This will make page locking work for people editing the wiki from

Remove clientIP() verification from page locking

For editing without a user account, session_id() verification is
more appropriate.

This will make page locking work for people editing the wiki from
the same IP (which can happen in an office space, for example).

As discussed in https://forum.dokuwiki.org/d/18284-dont-store-ip-addresses/5

show more ...

change Index objects to non-singleton

Indexer, FulltextIndex, MetadataIndex uses common directory to store *.idx files, but this does not mean they should be singleton objects to avoid lock confrict

change Index objects to non-singleton

Indexer, FulltextIndex, MetadataIndex uses common directory to store *.idx files, but this does not mean they should be singleton objects to avoid lock confrictions.

show more ...

Merge branch 'master' into Refactor_Fulltext

Move defines to their own file

As described in
https://github.com/dwp-forge/columns/issues/5#issuecomment-638467603
sometime the Lexer constants have not been (auto)loaded when a syntax plugin
is in

Move defines to their own file

As described in
https://github.com/dwp-forge/columns/issues/5#issuecomment-638467603
sometime the Lexer constants have not been (auto)loaded when a syntax plugin
is invoked (I'm not sure why).

In general PSR2 discourages a mix of main code and function/class setup
with the call to define() being considered main code.

This patch moves these the define calls to a separate new file, solving
both of the above problems.

These are not all our defines. Instead I focused on the ones that are
ENUM-like.

In the future we should think about what defines can be replaced by
class constants and what other define() calls should be moved.

show more ...

Merge branch 'master' into Refactor_Fulltext

Merge branch 'nomailerrors'

* nomailerrors:
replaced deprecated function call
suppress errors messages in Mailer for non-admins #3014
more tests and a fix for #3036
added failing test for #3

Merge branch 'nomailerrors'

* nomailerrors:
replaced deprecated function call
suppress errors messages in Mailer for non-admins #3014
more tests and a fix for #3036
added failing test for #3036

show more ...

remove calls to deprecated methods and classes

Merge pull request #3007 from splitbrain/only-new

implemented only_new option for RSS feed

replaced deprecated function call

check if user is empty in userSubscription, fixes #2003

This makes sure SubscriberRegexBuilder is used properly and won't throw exception in userSubscription.

Renamed constant to RECENTS_ONLY_CREATION

This clarifies that it also works when requesting media changelog.

Implemented only_new option for RSS feed, so you can request RSS feed that contains only new files.

move backlinks() and mediause() into MediaIndex class

Merge remote-tracking branch 'upstream/master' into Refactor_Fulltext

♻️ Rename flag to better show actual effect

This flag only causes parameters with empty strings to be skipped,
not all empty() values.

Merge branch 'master' into Refactor_Fulltext

rewrite deprecated ft_* functions

PHP8 fix part 5: Trying to access array offset on value of type bool/null