Update core code to make use of sexplode()

This makes use of our own explode mechanism everywhere were we expect a
fixed number of results.

Fix clientIP() returning the wrong address

introduce sexplode() as a PHP8 safe explode()

We often have constructs like

list($foo, $bar) = explode(',', $input, 2);

In PHP8+ this will throw warnings when the explode returns fewer than 2
elem

introduce sexplode() as a PHP8 safe explode()

We often have constructs like

list($foo, $bar) = explode(',', $input, 2);

In PHP8+ this will throw warnings when the explode returns fewer than 2
elements. Our code usually (always?) will anticipate missing elements so
the construct isn't really problematic.

The implementation here wraps the solution suggested at
https://stackoverflow.com/a/56971347 into a new utility function.

I anticipate that people might object to the function name. It was
chosen as a short form of "safe explode". This makes fixing the warning
easy by simply adding a single letter. I also find it slightly amusing
and would be open to change it to just sex() just for the fun of it.

show more ...

Replace direct calls to strftime with dformat calls

This is in preparation for fixing #3573

Merge pull request #3574 from splitbrain/php81

Some PHP 8.1 compatibility fixes

import classes, replace dbglog, simplify, remove unused statements, and other warnings from IntelliJ

update phpdocs,
rename dokuwiki/Ui/Draft to PageDraft

guard against unset parameters

Many string function will throw a deprecation warning in PHP 8.1 when
null is passed. This adds a few guards in some of our methods (not all,
yet)

always use the same htmlspecialchars setup

defaults for htmlspecialchars change in PHP 8.1

All calls should always use our hsc() method to ensure comparability
(especially when testing)

Merge branch 'master' into revisionHandle3

guard against unsert user name. fixes #3455

Merge pull request #3270 from adakaleh/simplify_clientIP

Simplify clientIP() function

Merge pull request #3269 from adakaleh/clientIP_page_locking

Remove clientIP() verification from page locking

Merge remote-tracking branch 'upstream/master' into Refactor_Fulltext

add dbg_deprecated()

PHP8: check array key existence

implement PageFile class

PageFile class handles wiki text file and its change management for specific page, main part comes from `function saveWikiText()`. This ensures and enables to use one **Pag

implement PageFile class

PageFile class handles wiki text file and its change management for specific page, main part comes from `function saveWikiText()`. This ensures and enables to use one **PageChangeLog** instance during a page save process among class methods and relevant plugins.

show more ...

remove goto-loop structure

plugin event handler should set correct changeType.

set current revision date 1sec before now for external deletion

in preparation for possible new page save

update saveWikiText()

allow plugin that provides alternative policy for handling external edits in changelog

rigorous COMMON_WIKIPAGE_SAVE

ignore wrong changes in id and file data caused by event handlers

new method ChangeLog::addLogEntry()

rewrite `detectExternalEdit()` in inc/common.php

set revInfo{'current'] when needed

do not set 'current' key in ChangeLog:getCurrentRevisionInfo(), instead set it during loop in Revision and Diff classes

UnitTest of pageinfo(), saveWikiText()

ChangeLog creates early .change file, p_get_metadata() will get full "meta_last_change" entry. The current key in the revinfo need to be excluded prior to p_s

UnitTest of pageinfo(), saveWikiText()

ChangeLog creates early .change file, p_get_metadata() will get full "meta_last_change" entry. The current key in the revinfo need to be excluded prior to p_set_metadata() call.

show more ...

coding style of functions using ChangeLog

external edits in changelog for images