add dbg_deprecated()

PHP8: check array key existence

implement PageFile class

PageFile class handles wiki text file and its change management for specific page, main part comes from `function saveWikiText()`. This ensures and enables to use one **Pag

implement PageFile class

PageFile class handles wiki text file and its change management for specific page, main part comes from `function saveWikiText()`. This ensures and enables to use one **PageChangeLog** instance during a page save process among class methods and relevant plugins.

show more ...

remove goto-loop structure

plugin event handler should set correct changeType.

set current revision date 1sec before now for external deletion

in preparation for possible new page save

update saveWikiText()

allow plugin that provides alternative policy for handling external edits in changelog

rigorous COMMON_WIKIPAGE_SAVE

ignore wrong changes in id and file data caused by event handlers

new method ChangeLog::addLogEntry()

rewrite `detectExternalEdit()` in inc/common.php

set revInfo{'current'] when needed

do not set 'current' key in ChangeLog:getCurrentRevisionInfo(), instead set it during loop in Revision and Diff classes

UnitTest of pageinfo(), saveWikiText()

ChangeLog creates early .change file, p_get_metadata() will get full "meta_last_change" entry. The current key in the revinfo need to be excluded prior to p_s

UnitTest of pageinfo(), saveWikiText()

ChangeLog creates early .change file, p_get_metadata() will get full "meta_last_change" entry. The current key in the revinfo need to be excluded prior to p_set_metadata() call.

show more ...

coding style of functions using ChangeLog

external edits in changelog for images

Fix various errors in PHPUnit tests on PHP 8

Remove ! operator causing unit tests to fail

Fix undefined array keys when displaying images

Fix Undefined array key "DOKU_PREFS" in common.php

Minor optimization of clientIP()

Remove unnecessary assignment, check the output of filter_var() directly.

Remove $match, as it's no longer used

Simplify clientIP() function

Replace regexps with FILTER_VALIDATE_IP

Remove clientIP() verification from page locking

For editing without a user account, session_id() verification is
more appropriate.

This will make page locking work for people editing the wiki from

Remove clientIP() verification from page locking

For editing without a user account, session_id() verification is
more appropriate.

This will make page locking work for people editing the wiki from
the same IP (which can happen in an office space, for example).

As discussed in https://forum.dokuwiki.org/d/18284-dont-store-ip-addresses/5

show more ...

Move defines to their own file

As described in
https://github.com/dwp-forge/columns/issues/5#issuecomment-638467603
sometime the Lexer constants have not been (auto)loaded when a syntax plugin
is in

Move defines to their own file

As described in
https://github.com/dwp-forge/columns/issues/5#issuecomment-638467603
sometime the Lexer constants have not been (auto)loaded when a syntax plugin
is invoked (I'm not sure why).

In general PSR2 discourages a mix of main code and function/class setup
with the call to define() being considered main code.

This patch moves these the define calls to a separate new file, solving
both of the above problems.

These are not all our defines. Instead I focused on the ones that are
ENUM-like.

In the future we should think about what defines can be replaced by
class constants and what other define() calls should be moved.

show more ...

Merge branch 'nomailerrors'

* nomailerrors:
replaced deprecated function call
suppress errors messages in Mailer for non-admins #3014
more tests and a fix for #3036
added failing test for #3

Merge branch 'nomailerrors'

* nomailerrors:
replaced deprecated function call
suppress errors messages in Mailer for non-admins #3014
more tests and a fix for #3036
added failing test for #3036

show more ...

remove calls to deprecated methods and classes

Merge pull request #3007 from splitbrain/only-new

implemented only_new option for RSS feed

replaced deprecated function call