remove fullpath() call

fullpath processing here seems unnecessary, wikiFN($ID) returns a valid filepath for the page text file.

wrong entry of revinfo used in detectExternalEdit

rename variables in detectExternalEdit

filesize zero cases, compressed revisions

- handle all cases where not an old file exist, or when that old file is
zero size.
- When using old revision normally these files are compressed, use
uncom

filesize zero cases, compressed revisions

- handle all cases where not an old file exist, or when that old file is
zero size.
- When using old revision normally these files are compressed, use
uncompressed size.

show more ...

little reformat of saveWikiText

Merge remote-tracking branch 'origin/master' into revsizechange

Conflicts:
inc/common.php

Merge pull request #1472 from splitbrain/wikisave_event

refactor page saving and introduce COMMON_WIKIPAGE_SAVE

removed isset() from blank() function

As discussed in #1471, an uninitialized variable will always be
implicitly created when passed to the blank() function. Calling isset()
is thus a no-op. A warni

removed isset() from blank() function

As discussed in #1471, an uninitialized variable will always be
implicitly created when passed to the blank() function. Calling isset()
is thus a no-op. A warning about this behavior has been added to the
function comment.

show more ...

refactor page saving and introduce COMMON_WIKIPAGE_SAVE

This makes the saveWikiText() function a little easier to read and moves
external edit handling to its own function. Behavior stays the same
(

refactor page saving and introduce COMMON_WIKIPAGE_SAVE

This makes the saveWikiText() function a little easier to read and moves
external edit handling to its own function. Behavior stays the same
(tests are unchanged).

In addition a new event COMMON_WIKIPAGE_SAVE is introduced that makes
intercepting and acting on page saves much easier than possible before.

Developers can:

* prevent saves by either preventing the default action or overwriting
the contentChanged field in a BEFORE hook
* enforce saves even when no content changed by overwriting the
contentChanged field in a BEFORE hook
* Adjust the saved content by modifying the newContent field in a BEFORE
hook
* Adjust the stored change log information (summary, type, extras) in an
AFTER hook
* Easily know if a page was deleted, created or edited by inspecting the
changeType field
* what ever they want before or after a wiki page is saved

show more ...

add convenience function for empty check without 0

This allows to quickly check if a variable is empty but keeps strings
and numbers evaluating to zero.

Fixed several undefined errors.

Store change of filesizes in revision log

Implements
https://bugs.dokuwiki.org/index.php?do=details&task_id=2525

make it possible to remove entries from DOKU_PREFS cookie

Remove IE6 workaround for redirects with hashes

We no longer support IE6, so hashes in URLs no longer need to be
protected when redirecting.

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PH

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PHP 5.3 now, there's no need to supress any error here
anymore. This might even give a minor performance boost.

show more ...

never exit during test runs

Merge remote-tracking branch 'origin/master' into scrutinizerissues

Conflicts:
inc/media.php
inc/plugin.php
inc/template.php
lib/plugins/authplain/_test/escaping.test.php
lib/plugins/syntax.php

PHPDocs and some improvements

more phpdocs and minor check

Many PHPDocs, some unused and dyn declared vars

many PHPDocs
some unused variables
some dynamically declared variables declared

more scrutinizer issue improvements

scrutinizer documentations issues

Merge remote-tracking branch master into revisions

Merge remote-tracking branch 'origin/auth_getUserData_improvements'

* origin/auth_getUserData_improvements:
KISS - remove class constants for REQUIRE_GROUPS & IGNORE_GROUPS and replace with boolea

Merge remote-tracking branch 'origin/auth_getUserData_improvements'

* origin/auth_getUserData_improvements:
KISS - remove class constants for REQUIRE_GROUPS & IGNORE_GROUPS and replace with boolean values
use $requireGroups constants in auth classes; comments; code improvements
fix comment errors, sp. & grammar
code styling - add missing braces
Allow user info to be retrieved without groups
Restore correct public interface of getUserData() for authldap plugin

Conflicts:
inc/common.php

show more ...

fix userlink title when no authplugin is available or no user is found