Negative string offsets are allowed in PHP 7.1+ only

fix and test php_to_byte() related to #2756 #2556

This refactors the php_to_byte() method to properly return integers
always. A bug when reading byte sizes under 10 bytes was fixed. Infinity
(signal

fix and test php_to_byte() related to #2756 #2556

This refactors the php_to_byte() method to properly return integers
always. A bug when reading byte sizes under 10 bytes was fixed. Infinity
(signaled by a -1 in php.ini) is now returned as -1.

According to [1] PHP supports size shortcuts for (K)ilobytes,
(M)egabytes and (G)igagbytes only. The support for Tera- and Petabytes
has been removed.

[1] https://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes

show more ...

♻️ Split up ChangesSubscriptionSender into multiple classes

This should better adhere to SRP and simplify things.

♻️ Don't use deprecated subscription methods

deprecated trigger_event() in favor of a static method on Event

First go at moving the plugin classes into their own namespace

Allow @CURNS@ to be capitalised in namespace templates

Personally I have some pages where I use
@CURNS@ - @PAGE@ or @CURNS@ @PAGE@ as the title
so this change saves me a bit of manual
capitalisation

avoide codesniff warnings on deliberate switch fallthrough

codesniffer and Idea unfortunately can't agree on the comment format to
mark a deliberate fallthrough in a switch statement. so we have to

avoide codesniff warnings on deliberate switch fallthrough

codesniffer and Idea unfortunately can't agree on the comment format to
mark a deliberate fallthrough in a switch statement. so we have to use
both :-/

show more ...

Merge branch 'master' into psr2

* master: (22 commits)
Support "local" subdir when listing the smiley directory
fix zero ID/NS issue with page_findnearest
add ID/NS = '0' test against page_fin

Merge branch 'master' into psr2

* master: (22 commits)
Support "local" subdir when listing the smiley directory
fix zero ID/NS issue with page_findnearest
add ID/NS = '0' test against page_findnearest
fix zero value issue with metadata indexer
add key/value = '0' test to metadata indexer
fix zero ID issue with linkwiz and search indexer
fix zero ID issue with wl() and getID()
add $ID = '0' test against wl() and getID()
cookie.js when setValue‘s value parameter is false delete entry
install.php: respect useacl=0 choice, fixes #2576
cookie.js add def parameter to getValue()
cookie.js convert value type to string
set_doku_pref bugfix, closes #2721
more definition tests of doku_pref, for #1129
add tests for get/set_doku_pref #2721
fix Windows tests for #2702
use absolute URL in index.php when redirecting to doku.php, fixes #2706
Adding "recursive_groups" setting for authad-plugin in configuration-manager
Fix notices when using dw CLI
Fix issue #2396
...

show more ...

Merge pull request #2722 from splitbrain/issue2721

tests and fixes for set_doku_pref issues

fix zero ID issue with wl() and getID()

set_doku_pref bugfix, closes #2721

- Read last entries (if duplicate) when get
- Remove duplicate entries when set
- Type-aware compare to decide append or modify
- Remove $cookieVal empty check bef

set_doku_pref bugfix, closes #2721

- Read last entries (if duplicate) when get
- Remove duplicate entries when set
- Type-aware compare to decide append or modify
- Remove $cookieVal empty check before setcookie, because there might be cases when we want to remove cookie

show more ...

add tests for get/set_doku_pref #2721

PSR2 adjustments for the PassHash class

I opted for ignoring the camel case funtion check not because the public hash_*
methods are widely used but because I find this style actually cleaner
in this

PSR2 adjustments for the PassHash class

I opted for ignoring the camel case funtion check not because the public hash_*
methods are widely used but because I find this style actually cleaner
in this case where the method name is auto-built from the hash type
name.

show more ...

Refactor cache.php into different files

obfuscate: use utf8_tohtml for hex mode encoding, fixes #2665

Note that its output for "regular" char (codepoint < 2bytes) has also changed (before hex, now decimal), due to the current behavior of

obfuscate: use utf8_tohtml for hex mode encoding, fixes #2665

Note that its output for "regular" char (codepoint < 2bytes) has also changed (before hex, now decimal), due to the current behavior of utf8_tohtml. In this case, the config value "hex" doesn't mean "hex" anymore, but it still obfuscates characters as numbers, as expected. This might need doc update.

show more ...

Merge branch 'master' into psr2

* master:
upgraded JSON class to latest (2006) version
continue is break in switch
translation update
reference existing proper progress gif. fixes #2441
Fi

Merge branch 'master' into psr2

* master:
upgraded JSON class to latest (2006) version
continue is break in switch
translation update
reference existing proper progress gif. fixes #2441
Fix missing ui-bg_glass_95_fef1ec_1x400.png and be/jquery.ui.datepicker.js for jquery
removed accidental merges of outdated translations
Change `const` use to `var` for Safari 9 (on iOS)
Fix .htaccess files for Apache 2.4 (and 2.2)
add logic if the server uses unlimited memory settings in is_mem_available()
removed safemode hack

show more ...

Merge pull request #2420 from sijongyeoil/patch-1

add logic if the server uses unlimited memory settings in is_mem_available()

split changelog classes into their own namespace

The remaining functions in inc/changelog.php should be moved into a
utility class.

Merge branch 'master' into psr2

* master:
�� (Draft) Fix exception when actually viewing a draft of a page
��(Draft): Add doc block for constructor
✅ Add unittest for deleteUsers remote API ca

Merge branch 'master' into psr2

* master:
�� (Draft) Fix exception when actually viewing a draft of a page
��(Draft): Add doc block for constructor
✅ Add unittest for deleteUsers remote API call
fix remote API call dokuwiki.deleteUsers
translation update
�� Use json for the response to dw_locktimer
✨(dw_locktimer) plugins may reuse to add fields and callbacks
�� (editor) draft status is semantically not part of the toolbar
�� Create new Draft class and move draft handling there
translation update
correctly avoid notice in init.
avoid creating expensive stacktrace in dbg_deprecated()
add method to EventHandler to check if an event is actually handled
introduce INFO_DEPRECATION_LOG event

show more ...

add logic if the server uses unlimited memory settings in is_mem_available()

If memory is set to unlimited, then memory_limit will be -1, so set this to true in this case.

�� Create new Draft class and move draft handling there

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

remove DOKU_INC checks

There is no need for this check, since these files should not have any
main code that is executed on direct call.

Fixes PSR1.Files.SideEffects.FoundWithSymbols

refactor: rename and move function to set $JSINFO

This is a more consistent place relative to pageinfo()