SECURITY: fix XSS vulnerability. fixes #4512

The namespace selector in the advanced search tools did not correctly
escape the user provided namespace.

This issue was reported by Mario Tesoro.

code style: line breaks

Apply rector fixes to inc/Ui

import classes, replace dbglog, simplify, remove unused statements, and other warnings from IntelliJ

update phpdocs,
rename dokuwiki/Ui/Draft to PageDraft

Merge branch 'master' into form

change event naming scheme

FORM_*_OUTPUT scheme had been introduced since Apriil 2018, see #2286

wrap sorting functions into their own class

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to in

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to intl_ksort()
- new function intl_asort()
- sort_filenames() renamed to intl_asortFN()
Updated documentation.

show more ...

Reimplementation of ksort()

Reimplementation of ksort() using collator.
Fix of getAdditionalNamespacesFromResults() function in "Ui/Search.php".

Screens fixed:
- Search (namespace selector below se

Reimplementation of ksort()

Reimplementation of ksort() using collator.
Fix of getAdditionalNamespacesFromResults() function in "Ui/Search.php".

Screens fixed:
- Search (namespace selector below search field)

show more ...

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

deprecated trigger_event() in favor of a static method on Event

Merge branch 'master' into psr2

* master:
translation update
translation update
Use config cascade for style.ini files
translation update
translation update
use utf8_strtolower instead o

Merge branch 'master' into psr2

* master:
translation update
translation update
Use config cascade for style.ini files
translation update
translation update
use utf8_strtolower instead of strtolower
add test for utf8 capital letters in search #2613
compare cleaned pageid case-insensitive in search, fixes #2613
add tests for #2613
Defective transplantation of export from .htaccess

show more ...

use utf8_strtolower instead of strtolower

compare cleaned pageid case-insensitive in search, fixes #2613

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

feat: improve search as a primary means to create new pages

Specifically, this pull request checks if the current query is already a
valid pageid and then return that as suggested pageid.

Also, tes

feat: improve search as a primary means to create new pages

Specifically, this pull request checks if the current query is already a
valid pageid and then return that as suggested pageid.

Also, tests are added for this method.

Fixes #2355

PS: We may want to somehow better educate/nudge users to use the better
way of creating pages by creating links on existing pages.

show more ...

fix(search): don't start result position with 2

Also, for consistency this initializes also $num with 0, while ensuring
that the first FT_SNIPPET_NUMBER results with a $cnt>0 have a snippet.

refactor(search): clearer data flow

Change spacing in search meta data to punctuation

Punctuation is more natural, makes sense with CSS switched off
and makes screenreaders add a little pause.

Fix(search): restore valid heading hierarchy

In #2286 the 2nd level heading in the intro was removed, so the h3
should be promoted to h2.

fix(search): add position to fulltext results event

fix(search): ensure consistent html in search results

This implements some of the changes discussed in #2314:

1. last mod and number of hits are on the same line and always shown
2. There is a clas

fix(search): ensure consistent html in search results

This implements some of the changes discussed in #2314:

1. last mod and number of hits are on the same line and always shown
2. There is a class around the last mod string so it can be
hidden/replaced by an icon
3. All items in the resultBody returned by the event are wrapped in
`<dd>` tags to ensure validity. They get their array key as class
4. There is still a wrapper div around each result for styling purposes

show more ...

Fix invalid HTML in search results

Recent changes to the search results page added various divs
to the pre-existing description list, which is invalid.
This fixes that by a) removing a couple of unn

Fix invalid HTML in search results

Recent changes to the search results page added various divs
to the pre-existing description list, which is invalid.
This fixes that by a) removing a couple of unnecessary elements
and b) interpret the 'last modified' line as another 'dd'.

show more ...

fix: bring back the namespace in brace for pagelookup results

This was unintentionally removed in
4eab6f7c40ab5e2fbbb5e0efb20d930d4b1730fe

It also should now be clearer what the code does.

This fi

fix: bring back the namespace in brace for pagelookup results

This was unintentionally removed in
4eab6f7c40ab5e2fbbb5e0efb20d930d4b1730fe

It also should now be clearer what the code does.

This fixes #2305

show more ...

refactor: rename dta and dtb parameters

They are now named min and max respectively, which is hopefully less
cryptic.