| #
dd9e8e5e |
| 23-Apr-2026 |
Andreas Gohr <andi@splitbrain.org> |
fix EXIF-rotated images shown cropped in previews, closes #4482
JPEGs with EXIF orientation 5/6/7/8 were rendered cropped in the mediamanager detail view, the image diff view and the fullscreen deta
fix EXIF-rotated images shown cropped in previews, closes #4482
JPEGs with EXIF orientation 5/6/7/8 were rendered cropped in the mediamanager detail view, the image diff view and the fullscreen detail page: getimagesize() / JpegMeta report raw (rotation-unaware) pixel dimensions, and passing both w and h to fetch.php defaults to center-crop.
- Bump splitbrain/slika to 1.1, which ships ImageInfo: a rotation- aware, metadata-only dimension simulator mirroring Adapter's fluent API (autorotate/resize/crop). - Add fit=1 to fetch.php: when both w and h are given, route to media_resize_image() (bbox fit) instead of media_crop_image(). Token hashes only (id, w, h) so existing tokens stay valid. - Add MediaFile::getDisplayDimensions($w, $h, $crop) which delegates to ImageInfo and returns the dims fetch.php would produce. - Add Display::getDetailHtml() and retire media_preview() / the old media_image_preview_size() helper. media_tab_view and MediaDiff now share the Display-based renderer. - Rewrite tpl_img() (lib/tpl/*/detail.php) to use MediaFile dims + fit=1 URL; drops the manual ratio math. - Tests: MediaFileTest covers the dims math, DisplayTest covers the detail-view HTML (rotated dims, rev-vs-timestamp URL selection, structure), fetch_imagetoken gains a fit-token compat test. Fixture _test/data/media/wiki/exif-orient-6.jpg: 20x30 JPEG with EXIF orientation 6.
show more ...
|
| #
093fe67e |
| 07-Mar-2026 |
Andreas Gohr <andi@splitbrain.org> |
updated rector and applied it
|
| #
a835c93a |
| 24-Sep-2023 |
Gerrit Uitslag <klapinklapin@gmail.com> |
Let ChangeLog set the mode(media/page) for a revision log entry
|
| #
8c7c53b0 |
| 30-Aug-2023 |
Andreas Gohr <andi@splitbrain.org> |
codestyle adjustments: class declaration braces
|
| #
e2d055f5 |
| 29-Aug-2023 |
Andreas Gohr <andi@splitbrain.org> |
Apply rector fixes to inc/Ui
|
| #
921c2ae3 |
| 04-Aug-2022 |
TherealperO <110610509+TherealperO@users.noreply.github.com> |
Update MediaDiff.php
|
| #
c02dcaa0 |
| 28-Jan-2022 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
change var name $Rev to $RevInfo
|
| #
3712ae9e |
| 28-Jan-2022 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
change var name $rev1Supple to $rev1Summary
|
| #
eeda7ada |
| 23-Jan-2022 |
Gerrit Uitslag <klapinklapin@gmail.com> |
some spelling
|
| #
6714d8ce |
| 23-Jan-2022 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
use RevisionInfo class more in Diff
use RevisionInfo Rev1, Rev2 instead of array oldRevInfo, newRevInfo obsolete revisionTitle(), use RevisionInfo::showRevisionTitle() change variable names
|
| #
b428a50a |
| 23-Jan-2022 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
use OOP like method name in RevisionInfo class
|
| #
f2749649 |
| 23-Jan-2022 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
prevent warning undefined array key "highlighted"
|
| #
bf3fa5e9 |
| 08-Jan-2022 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
new RevisionInfo class obsoletes anonymous objRevInfo class
obsolete getObjRevInfo() in Ui\Recent and Ui\Revisions classes, that had defined anonymous class. they are similar but slightly differentl
new RevisionInfo class obsoletes anonymous objRevInfo class
obsolete getObjRevInfo() in Ui\Recent and Ui\Revisions classes, that had defined anonymous class. they are similar but slightly differently treat the diff link icon. It is impossible to create common method for diff icon using only revision information, it depends on caller, ie. recent or revisions list
show more ...
|
| #
79a2d784 |
| 05-Jan-2022 |
Gerrit Uitslag <klapinklapin@gmail.com> |
import classes, replace dbglog, simplify, remove unused statements, and other warnings from IntelliJ
update phpdocs, rename dokuwiki/Ui/Draft to PageDraft
|
| #
6527839f |
| 01-Nov-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
typo
|
| #
5cb97057 |
| 01-Nov-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
get revision pair in Diff:handle()
|
| #
5ec96136 |
| 01-Nov-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
set revInfo{'current'] when needed
do not set 'current' key in ChangeLog:getCurrentRevisionInfo(), instead set it during loop in Revision and Diff classes
|
| #
7df78a78 |
| 21-Oct-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
skip cached revInfo to keep "current" entry
to
|
| #
0ea1f71b |
| 15-Oct-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
Modernize Ui\Diff, PageDiff, MediaDiff
- define class property RevInfo pair - handle() html form data - preProcess() set RevInfo pair - show() generate html - set RevInfo in CompareWith() when confl
Modernize Ui\Diff, PageDiff, MediaDiff
- define class property RevInfo pair - handle() html form data - preProcess() set RevInfo pair - show() generate html - set RevInfo in CompareWith() when conflict and draft
show more ...
|
| #
64876922 |
| 11-Oct-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
obsolete Diff::getExtendedRevisionInfo()
|
| #
d1575179 |
| 11-Oct-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
use integer $rev in Revision and Diff forms
pass tentative revision instead of 'current' for external edition
|
| #
0a475154 |
| 10-Oct-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
@ssahara update Ui\Diff using ChangeLog\getCurrentRevisionInfo()
remove class property $item remove abstract function itemFN() ignore metadata when considering external edit
|
| #
629a763d |
| 09-May-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
remove MEDIA_DIFF event handling
MEDIA_DIFF event is not documented in devel:events_list and not used in any plugins.
|
| #
4557f463 |
| 04-Jan-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
allow to instantiate Ui\MediaDiff('')
|
| #
cf3c75d6 |
| 04-Jan-2021 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
bugfix in media Ui classes
|