�� Rector and PHPCS fixes

Merge pull request #4266 from dokuwiki/environment

Output more version data on the admin screen

allow admin components to skip being shown in the admin menu

This is related to #4249. At least the farmer plugin provides a top
level admin component and several sub components which are loaded fro

allow admin components to skip being shown in the admin menu

This is related to #4249. At least the farmer plugin provides a top
level admin component and several sub components which are loaded from
the top component. For this use case it makes sense to be able to hide
components from the admin interface. Default remains to show all.

show more ...

escape environment data in admin interface

Data might contain special chars.

Output more version data on the admin screen

Bug reports are often lacking crucial information about the environment
the wiki is run on and novice users often do not know how to obtain this
data.

T

Output more version data on the admin screen

Bug reports are often lacking crucial information about the environment
the wiki is run on and novice users often do not know how to obtain this
data.

This patch gathers some environmental information and outputs it next to
the DokuWiki version number on the admin screen.

Info included (if obtainable):

* PHP version
* Linux Distribution name and version
* Operating System and Version (refers to kernel version on linux)
* The PHP SAPI (modphp, cgi, fcgi)
* If running on kubernetes or docker

show more ...

Use str_starts_with/str_ends_with

code style: line breaks

Apply rector fixes to inc/Ui

import classes, replace dbglog, simplify, remove unused statements, and other warnings from IntelliJ

update phpdocs,
rename dokuwiki/Ui/Draft to PageDraft

cleaner behaviour for data directory check

Show a properly translated message.

do not repeat successful security checks. fixes #3363

This avoids creating lots of 403 errors for properly secured data
directories. Only one successful check per browser session will be
executed.

Merge branch 'logging'

* logging:
added JavaScript based filter mechanism
added logging configuration
replaced out calls to dbglog with new Logger calls
added convenience methods to log to o

Merge branch 'logging'

* logging:
added JavaScript based filter mechanism
added logging configuration
replaced out calls to dbglog with new Logger calls
added convenience methods to log to our default facilities
added logviwer admin plugin
added log dir to git
central logging mechanism

show more ...

added logviwer admin plugin

This allows for easy viewing of the available logs.

The log format was sligthly adjusted again for easier parsing.

wrap sorting functions into their own class

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to in

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to intl_ksort()
- new function intl_asort()
- sort_filenames() renamed to intl_asortFN()
Updated documentation.

show more ...

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is us

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is used by ft_pageLookup().

Functions that call ft_pageLookup() and now have the expected results:
Action\Search.php:69, execute(): run the search
Ajax.php:50, callQsearch(): Searches for matching pagenames
Ajax.php:352, callLinkwiz(): List matching namespaces and pages for the link wizard

Screens fixed:
- Search (list of matching pagenames)
- Quick search (when typing)
- Internal link suggestion when editing a page (when nothing was typed)

Fix of menuSort() function in "Ui/Admin.php".

Screens fixed:
- Administration

Fix of sort_search_fulltext() function in "search.php".
This function does not seem to be used anywhere.

show more ...

Reimplementation of strcasecmp()

Reimplementation of strcasecmp() using collator.
It uses the same implementation already made for strcmp().
Fix of menuSort() function in "Ui/Admin.php".

Screens fi

Reimplementation of strcasecmp()

Reimplementation of strcasecmp() using collator.
It uses the same implementation already made for strcmp().
Fix of menuSort() function in "Ui/Admin.php".

Screens fixed:
- Administration

show more ...

First go at moving the plugin classes into their own namespace

PSR2 style fixes

These are some simple whitespace/arrangement things that apparantly
can't be fixed automatically

Merge branch 'master' into psr2

add event to check access to admin plugins

This adds a new method that capsulates the access check that has to be
done to decide if an admin plugin's page should be shown to the user.
The default im

add event to check access to admin plugins

This adds a new method that capsulates the access check that has to be
done to decide if an admin plugin's page should be shown to the user.
The default implementation is the same as before, relying only on the
forAdminOnly() method and the users' isadmin or ismanager status.

Admin plugins themselves can override the method to do additional
checks. In this patch, I added that to the usermanager plugin which will
only return true if the current auth backend can list users.

However the real idea behind this change is that the new method emits a
new event called ADMINPLUGIN_ACCESS_CHECK which would allow plugins to
overwrite it. This way it could be possible to give certain user groups
access to certain admin plugins without giving them admin or manager
permissions.

Note: this does not change how the "Admin" link is shown, it still
depends on ismanager or isadmin. A plugin as mentioned above would need
to influence the display via the MENU_ITEMS_ASSEMBLY event.

Note: this only covers the basic access check. Admin plugins may need
further adjustments for access to other parts of the plugin (like AJAX
components). An additional commit will update this for the bundled
plugins.

show more ...

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

Make security.png more descriptive

Access attempts to security.png are normally denied, so the name of the file will be more self-descriptive

fixed typo in function name

changed embedSVG to inlineSVG and make it return contents

This makes it more flexible to use on the expense of needing one echo
more.