fix overeager optimization in Table handler. fixes #4186

This reverts an optimization introduced in
bcaec9f47d06126b3e653fea89a86d8b6a6cbef8

The number of elements in $this->tableCalls may change d

fix overeager optimization in Table handler. fixes #4186

This reverts an optimization introduced in
bcaec9f47d06126b3e653fea89a86d8b6a6cbef8

The number of elements in $this->tableCalls may change during the loop,
so they need to be recounted on every step. To protect it from being
"optimized" again, the loop was changed into a while loop.

Ultimately it should be checked if this method could be optimized in
another way.

show more ...

Use str_starts_with/str_ends_with

code style: line breaks

code style: operator spacing

coding style: control flow line breaks

codestyle adjustments: function declaration braces/spaces

codestyle adjustments: class declaration braces

apply PSR-12 constant visibility rule

PSR-12 says constants need their visibility declared from PHP 7.1
onwards

Apply rector fixes to inc/Parsing

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had legitimate use of these options.

If someone needs the functionality, it can easily be added back using a
plugin. But I prefer to give users one less option to shoot themselves
in the foot.

Removal of the translations for the config strings can follow after this
has been merged.

show more ...

fix phpdoc

Co-authored-by: Matthias Gutjahr <mattsches@gmail.com>

Fix accessing calls

Some plugins need access to the handler (and rewriter) calls. One
example is the do plugin.

This adds some accessing methods to the callWriter objects, ensures
$calls can be acc

Fix accessing calls

Some plugins need access to the handler (and rewriter) calls. One
example is the do plugin.

This adds some accessing methods to the callWriter objects, ensures
$calls can be accessed and removes some duplicate code by introducing an
abstract base class.

show more ...