Skip JPEG markers too short to hold the probed signature

_parseMarkerXmp() and the other signature-probing loops read a
fixed-length signature from every marker of a given type to identify it.
Since

Skip JPEG markers too short to hold the probed signature

_parseMarkerXmp() and the other signature-probing loops read a
fixed-length signature from every marker of a given type to identify it.
Since _getFixedString() throws on a short read, a valid but short APP1
segment (e.g. a 22-byte non-XMP APP1) made the XMP probe throw while
reading 29 bytes. That was logged as a damaged image and aborted the
marker loop, discarding any real XMP/EXIF segment that followed.

The issue was introduced in c9c56f8a0.

This is another symptom fix until the library is replaced as discussed
in #1970

Skip markers too short to contain the signature so probing continues
instead of failing. Fixes #4526.

show more ...

Handle array EXIF date values

This is a fix for a warning thrown by the EXIF library. It fixes a
specific symptom without addressing the actual issue of the library
being outdated and in need of rep

Handle array EXIF date values

This is a fix for a warning thrown by the EXIF library. It fixes a
specific symptom without addressing the actual issue of the library
being outdated and in need of replacement (as discussed in #1970)

fixes #4628

Co-authored by Zheyon <110686204+Zhey-on@users.noreply.github.com>

show more ...

Use str_starts_with/str_ends_with

JPEGMeta: clean up exception handling

use ErrorHandler::logException() to automatically log a stack trace

Fix: Rework error handling in JpegMeta marker reading

Fix: Padding in _getFixedString, log the path of damaged images

Fix: PHP8-related JpegMeta.php fixes

Change date fields to correct ones

Fix warning when displaying PDF in Media manager

Trying to access array offset on value of type bool in
.../inc/JpegMeta.php on line 1322

Fix curly brace syntax. PHP 7.3 deprecations in inc/ directory.

Merge branch 'master' into psr2

changes from commit b15f23f6735eabb6dc7e4a996e4ae164139ab7f5 may have
been lost, because the code changed to much.

changes from commit df81ca99eeaf4753d6f09cbddbb529

Merge branch 'master' into psr2

changes from commit b15f23f6735eabb6dc7e4a996e4ae164139ab7f5 may have
been lost, because the code changed to much.

changes from commit df81ca99eeaf4753d6f09cbddbb529afe7ef71c7 need to be
verified. we might need to do some more adjustments.

* master: (49 commits)
translation update
translation update
translation update
translation update
translation update
translation update
translation update
Update config.class.php
translation update
translation update
Update lang.php
Add ugc hint to nofollow
add UGC hint
translation update
translation update
use a script to fetch the correct phpunit
Revert "output travis php version for easier debugging"
setup databases for unit tests in travis
output travis php version for easier debugging
translation update
...

show more ...

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

Fix/Harmonize inconsistent Tag names that lead to reporting wrong dates.

remove deprecated each calls in libraries

replaced some more each calls

There are still some left in the DifferenceEngine code

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

Fixed broken links to php.net and redirecting pages to php.net

more class constructors to __construct()

Scrutinizer Auto-Fixes

This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PH

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PHP 5.3 now, there's no need to supress any error here
anymore. This might even give a minor performance boost.

show more ...

Many PHPDocs, some unused and dyn declared vars

many PHPDocs
some unused variables
some dynamically declared variables declared

more scrutinizer issue improvements

fix return by reference not a var

Merge pull request #381 from splitbrain/jpegmetafixes

Jpegmeta fixes

fix some Only vars assigned by reference