Merge branch 'client_ip_header'

* client_ip_header:
Clean up stale realip references after client_ip_header rename
remove realip option, add default in conf/dokuwiki.php
convert tests to data

Merge branch 'client_ip_header'

* client_ip_header:
Clean up stale realip references after client_ip_header rename
remove realip option, add default in conf/dokuwiki.php
convert tests to data provider
add comment to the real-ip test
add custom client_ip_header

show more ...

Clean up stale realip references after client_ip_header rename

Update docblocks in Ip.php and common.php, fix old tests to use
the new config key, remove outdated translations, fix method casing
in

Clean up stale realip references after client_ip_header rename

Update docblocks in Ip.php and common.php, fix old tests to use
the new config key, remove outdated translations, fix method casing
in test, and add example to English config description.

show more ...

remove realip option, add default in conf/dokuwiki.php

�� Rector and PHPCS fixes

Merge pull request #4490 from WillForan/32bitpack

32bit IPv6 unpack

updated rector and applied it

add custom client_ip_header

fix: 32bit IP tests w/string of decimal representation, overflows

Math in PHP is hard!
sprintf("%.0f",0x7FFFFFFFFFFFFFFF) == sprintf("%.0f",0x7FFFFFFFFFFFFF00)

Changes
* 32bit gets own version o

fix: 32bit IP tests w/string of decimal representation, overflows

Math in PHP is hard!
sprintf("%.0f",0x7FFFFFFFFFFFFFFF) == sprintf("%.0f",0x7FFFFFFFFFFFFF00)

Changes
* 32bit gets own version of tests where expected values are strings
* decimalToBinary32 to replace `sprintf("%032b%032b"...)`, avoids overflow
* overflow check in ipv4 too
* refactor
* partsTo64 for 32bit parts into dec value as str (bcmath)
* Ip32::$b32 as class constant
* condition always PHP_INT_SIZE == 4 for 32bit (instead of == 8 for 64)

show more ...

refactor(ip): PSR-12 functions

bitmask64_32 -> bitmask64On32
make_bitmask_32 -> makeBitmaskOn32
ipv6_upper_lower_32 -> ipv6UpperLowerOn32

also
* uncomment working 7FFF ipv6 test a

refactor(ip): PSR-12 functions

bitmask64_32 -> bitmask64On32
make_bitmask_32 -> makeBitmaskOn32
ipv6_upper_lower_32 -> ipv6UpperLowerOn32

also
* uncomment working 7FFF ipv6 test and
* fix README suggested podman to use `docker://wpstaging`

show more ...

chore(inc/Ip32): move 32bit funcs into own file/class.

easier to remove when x86 is officially deprecated

Merge remote-tracking branch 'upstream/master' into 32bitpack

fix(inc/Ip): 32bit arch compatible range check

* added docs about running tests on 32bit w/ podman.
* Updated tests to use string instead of int for comparison when 32bit.
* added `make_bitmask_3

fix(inc/Ip): 32bit arch compatible range check

* added docs about running tests on 32bit w/ podman.
* Updated tests to use string instead of int for comparison when 32bit.
* added `make_bitmask_32` and `bitmask64_32`. updated `ipInRange` to
use them.

Test failing for `test_ip_to_number`
```
podman run -v $PWD/..:/dokuwiki \
--workdir /dokuwiki/_test -it \
docker://wpstaging/php:8.3-32bit \
./vendor/bin/phpunit --verbose --stderr --filter ip_test
```

```

1) ip_test::test_ip_to_number with data set #3 ('38AF:3033:AA39:CDE3:1A46:094C...D:5300', 6, 4.084536385505709E+18, 1.8932109165344407E+18)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'4084536385505709056'
+'4084536381210742243'

/dokuwiki/_test/tests/inc/Ip.test.php:52

2) ip_test::test_ip_to_number with data set #5 ('193.53.125.7', 4, 0, 3241508103)
Failed asserting that -1053459193 is identical to 3241508103.

```

show more ...

refactor: ipv6_upper_lower_32 from ipToNumber

pull 32-bit specific code into it's own function
hopefully to be tested in _test/tests/inc/Ip.test.php (?)

Stuck on differnce between J2 and N4
J shoul

refactor: ipv6_upper_lower_32 from ipToNumber

pull 32-bit specific code into it's own function
hopefully to be tested in _test/tests/inc/Ip.test.php (?)

Stuck on differnce between J2 and N4
J should be **unsigned** 64 bit, big endian byte order long
but see negatives!?

$ip = inet_pton('ffff:ffff:ffff:fff0:ffff:ffff:ffff:ffff');
print_r(unpack('J2', $ip));
Array
(
[1] => -16
[2] => -1
)

For reference

print_r(unpack('N4', $ip));
Array
(
[1] => 4294967295
[2] => 4294967280
[3] => 4294967295
[4] => 4294967295
)

print_r(unpack('v8', $ip));
Array
(
[1] => 65535
[2] => 65535
[3] => 65535
[4] => 61695
[5] => 65535
[6] => 65535
[7] => 65535
[8] => 65535
)

show more ...

WIP: ipv6 calc for 32bit #4485 (LLM slop)

first pass with chatGPT

extend tests, fix issues with new Ip methods

Make is_ssl and baseurl use proper proxy checks

This should not only address #4455 but also ensures that the related
headers are only used when they come from a trusted reverse proxy chain.

Fix Ip tests

We no longer use the old regexp based config, so the tests failed.

rename trustedproxy option to trustedproxies

We use a new format (array instead of regex) and need a sure way to
recognize it. Zebra's approach would not have survived the editing via
config manager

rename trustedproxy option to trustedproxies

We use a new format (array instead of regex) and need a sure way to
recognize it. Zebra's approach would not have survived the editing via
config manager.
As a side effect this also introduces a new languange string, which is
good because the old one did no longer apply.

show more ...

some small cleanups in Ip class

most importantly do not crash on invalid config

Move IP functions into a class