code style: line breaks

coding style: control flow whitespaces

codestyle adjustments: function declaration braces/spaces

codestyle adjustments: class declaration braces

apply PSR-12 constant visibility rule

PSR-12 says constants need their visibility declared from PHP 7.1
onwards

Apply rector fixes to the rest of inc

fix handling of loading auth backend

When a non existing auth backend was configured, the action router ran
into an infinie loop exception. The reason was that the denied action
required a configure

fix handling of loading auth backend

When a non existing auth backend was configured, the action router ran
into an infinie loop exception. The reason was that the denied action
required a configured auth system, but denying access should always
work.

Interestingly the problem did not occur when the auth backend signalled
a failure to load. This was because the auth backend was not properly
deinitialized. This is now done.

To aid debugging similar problems, fatal errors are now logged through
the logging mechanism in the action router

show more ...

Fix typo in error message

First go at moving the plugin classes into their own namespace

renamed ActionRouter::checkPermissions to checkPreconditions

As discussed in #1933

pass action name by reference. fixes #2117

This fixes plugins that expect that they can change the global $ACT
instead of $event->data in the ACTION_ACT_PREPROCESS event.

This make the whole route

pass action name by reference. fixes #2117

This fixes plugins that expect that they can change the global $ACT
instead of $event->data in the ACTION_ACT_PREPROCESS event.

This make the whole route a little bit uncleaner but would increase
backwards compatibility.

I'm not sure how widespread the problem is and if adding this is a good
idea.

show more ...

fix(ActionRouter): trigger ACTION_ACT_PREPROCESS for all actions

This should recreate the behaviour prior to #1933, where the event was
triggered for all ACT values. Some plugins, like edittable, de

fix(ActionRouter): trigger ACTION_ACT_PREPROCESS for all actions

This should recreate the behaviour prior to #1933, where the event was
triggered for all ACT values. Some plugins, like edittable, depend on
the functionality.

show more ...

do not hide fatal exceptions during unit tests

undo unecessary action routing adjustments

Test code for workflow 'show - sectionedit - save/cancel' (with modifications in test classes and 'send_redirect()' and 'act_dispatch()'.

fixed some style errors found by scrutinizer

introduce a redirect action

Action can now abort to 'redirect' to explicitly trigger a redirect
back to showing the current page. Automatic triggering for post->show is
now only done when a 'show' a

introduce a redirect action

Action can now abort to 'redirect' to explicitly trigger a redirect
back to showing the current page. Automatic triggering for post->show is
now only done when a 'show' action was not explicitly requested.

show more ...

allow actions to throw exception that are shown to the user

removed unneeded check

the $from != $to check is handled further up already and throws an
exception.

no longer rely on actionOk when checking if actions are disabled

loadAction() and checkAction() are now public and could be used within
actionOK(). However some weird circular references prevent tha

no longer rely on actionOk when checking if actions are disabled

loadAction() and checkAction() are now public and could be used within
actionOK(). However some weird circular references prevent that. In
addition, actionOK is also used to check for things that aren't Actions
(yet) like 'rss' and 'top'.

show more ...

fixed export action by supporting underscores in actions

Now underscores can be used to have sub actions. The loader will try to
find an exact match first, then begin removing parts from the end unt

fixed export action by supporting underscores in actions

Now underscores can be used to have sub actions. The loader will try to
find an exact match first, then begin removing parts from the end until
a matching action is found.

show more ...

fix singleton pattern in ActionRouter

better action transitions

It should now catch any circular loops (by having a maxiumum recursion
depth) and it handles the automatic redirect after save (and others)

Add action plugin hooks back into the ActionRouter

This is not how integration of plugins would ideally be done in this new
system. Ideally an action plugin would actually implement an instance of
A

Add action plugin hooks back into the ActionRouter

This is not how integration of plugins would ideally be done in this new
system. Ideally an action plugin would actually implement an instance of
AbstractAction and would just fall into the normal flow of actions here.

However to not break a gazillion of existing plugins, this is just add
the existing two events into the new system through the use of a Plugin
action.

Maybe we could add "new" action plugins later.

show more ...

all actions should have a class now

Lots of FIXMEs and the routing isn't integrated, yet