remove valid_input_set(), inline the only remaining callers

The Input::valid() method on $INPUT already provides the cleaner API
originally requested in #667. The last two callers in Subscribe.php
v

remove valid_input_set(), inline the only remaining callers

The Input::valid() method on $INPUT already provides the cleaner API
originally requested in #667. The last two callers in Subscribe.php
validated against a local $params array (not $_POST/$_GET) and need
to throw a specific exception, so inline a small in_array + throw at
those call sites rather than carry the legacy helper.

The class could probably be made cleaner but that's beyond the scope of
this change.

Closes #667

show more ...

updated rector and applied it

Use str_starts_with/str_ends_with

coding style: control flow whitespaces

coding style: function call spacing

coding style: PSR12.Classes.ClassInstantiation.MissingParentheses

codestyle adjustments: class declaration braces

Apply rector fixes to inc/Action

import classes, replace dbglog, simplify, remove unused statements, and other warnings from IntelliJ

update phpdocs,
rename dokuwiki/Ui/Draft to PageDraft

Ui\Subscribe class replaces tpl_subscribe()

Merge branch 'psr2-pluginredux' into psr2

* psr2-pluginredux:
Minor optimizations in PluginController
Snake to Camel case fixes inn PluginController
Fix snake->camel case, doc blocks
minor c

Merge branch 'psr2-pluginredux' into psr2

* psr2-pluginredux:
Minor optimizations in PluginController
Snake to Camel case fixes inn PluginController
Fix snake->camel case, doc blocks
minor code simplification
snake to camel case fixes in EventHandler
Move list of plugin types to plugin controller constant
Avoid accessing the evet system before it's intialized
Avoid processing events before the Event System is intiialized
isEnabled instead of isDisabled
removed get_directory() method from PluginController
fix type hints
moved plugin controller to Extension namespace
removed deleted file from autoloader
deprecated trigger_event() in favor of a static method on Event
First go at moving the plugin classes into their own namespace

show more ...

♻️ Don't use deprecated subscription methods

deprecated trigger_event() in favor of a static method on Event

renamed ActionRouter::checkPermissions to checkPreconditions

As discussed in #1933

have all subscription handling in subscribe action

uses the explicit redirect abort on success

no longer rely on actionOk when checking if actions are disabled

loadAction() and checkAction() are now public and could be used within
actionOK(). However some weird circular references prevent tha

no longer rely on actionOk when checking if actions are disabled

loadAction() and checkAction() are now public and could be used within
actionOK(). However some weird circular references prevent that. In
addition, actionOK is also used to check for things that aren't Actions
(yet) like 'rss' and 'top'.

show more ...

explicitly declare method visibility

more doc block fixes

start of a refactoring the action routing

This is neither complete nor working, yet