test: add tests to catch #4637

Issue #4637 was fixed in 7686f2030b19f948d2e50df1613ef6592fa44b46 but I
didn't like that no test had caught the issue.

This adds a specific test for the issue as a Ha

test: add tests to catch #4637

Issue #4637 was fixed in 7686f2030b19f948d2e50df1613ef6592fa44b46 but I
didn't like that no test had caught the issue.

This adds a specific test for the issue as a HandlerTest. Additionally a
simple smoke test is added that renders the wiki:syntax page and
inspects the created DOM. It's not comprehensive but might help flagging
similar issue in the future.

show more ...

migrate parser tests to modern namespaced classes

Move old-style parser tests from _test/tests/inc/parser/ to namespaced
test classes under _test/tests/Parsing/ParserMode/ and
_test/tests/Parsing/Le

migrate parser tests to modern namespaced classes

Move old-style parser tests from _test/tests/inc/parser/ to namespaced
test classes under _test/tests/Parsing/ParserMode/ and
_test/tests/Parsing/Lexer/.

- Add ParserTestBase with assertCalls() helper for comparing handler
call sequences with byte index stripping
- Split lexer.test.php into ParallelRegexTest, StateStackTest, and
LexerTest with a RecordingHandler that extends Handler
- Merge handler_parse_highlight_options tests into CodeTest
- Add new tests for previously untested modes: Nocache, Notoc, Rss,
and all individual formatting modes (Strong, Emphasis, etc.)
- Modernize test code: [] syntax, lowercase null, correct assertEquals
argument order, replace deprecated withConsecutive and string callables
- Renderer tests remain in old location (renderers not yet migrated)

show more ...

move handler methods into ParserMode classes and rename Handler

Each ParserMode class now implements handle() from ModeInterface,
containing the token handling logic that previously lived as individ

move handler methods into ParserMode classes and rename Handler

Each ParserMode class now implements handle() from ModeInterface,
containing the token handling logic that previously lived as individual
methods on Doku_Handler.

The Handler class (formerly Doku_Handler) is the single dispatch point:
Lexer passes tokens to Handler::handleToken() which routes to mode
objects, plugins, or returns false. The Lexer only tokenizes and
resolves mapHandler aliases.

Key changes:
- Add handle() to ModeInterface, implemented by all mode classes
- Move Doku_Handler to dokuwiki\Parsing\Handler namespace
- File extends Code (shared parsing via $type property)
- Quotes uses mapHandler() + Handler::getModeName() for sub-modes
- Media::parseMedia() replaces Doku_Handler_Parse_Media()
- Code::parseHighlightOptions() replaces parse_highlight_options()
- Per-parse state (footnote, doublequote) stays on Handler
- Deprecated wrappers kept for base/header/internallink/media
- Class alias and rector rules added for backward compatibility

show more ...

split Formatting into individual classes per formatting type

Introduce AbstractFormatting as a base class and seven concrete
classes (Strong, Emphasis, Underline, Monospace, Subscript,
Superscript,

split Formatting into individual classes per formatting type

Introduce AbstractFormatting as a base class and seven concrete
classes (Strong, Emphasis, Underline, Monospace, Subscript,
Superscript, Deleted) that each define their own patterns and
sort order. Delete the old Formatting class and update tests
to use the new classes directly. ModeRegistry now treats
formatting modes as regular built-in modes.

show more ...

introduce ModeRegistry to encapsulate parser mode categories

Replace the global $PARSER_MODES definition in inc/parser/parser.php
with a ModeRegistry singleton that initializes and manages the mode

introduce ModeRegistry to encapsulate parser mode categories

Replace the global $PARSER_MODES definition in inc/parser/parser.php
with a ModeRegistry singleton that initializes and manages the mode
categories. The global array is still populated for backward
compatibility with plugins that access it directly.

Mode constructors now use ModeRegistry::getModesForCategories()
instead of accessing the global directly. p_get_parsermodes() and
p_sort_modes() are moved to inc/deprecated.php as thin wrappers.

show more ...

remove dead ParallelRegex::apply() method

Remove apply() which was never called from production code. Rewrite
the inherited SimpleTest tests to use split() instead, and add a
test for pre/post-match

remove dead ParallelRegex::apply() method

Remove apply() which was never called from production code. Rewrite
the inherited SimpleTest tests to use split() instead, and add a
test for pre/post-match splitting.

show more ...

adjusted tests for new buildURLparams()

null values are no longer added as empty parameters.

Tests: The at() matcher has been deprecated

fixes #3811

Replaces at() with withConsecutive() in these tests:

- TestOfLexer::testSinglePattern
- TestOfLexer::testMultiplePattern
- TestOfLexerModes:

Tests: The at() matcher has been deprecated

fixes #3811

Replaces at() with withConsecutive() in these tests:

- TestOfLexer::testSinglePattern
- TestOfLexer::testMultiplePattern
- TestOfLexerModes::testIsolatedPattern
- TestOfLexerModes::testModeChange
- TestOfLexerModes::testNesting
- TestOfLexerModes::testSingular
- TestOfLexerModes::testUnwindTooFar
- TestOfLexerHandlers::testModeMapping
- TestOfLexerByteIndices::testIndex
- TestOfLexerByteIndices::testIndexLookaheadEqual
- TestOfLexerByteIndices::testIndexLookaheadNotEqual
- TestOfLexerByteIndices::testIndexLookbehindEqual
- TestOfLexerByteIndices::testIndexLookbehindNotEqual

show more ...

fall back to empty (root) dir for base dir detection

When a basedir could not be detected, the default previously was '.'
resulting in a valid but weird URL (http://example.com/./doku.php). We
now d

fall back to empty (root) dir for base dir detection

When a basedir could not be detected, the default previously was '.'
resulting in a valid but weird URL (http://example.com/./doku.php). We
now default to an empty dir, resulting in a more sensible URL of
http://example.com/doku.php

This should not matter in real web server setups but will be in effect
while testing.

show more ...

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had legitimate use of these options.

If someone needs the functionality, it can easily be added back using a
plugin. But I prefer to give users one less option to shoot themselves
in the foot.

Removal of the translations for the config strings can follow after this
has been merged.

show more ...

always use the same htmlspecialchars setup

defaults for htmlspecialchars change in PHP 8.1

All calls should always use our hsc() method to ensure comparability
(especially when testing)

Revert "Merge pull request #3039 from takuy/video-attributes"

This reverts commit 408d79f78505248f9ccb44bd2561cedc250ce5a1, reversing
changes made to b7c67f83bd81eff3186e4ebd2d9e86cd2c32468d.

Revert "fixed video attribute handling in php8"

This reverts commit f5cdab8ec90af0cde0c0e32209470cfa820b8ab5.

Revert "more php8 fixes for the video attributes"

This reverts commit 89e046c85b43365a46ce9f137a1b843d3ef6813b.

more php8 fixes for the video attributes

I defaulted back to null instead of an empty array.

fixed video attribute handling in php8

Fix PHPUnit fatal errors compatibility with void.

add needed type hints for phpunit8

This will break a lot of plugin tests, but can't be avoided

PHP 8: rename match() to apply() in Lexer #3298

missed another unit test

fix test again

Remove height & weight defaults from video embeds

d'oh completely overlooked this

another fix

only pass around videoAtts if it's a video

try to make tests happy again

another try at fixing tests

Delete local.php.bak.php

more test fixes

one more (lol)

one more