SearchIndex: rewrite Indexer to use Collection classes

Replace the intermediate #2943 classes (FulltextIndex, MetadataIndex)
with the new Collection-based architecture. The Indexer is now a thin
sta

SearchIndex: rewrite Indexer to use Collection classes

Replace the intermediate #2943 classes (FulltextIndex, MetadataIndex)
with the new Collection-based architecture. The Indexer is now a thin
stateless orchestrator that delegates all index work to collections.

Key changes:
- Indexer no longer extends AbstractIndex; page name passed to methods
- addPage/deletePage/clear use PageTitleCollection,
PageFulltextCollection, and PageMetaCollection
- New PageMetaCollection replaces separate ReferencesCollection and
MediaCollection with a single class that handles arbitrary metadata
keys dynamically
- Shared writable FileIndex('page') passed to all collections
- Logger callback replaces verbose parameter
- Methods return void instead of bool
- Index classes implement IteratorAggregate for clean data access
- Indexer tests consolidated into namespaced IndexerTest.php
- All callers updated to new stateless API

show more ...

Merge branch 'master' into searchIndex-finish

* master: (55 commits)
Translation update (pt-br)
Bump phpseclib/phpseclib from 3.0.49 to 3.0.50
�� Update deleted files
strict value comparison

Merge branch 'master' into searchIndex-finish

* master: (55 commits)
Translation update (pt-br)
Bump phpseclib/phpseclib from 3.0.49 to 3.0.50
�� Update deleted files
strict value comparison in auth session check. fixes #4602
Translation update (pt-br)
Translation update (pt-br)
remove utf8_encode() from authad plugin
todo checker action: ignore vendor
updated rector and applied it
removed another php 7.4 workaround
removed an old PHP 5 workaround in HTTPClient
remove checks for mbstring.func_overload
removed php 8 polyfills
ignore HTML validation issue with skipped headline levels
declare PrefCookie constant visibility
update slika which fixes another php 8.5 deprecation issue
fix http tests
fix destructuring false returns from changelog functions
avoid using null as cache key
Fix deprecation warning in UTF8/Conversion
...

show more ...

updated tests for PHP 8.2

* now using DomWrapper 3.0 which removes a bunch of deprecation messages
* fixed class name throwing a warning
* fixed deprecated reflection use

Merge branch 'master' into searchIndex-finish

There were a lot of conflicts to resolve. Not all of them may have been
resolved correctly...

* master: (1094 commits)
Login accessibility improvemen

Merge branch 'master' into searchIndex-finish

There were a lot of conflicts to resolve. Not all of them may have been
resolved correctly...

* master: (1094 commits)
Login accessibility improvements
Translation update (it)
translation update
translation update
translation update
translation update
translation update
translation update
translation update
translation update
translation update
translation update
translation update
translation update
Remove HTML from strings based on title and tagline
SECURITY: fix XSS vulnerability. fixes #4512
translation update
Fix typos in usermanager English strings
Replace hardcoded message by localized string
set DOKU_INC in rector
...

show more ...

Allow tests to expect log messages

avoid timeouts in tests

For some reason it seems that CLI tests on github run with a execution
time limit that can't be disabled by setting the appropriate ini value.
Even more odd, the problem seem

avoid timeouts in tests

For some reason it seems that CLI tests on github run with a execution
time limit that can't be disabled by setting the appropriate ini value.
Even more odd, the problem seems to exist on windows only (even though
the same limit is set on both OSes). In any case, this simply resets the
time limit for each test run and that seems to fix the timeout issue.

show more ...

Merge remote-tracking branch 'upstream/master' into Refactor_Fulltext

typo

fix PHP8 errors in tests

These were problems within the tests itself. There are many more
problems in the actual code.

add needed type hints for phpunit8

This will break a lot of plugin tests, but can't be avoided

remove unnamespaced php unit wrapper

change Index objects to non-singleton

Indexer, FulltextIndex, MetadataIndex uses common directory to store *.idx files, but this does not mean they should be singleton objects to avoid lock confrict

change Index objects to non-singleton

Indexer, FulltextIndex, MetadataIndex uses common directory to store *.idx files, but this does not mean they should be singleton objects to avoid lock confrictions.

show more ...

use Indexer.php instead of PageIndex.php

rewrite test files

replace idx_* and ft_* functions with relevant class metods

Avoid flaky tests by waiting full seconds

The waitForTick() method tried to be clever and return early if a second
had passed since the last call already. Unfortunatel this did not work
reliably in

Avoid flaky tests by waiting full seconds

The waitForTick() method tried to be clever and return early if a second
had passed since the last call already. Unfortunatel this did not work
reliably in our tests and we often had failures on tests that required
unique revision numbers.

Pull requests for a reliable version welcome. Until the we wait a second
on each call.

show more ...

moved plugin controller to Extension namespace

deprecated trigger_event() in favor of a static method on Event

First go at moving the plugin classes into their own namespace

adjusted the Input clases for PSR2

They are now in their own namespace.

Merge branch 'testinit' into psr2-config

* testinit:
reset config directory for every test

reset config directory for every test

Our test suite did not reset the config directory for each test class as
it does for the data directory. In addition it copied all files from the
main config di

reset config directory for every test

Our test suite did not reset the config directory for each test class as
it does for the data directory. In addition it copied all files from the
main config directory over. Both may create an unpredictable state for
tests.

This streamlines the initialization.

show more ...

add methods to test interal properties

You shouldn't really do this. But sometimes its so much easier to write
a test that flips an internal bit than to do it poperly(tm). Better a
risky test than n

add methods to test interal properties

You shouldn't really do this. But sometimes its so much easier to write
a test that flips an internal bit than to do it poperly(tm). Better a
risky test than none...

show more ...

make testing of inaccessible methods easier

While it's generally frowned upon testing privates, it can often be
useful and the easier way to write tests. Eg you want to test something
complicated me

make testing of inaccessible methods easier

While it's generally frowned upon testing privates, it can often be
useful and the easier way to write tests. Eg you want to test something
complicated method that is important, but you do not want to expose it
directly to other classes...

This new method uses reflection to make access to such methods possible
from within tests without the need for intermediate classes.

show more ...

remove createMock & createPartialMock polyfill, dropping support for PHPUnit 5.7-

support phpunit 5 and 6

We still need 5 to test on old php versions, but travis uses 6 for newer
PHP versions (and 5 may break on those).

Luckily both versions aren't that far apart, yet. This adds

support phpunit 5 and 6

We still need 5 to test on old php versions, but travis uses 6 for newer
PHP versions (and 5 may break on those).

Luckily both versions aren't that far apart, yet. This adds a thin
adapter class when running on 6.

show more ...