accidentally removed this on an earlier commit

more test fixes

typo fix

bug fixes & added fixes for existing tests

Fix noNSorNS zero ID issue with unit tests, fixes #3037

Fix ExternalLink tests

Fixed broken link rendering for external links at start of line

External links at the start of line like 'www.example.com' were
not rendered as links any more. The issue was introduced with PR #1988

Fixed broken link rendering for external links at start of line

External links at the start of line like 'www.example.com' were
not rendered as links any more. The issue was introduced with PR #1988.
Fixes #2399.

show more ...

fix data-wiki-id test failure

shortcut relative link: fix 3 levels up situation

Match multiple levels shortcut relative link, fixes #1076

Previously the regex only matches one level. Test added as well.

separate some test AuthPlugins to single files

created AuthDeletePlugin and AuthCaseInsensitivePlugin under dokuwiki\test\mock

check RemoteException code in unit tests

Change cases of assertTrue in tests

add drupal and seafile hash methods

Add test for video titles

add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions

add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions if it's about argument
missing.

show more ...

suppress argument missing warnings on remote API test

This makes sure PHPUnit won't convert warnings into exceptions, and thus behaves
as the same as regular DokuWiki where E_NOTICE is suppressed.

rename vague AuthPlugin used by remote and authdelete tests

add unit tests that check exception type on remote args missing for #2545

relax Revert permission to EDIT from manager

Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check.

Than

relax Revert permission to EDIT from manager

Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check.

Thank you @Klap-in for pointing this out.

show more ...

Split out temporary code style excludes

Splitting them out allows for plugins to use _test/phpcs.xml as the
basis for their own linting without having an overly permissive coding
standard.
Also, thi

Split out temporary code style excludes

Splitting them out allows for plugins to use _test/phpcs.xml as the
basis for their own linting without having an overly permissive coding
standard.
Also, this makes it more obvious and painful that these are just
intended as temporary exceptions and should be actually fixed.

The rule `Generic.ControlStructures.InlineControlStructure.NotAllowed`
has its comment adjust to make it clear that this is an intended
deviation from the PSR-2/PSR-12 coding standard.

The rule `PSR1.Classes.ClassDeclaration.MissingNamespace` has to remain
in the DokuWiki coding standard as the plugin base classes can currently
not reasonably be in namespaces.

show more ...

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures all possible ways to define a callback (including static
methods) can be used.

This should fix a problem mentioned in #2943

show more ...

create PluginUtils.test.php

add trim, and polish test_quotes of css_compress, again

An edge case that space at the beginning won't get removed.

polish test_quotes of css_compress

Now the testcase string should be clearer to read

Add test_escapedQuotes to css_compress

Thank you @micgro42!

Co-Authored-By: Michael Große <mic.grosse@googlemail.com>

Check code style against PSR12

In 2019 PSR-12 was officially released and PSR-2 deprecated. We should
adapt to that and check our files against that new coding standard.