18f259467SAndreas Gohr<?php 2d6d97f60SAnna Dabrowska 38f259467SAndreas Gohr/** 48f259467SAndreas Gohr * DokuWiki Plugin struct (Action Component) 58f259467SAndreas Gohr * 68f259467SAndreas Gohr * @license GPL 2 http://www.gnu.org/licenses/gpl-2.0.html 78f259467SAndreas Gohr * @author Andreas Gohr, Michael Große <dokuwiki@cosmocode.de> 88f259467SAndreas Gohr */ 98f259467SAndreas Gohr 108f259467SAndreas Gohr/** 118f259467SAndreas Gohr * Class action_plugin_struct_migration 128f259467SAndreas Gohr * 138f259467SAndreas Gohr * Handle migrations that need more than just SQL 148f259467SAndreas Gohr */ 15d6d97f60SAnna Dabrowskaclass action_plugin_struct_migration extends DokuWiki_Action_Plugin 16d6d97f60SAnna Dabrowska{ 178f259467SAndreas Gohr /** 188f259467SAndreas Gohr * @inheritDoc 198f259467SAndreas Gohr */ 20d6d97f60SAnna Dabrowska public function register(Doku_Event_Handler $controller) 21d6d97f60SAnna Dabrowska { 22748e747fSAnna Dabrowska $controller->register_hook('PLUGIN_SQLITE_DATABASE_UPGRADE', 'BEFORE', $this, 'handleMigrations'); 238f259467SAndreas Gohr } 248f259467SAndreas Gohr 258f259467SAndreas Gohr /** 268f259467SAndreas Gohr * Call our custom migrations when defined 278f259467SAndreas Gohr * 288f259467SAndreas Gohr * @param Doku_Event $event 298f259467SAndreas Gohr * @param $param 308f259467SAndreas Gohr */ 31748e747fSAnna Dabrowska public function handleMigrations(Doku_Event $event, $param) 32d6d97f60SAnna Dabrowska { 333eafcbabSMichael Große if ($event->data['sqlite']->getAdapter()->getDbname() !== 'struct') { 343eafcbabSMichael Große return; 353eafcbabSMichael Große } 368f259467SAndreas Gohr $to = $event->data['to']; 378f259467SAndreas Gohr 388f259467SAndreas Gohr if (is_callable(array($this, "migration$to"))) { 398f259467SAndreas Gohr $event->preventDefault(); 408f259467SAndreas Gohr $event->result = call_user_func(array($this, "migration$to"), $event->data['sqlite']); 418f259467SAndreas Gohr } 428f259467SAndreas Gohr } 438f259467SAndreas Gohr 448f259467SAndreas Gohr /** 458f259467SAndreas Gohr * Executes Migration 12 468f259467SAndreas Gohr * 478f259467SAndreas Gohr * Add a latest column to all existing multi tables 488f259467SAndreas Gohr * 498f259467SAndreas Gohr * @param helper_plugin_sqlite $sqlite 508f259467SAndreas Gohr * @return bool 518f259467SAndreas Gohr */ 52d6d97f60SAnna Dabrowska protected function migration12(helper_plugin_sqlite $sqlite) 53d6d97f60SAnna Dabrowska { 548f259467SAndreas Gohr /** @noinspection SqlResolve */ 558f259467SAndreas Gohr $sql = "SELECT name FROM sqlite_master WHERE type = 'table' AND name LIKE 'multi_%'"; 568f259467SAndreas Gohr $res = $sqlite->query($sql); 578f259467SAndreas Gohr $tables = $sqlite->res2arr($res); 588f259467SAndreas Gohr $sqlite->res_close($res); 598f259467SAndreas Gohr 608f259467SAndreas Gohr foreach ($tables as $row) { 618f259467SAndreas Gohr $sql = 'ALTER TABLE ? ADD COLUMN latest INT DEFAULT 1'; 628f259467SAndreas Gohr $sqlite->query($sql, $row['name']); 638f259467SAndreas Gohr } 648f259467SAndreas Gohr 658f259467SAndreas Gohr return true; 668f259467SAndreas Gohr } 6776a74c23SAnna Dabrowska 6876a74c23SAnna Dabrowska /** 6976a74c23SAnna Dabrowska * Executes Migration 16 7076a74c23SAnna Dabrowska * 7176a74c23SAnna Dabrowska * Unifies previous page and lookup schema types 7276a74c23SAnna Dabrowska * 7376a74c23SAnna Dabrowska * @param helper_plugin_sqlite $sqlite 7476a74c23SAnna Dabrowska * @return bool 7576a74c23SAnna Dabrowska */ 7676a74c23SAnna Dabrowska protected function migration16(helper_plugin_sqlite $sqlite) 7776a74c23SAnna Dabrowska { 7876a74c23SAnna Dabrowska // get tables and their SQL definitions 7976a74c23SAnna Dabrowska $sql = "SELECT sql, name FROM sqlite_master 8076a74c23SAnna Dabrowska WHERE type = 'table' 8176a74c23SAnna Dabrowska AND (name LIKE 'data_%' OR name LIKE 'multi_%')"; 8276a74c23SAnna Dabrowska $res = $sqlite->query($sql); 8376a74c23SAnna Dabrowska $tables = $sqlite->res2arr($res); 8476a74c23SAnna Dabrowska $sqlite->res_close($res); 8576a74c23SAnna Dabrowska 8676a74c23SAnna Dabrowska // get latest versions of schemas with islookup property 8776a74c23SAnna Dabrowska $sql = "SELECT MAX(id) AS id, tbl, islookup FROM schemas 8876a74c23SAnna Dabrowska GROUP BY tbl 8976a74c23SAnna Dabrowska "; 9076a74c23SAnna Dabrowska $res = $sqlite->query($sql); 9176a74c23SAnna Dabrowska $schemas = $sqlite->res2arr($res); 9276a74c23SAnna Dabrowska 9376a74c23SAnna Dabrowska $sqlite->query('BEGIN TRANSACTION'); 9476a74c23SAnna Dabrowska $ok = true; 9576a74c23SAnna Dabrowska 9676a74c23SAnna Dabrowska // Step 1: move original data to temporary tables and create new ones with modified schemas 9776a74c23SAnna Dabrowska foreach ($tables as $table) { 9876a74c23SAnna Dabrowska $name = $table['name']; 9976a74c23SAnna Dabrowska $sql = $table['sql']; 10076a74c23SAnna Dabrowska 10176a74c23SAnna Dabrowska // move original data to temp_* 10276a74c23SAnna Dabrowska $ok = $ok && $sqlite->query("ALTER TABLE $name RENAME TO temp_$name"); 10376a74c23SAnna Dabrowska 10476a74c23SAnna Dabrowska // update pid definitions 10576a74c23SAnna Dabrowska $sql = preg_replace('/pid (\w* ?NOT NULL|\w* ?PRIMARY KEY)/', 'pid TEXT DEFAULT ""', $sql); 10676a74c23SAnna Dabrowska 10776a74c23SAnna Dabrowska // add rid and new primary key to regular tables 10876a74c23SAnna Dabrowska $cnt = 0; 10976a74c23SAnna Dabrowska $sql = preg_replace('/(PRIMARY KEY ?\([^\)]+?)(\))/', ' rid INTEGER, $1, rid $2', $sql, -1, $cnt); 11076a74c23SAnna Dabrowska // add rid and new primary key to lookup tables 11176a74c23SAnna Dabrowska if (!$cnt) { 11276a74c23SAnna Dabrowska $sql = str_replace(')', ', rid INTEGER, PRIMARY KEY(pid,rid) )', $sql); 11376a74c23SAnna Dabrowska } 11476a74c23SAnna Dabrowska 11576a74c23SAnna Dabrowska // create the new table 11676a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($sql); 11776a74c23SAnna Dabrowska if (!$ok) return false; 11876a74c23SAnna Dabrowska } 11976a74c23SAnna Dabrowska 12076a74c23SAnna Dabrowska // Step 2: transfer data back from original tables (temp_*) 12176a74c23SAnna Dabrowska foreach ($schemas as $schema) { 12276a74c23SAnna Dabrowska $name = $schema['tbl']; 12376a74c23SAnna Dabrowska $sid = $schema['id']; 12476a74c23SAnna Dabrowska $isLookup = $schema['islookup']; 12576a74c23SAnna Dabrowska 12676a74c23SAnna Dabrowska if (!$isLookup) { 12776a74c23SAnna Dabrowska $s = sprintf('INSERT INTO data_%s SELECT *, 0 FROM temp_data_%s', $name, $name); 12876a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 12976a74c23SAnna Dabrowska if (!$ok) return false; 13076a74c23SAnna Dabrowska 13176a74c23SAnna Dabrowska $s = sprintf('INSERT INTO multi_%s SELECT *, 0 FROM temp_multi_%s', $name, $name); 13276a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 13376a74c23SAnna Dabrowska if (!$ok) return false; 13476a74c23SAnna Dabrowska } else { 13576a74c23SAnna Dabrowska // transfer pid to rid 13676a74c23SAnna Dabrowska $s = sprintf('INSERT INTO data_%s SELECT *, pid FROM temp_data_%s', $name, $name); 13776a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 13876a74c23SAnna Dabrowska if (!$ok) return false; 13976a74c23SAnna Dabrowska 14076a74c23SAnna Dabrowska $s = sprintf('INSERT INTO multi_%s SELECT *, pid FROM temp_multi_%s', $name, $name); 14176a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 14276a74c23SAnna Dabrowska if (!$ok) return false; 14376a74c23SAnna Dabrowska 14476a74c23SAnna Dabrowska // all lookup data has empty pids at this point 14576a74c23SAnna Dabrowska $s = "UPDATE data_$name SET pid = ''"; 14676a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 14776a74c23SAnna Dabrowska if (!$ok) return false; 14876a74c23SAnna Dabrowska 14976a74c23SAnna Dabrowska $s = "UPDATE multi_$name SET pid = ''"; 15076a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 15176a74c23SAnna Dabrowska if (!$ok) return false; 15276a74c23SAnna Dabrowska } 15376a74c23SAnna Dabrowska 15476a74c23SAnna Dabrowska // introduce composite ids in lookup columns 155*544dca1bSAnna Dabrowska $s = $this->getLookupColsSql($sid); 15676a74c23SAnna Dabrowska $res = $sqlite->query($s); 15776a74c23SAnna Dabrowska $cols = $sqlite->res2arr($res); 15876a74c23SAnna Dabrowska 15976a74c23SAnna Dabrowska if ($cols) { 16076a74c23SAnna Dabrowska foreach ($cols as $col) { 16176a74c23SAnna Dabrowska $colno = $col['COL']; 162e361da24SAnna Dabrowska // simple lookup fields 163e361da24SAnna Dabrowska $s = "UPDATE data_$name SET col$colno = '[" . '""' . ",'||col$colno||']' WHERE col$colno != '' AND CAST(col$colno AS DECIMAL) = col$colno"; 164e361da24SAnna Dabrowska $ok = $ok && $sqlite->query($s); 165e361da24SAnna Dabrowska if (!$ok) return false; 166e361da24SAnna Dabrowska // multi_ 167e361da24SAnna Dabrowska $s = "UPDATE multi_$name SET value = '[" . '""' . ",'||value||']' WHERE colref=$colno AND CAST(value AS DECIMAL) = value"; 16876a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 16976a74c23SAnna Dabrowska if (!$ok) return false; 17076a74c23SAnna Dabrowska 171e361da24SAnna Dabrowska // lookup fields pointing to pages 172e361da24SAnna Dabrowska $colname = "col$colno"; 173e361da24SAnna Dabrowska $f = 'UPDATE data_%s SET %s = \'["\'||%s||\'",0]\' WHERE %s != \'\' AND CAST(%s AS DECIMAL) != %s'; 174e361da24SAnna Dabrowska $s = sprintf($f, $name, $colname, $colname, $colname, $colname, $colname); 175e361da24SAnna Dabrowska $ok = $ok && $sqlite->query($s); 176e361da24SAnna Dabrowska if (!$ok) return false; 17776a74c23SAnna Dabrowska // multi_ 178e361da24SAnna Dabrowska $f = 'UPDATE multi_%s SET value = \'["value",0]\' WHERE colref = %s AND CAST(value AS DECIMAL) != value'; 179e361da24SAnna Dabrowska $s = sprintf($f, $name, $colno); 18076a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 18176a74c23SAnna Dabrowska if (!$ok) return false; 18276a74c23SAnna Dabrowska } 18376a74c23SAnna Dabrowska } 18476a74c23SAnna Dabrowska } 18576a74c23SAnna Dabrowska 18676a74c23SAnna Dabrowska // Step 3: delete temp_* tables 18776a74c23SAnna Dabrowska foreach ($tables as $table) { 18876a74c23SAnna Dabrowska $name = $table['name']; 18976a74c23SAnna Dabrowska $s = "DROP TABLE temp_$name"; 19076a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 19176a74c23SAnna Dabrowska if (!$ok) return false; 19276a74c23SAnna Dabrowska } 19376a74c23SAnna Dabrowska 19476a74c23SAnna Dabrowska // Step 4: remove islookup in schemas table 19576a74c23SAnna Dabrowska $sql = "SELECT sql FROM sqlite_master 19676a74c23SAnna Dabrowska WHERE type = 'table' 19776a74c23SAnna Dabrowska AND name = 'schemas'"; 19876a74c23SAnna Dabrowska $res = $sqlite->query($sql); 19976a74c23SAnna Dabrowska $t = $sqlite->res2arr($res); 20076a74c23SAnna Dabrowska $sql = $t[0]['sql']; 20176a74c23SAnna Dabrowska $sql = str_replace('islookup INTEGER,', '', $sql); 20276a74c23SAnna Dabrowska 20376a74c23SAnna Dabrowska $s = 'ALTER TABLE schemas RENAME TO temp_schemas'; 20476a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 20576a74c23SAnna Dabrowska if (!$ok) return false; 20676a74c23SAnna Dabrowska 20776a74c23SAnna Dabrowska // create a new table without islookup 20876a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($sql); 20976a74c23SAnna Dabrowska if (!$ok) return false; 21076a74c23SAnna Dabrowska 21176a74c23SAnna Dabrowska $s = 'INSERT INTO schemas SELECT id, tbl, ts, user, comment, config FROM temp_schemas'; 21276a74c23SAnna Dabrowska $ok = $ok && $sqlite->query($s); 21376a74c23SAnna Dabrowska 21476a74c23SAnna Dabrowska if (!$ok) { 21576a74c23SAnna Dabrowska $sqlite->query('ROLLBACK TRANSACTION'); 21676a74c23SAnna Dabrowska return false; 21776a74c23SAnna Dabrowska } 21876a74c23SAnna Dabrowska $sqlite->query('COMMIT TRANSACTION'); 21976a74c23SAnna Dabrowska return true; 22076a74c23SAnna Dabrowska } 221*544dca1bSAnna Dabrowska 222*544dca1bSAnna Dabrowska /** 223*544dca1bSAnna Dabrowska * Executes Migration 17 224*544dca1bSAnna Dabrowska * 225*544dca1bSAnna Dabrowska * Fixes lookup data not correctly migrated by #16 226*544dca1bSAnna Dabrowska * All lookups were presumed to reference lookup data, not pages, so the migrated value 227*544dca1bSAnna Dabrowska * was always ["", <previous-pid-aka-new-rid>]. For page references it is ["<previous-pid>", 0] 228*544dca1bSAnna Dabrowska * 229*544dca1bSAnna Dabrowska * @param helper_plugin_sqlite $sqlite 230*544dca1bSAnna Dabrowska * @return bool 231*544dca1bSAnna Dabrowska */ 232*544dca1bSAnna Dabrowska protected function migration17(helper_plugin_sqlite $sqlite) 233*544dca1bSAnna Dabrowska { 234*544dca1bSAnna Dabrowska $sql = "SELECT MAX(id) AS id, tbl FROM schemas 235*544dca1bSAnna Dabrowska GROUP BY tbl 236*544dca1bSAnna Dabrowska "; 237*544dca1bSAnna Dabrowska $res = $sqlite->query($sql); 238*544dca1bSAnna Dabrowska $schemas = $sqlite->res2arr($res); 239*544dca1bSAnna Dabrowska 240*544dca1bSAnna Dabrowska $sqlite->query('BEGIN TRANSACTION'); 241*544dca1bSAnna Dabrowska $ok = true; 242*544dca1bSAnna Dabrowska 243*544dca1bSAnna Dabrowska foreach ($schemas as $schema) { 244*544dca1bSAnna Dabrowska // find lookup columns 245*544dca1bSAnna Dabrowska $name = $schema['tbl']; 246*544dca1bSAnna Dabrowska $sid = $schema['id']; 247*544dca1bSAnna Dabrowska $s = $this->getLookupColsSql($sid); 248*544dca1bSAnna Dabrowska $res = $sqlite->query($s); 249*544dca1bSAnna Dabrowska $cols = $sqlite->res2arr($res); 250*544dca1bSAnna Dabrowska 251*544dca1bSAnna Dabrowska if ($cols) { 252*544dca1bSAnna Dabrowska $colnames = array_map(function ($c) { 253*544dca1bSAnna Dabrowska return 'col' . $c['COL']; 254*544dca1bSAnna Dabrowska }, $cols); 255*544dca1bSAnna Dabrowska 256*544dca1bSAnna Dabrowska // data_ tables 257*544dca1bSAnna Dabrowska $s = 'SELECT pid, rid, rev, ' . implode(', ', $colnames) . " FROM data_$name"; 258*544dca1bSAnna Dabrowska $res = $sqlite->query($s); 259*544dca1bSAnna Dabrowska $allValues = $sqlite->res2arr($res); 260*544dca1bSAnna Dabrowska 261*544dca1bSAnna Dabrowska if (!empty($allValues)) { 262*544dca1bSAnna Dabrowska foreach ($allValues as $row) { 263*544dca1bSAnna Dabrowska list($pid, $rid, $rev, $colref, $rowno, $fixes) = $this->getFixedValues($row); 264*544dca1bSAnna Dabrowska // now fix the values 265*544dca1bSAnna Dabrowska if (!empty($fixes)) { 266*544dca1bSAnna Dabrowska $sql = "UPDATE data_$name SET " . implode(', ', $fixes) . " WHERE pid = ? and rid = ? AND rev = ?"; 267*544dca1bSAnna Dabrowska $params = [$pid, $rid, $rev]; 268*544dca1bSAnna Dabrowska $ok = $ok && $sqlite->query($sql, $params); 269*544dca1bSAnna Dabrowska } 270*544dca1bSAnna Dabrowska } 271*544dca1bSAnna Dabrowska } 272*544dca1bSAnna Dabrowska 273*544dca1bSAnna Dabrowska // multi_ tables 274*544dca1bSAnna Dabrowska $s = "SELECT colref, pid, rid, rev, row, value FROM multi_$name"; 275*544dca1bSAnna Dabrowska $res = $sqlite->query($s); 276*544dca1bSAnna Dabrowska $allValues = $sqlite->res2arr($res); 277*544dca1bSAnna Dabrowska 278*544dca1bSAnna Dabrowska if (!empty($allValues)) { 279*544dca1bSAnna Dabrowska foreach ($allValues as $row) { 280*544dca1bSAnna Dabrowska list($pid, $rid, $rev, $colref, $rowno, $fixes) = $this->getFixedValues($row); 281*544dca1bSAnna Dabrowska // now fix the values 282*544dca1bSAnna Dabrowska if (!empty($fixes)) { 283*544dca1bSAnna Dabrowska $sql = "UPDATE multi_$name SET " . implode(', ', $fixes) . " WHERE pid = ? AND rid = ? AND rev = ? AND colref = ? AND row = ?"; 284*544dca1bSAnna Dabrowska $params = [$pid, $rid, $rev, $colref, $rowno]; 285*544dca1bSAnna Dabrowska $ok = $ok && $sqlite->query($sql, $params); 286*544dca1bSAnna Dabrowska } 287*544dca1bSAnna Dabrowska } 288*544dca1bSAnna Dabrowska } 289*544dca1bSAnna Dabrowska } 290*544dca1bSAnna Dabrowska } 291*544dca1bSAnna Dabrowska 292*544dca1bSAnna Dabrowska if (!$ok) { 293*544dca1bSAnna Dabrowska $sqlite->query('ROLLBACK TRANSACTION'); 294*544dca1bSAnna Dabrowska return false; 295*544dca1bSAnna Dabrowska } 296*544dca1bSAnna Dabrowska $sqlite->query('COMMIT TRANSACTION'); 297*544dca1bSAnna Dabrowska return true; 298*544dca1bSAnna Dabrowska } 299*544dca1bSAnna Dabrowska 300*544dca1bSAnna Dabrowska /** 301*544dca1bSAnna Dabrowska * Returns a select statement to fetch Lookup columns in the current schema 302*544dca1bSAnna Dabrowska * 303*544dca1bSAnna Dabrowska * @param int $sid Id of the schema 304*544dca1bSAnna Dabrowska * @return string SQL statement 305*544dca1bSAnna Dabrowska */ 306*544dca1bSAnna Dabrowska protected function getLookupColsSql($sid) 307*544dca1bSAnna Dabrowska { 308*544dca1bSAnna Dabrowska return "SELECT C.colref AS COL, T.class AS TYPE 309*544dca1bSAnna Dabrowska FROM schema_cols AS C 310*544dca1bSAnna Dabrowska LEFT OUTER JOIN types AS T 311*544dca1bSAnna Dabrowska ON C.tid = T.id 312*544dca1bSAnna Dabrowska WHERE C.sid = $sid 313*544dca1bSAnna Dabrowska AND TYPE LIKE '%Lookup' 314*544dca1bSAnna Dabrowska "; 315*544dca1bSAnna Dabrowska } 316*544dca1bSAnna Dabrowska 317*544dca1bSAnna Dabrowska /** 318*544dca1bSAnna Dabrowska * Checks for improperly migrated values and returns an array with 319*544dca1bSAnna Dabrowska * "<column> = <fixed-value>" fragments to be used in the UPDATE statement. 320*544dca1bSAnna Dabrowska * 321*544dca1bSAnna Dabrowska * @param array $row 322*544dca1bSAnna Dabrowska * @return array 323*544dca1bSAnna Dabrowska */ 324*544dca1bSAnna Dabrowska protected function getFixedValues($row) 325*544dca1bSAnna Dabrowska { 326*544dca1bSAnna Dabrowska $pid = $row['pid']; 327*544dca1bSAnna Dabrowska $rid = $row['rid']; 328*544dca1bSAnna Dabrowska $rev = $row['rev']; 329*544dca1bSAnna Dabrowska $colref = $row['colref']; 330*544dca1bSAnna Dabrowska $rowno = $row['row']; 331*544dca1bSAnna Dabrowska $fixes = []; 332*544dca1bSAnna Dabrowska $matches = []; 333*544dca1bSAnna Dabrowska 334*544dca1bSAnna Dabrowska // check if anything needs to be fixed in data columns 335*544dca1bSAnna Dabrowska foreach ($row as $col => $value) { 336*544dca1bSAnna Dabrowska if (in_array($col, ['pid', 'rid', 'rev', 'colref', 'row'])) { 337*544dca1bSAnna Dabrowska continue; 338*544dca1bSAnna Dabrowska } 339*544dca1bSAnna Dabrowska preg_match('/^\["",(?<pid>.*?\D+.*?)\]$/', $value, $matches); 340*544dca1bSAnna Dabrowska if (!empty($matches['pid'])) { 341*544dca1bSAnna Dabrowska $fixes[$col] = '["' . $matches['pid'] . '",0]'; 342*544dca1bSAnna Dabrowska } 343*544dca1bSAnna Dabrowska } 344*544dca1bSAnna Dabrowska 345*544dca1bSAnna Dabrowska if (!empty($fixes)) { 346*544dca1bSAnna Dabrowska $fixes = array_map(function ($set, $key) { 347*544dca1bSAnna Dabrowska return "$key = '$set'"; 348*544dca1bSAnna Dabrowska }, $fixes, array_keys($fixes)); 349*544dca1bSAnna Dabrowska } 350*544dca1bSAnna Dabrowska 351*544dca1bSAnna Dabrowska return [$pid, $rid, $rev, $colref, $rowno, $fixes]; 352*544dca1bSAnna Dabrowska } 3538f259467SAndreas Gohr} 354