Searched hist:"2 bde879a12352d26be5e3f11e86855f463734d2d" (Results 1 – 3 of 3) sorted by relevance
| /dokuwiki/_test/tests/Ui/ |
| H A D | PageDiffTest.php | 2bde879a12352d26be5e3f11e86855f463734d2d Sun Jun 07 10:17:48 UTC 2026 Andreas Gohr <andi@splitbrain.org> Fix diff view comparing a deleted page with itself (#4635)
When opening the diff of a deleted page without explicit rev parameters
(?do=diff), Diff::handle() resolved the older side via getRevisions(0, 1).
That helper only skips the current revision when the item file still
exists, so for a deleted page it returned the deletion entry itself and
the view ended up comparing the current revision with itself ("no way to
compare when less than two revisions", empty diff).
Use getRelativeRevision($rev2, -1) instead, which returns the revision
immediately before the current one regardless of whether the page file
is still present. This covers both pages deleted through DokuWiki and
externally deleted pages (whose synthesized deletion entry is now
persisted to the changelog).
Add PageDiffTest and PageChangeLogTest covering the resolved revision
pair and the underlying changelog walk-back for both deletion kinds.
|
| /dokuwiki/_test/tests/ChangeLog/ |
| H A D | PageChangeLogTest.php | 2bde879a12352d26be5e3f11e86855f463734d2d Sun Jun 07 10:17:48 UTC 2026 Andreas Gohr <andi@splitbrain.org> Fix diff view comparing a deleted page with itself (#4635)
When opening the diff of a deleted page without explicit rev parameters
(?do=diff), Diff::handle() resolved the older side via getRevisions(0, 1).
That helper only skips the current revision when the item file still
exists, so for a deleted page it returned the deletion entry itself and
the view ended up comparing the current revision with itself ("no way to
compare when less than two revisions", empty diff).
Use getRelativeRevision($rev2, -1) instead, which returns the revision
immediately before the current one regardless of whether the page file
is still present. This covers both pages deleted through DokuWiki and
externally deleted pages (whose synthesized deletion entry is now
persisted to the changelog).
Add PageDiffTest and PageChangeLogTest covering the resolved revision
pair and the underlying changelog walk-back for both deletion kinds.
|
| /dokuwiki/inc/Ui/ |
| H A D | Diff.php | 2bde879a12352d26be5e3f11e86855f463734d2d Sun Jun 07 10:17:48 UTC 2026 Andreas Gohr <andi@splitbrain.org> Fix diff view comparing a deleted page with itself (#4635)
When opening the diff of a deleted page without explicit rev parameters
(?do=diff), Diff::handle() resolved the older side via getRevisions(0, 1).
That helper only skips the current revision when the item file still
exists, so for a deleted page it returned the deletion entry itself and
the view ended up comparing the current revision with itself ("no way to
compare when less than two revisions", empty diff).
Use getRelativeRevision($rev2, -1) instead, which returns the revision
immediately before the current one regardless of whether the page file
is still present. This covers both pages deleted through DokuWiki and
externally deleted pages (whose synthesized deletion entry is now
persisted to the changelog).
Add PageDiffTest and PageChangeLogTest covering the resolved revision
pair and the underlying changelog walk-back for both deletion kinds.
|