en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#8407f251434f578d07231a3f252ce6276d9e0b05 �� Rector and PHPCS fixes List of files: /dokuwiki/inc/Search/Indexer.php Mon, 02 Dec 2024 13:22:00 +0000 splitbrain <86426+splitbrain@users.noreply.github.com> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#0f7af8fc15eb9fba16bfb0870949756495d96a36 replace E_USER_ERROR triggers with RuntimeExceptionsThe use of trigger_error with a E_USER_ERROR is deprecated in PHP 8.4 List of files: /dokuwiki/inc/Search/Indexer.php Mon, 25 Nov 2024 09:23:59 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#6c16a3a9aa602bb7e269fb6d5d18e1353e17f97f Use str_starts_with/str_ends_with List of files: /dokuwiki/inc/Search/Indexer.php Thu, 14 Sep 2023 20:32:18 +0000 fiwswe <fiwswe@fwml.de> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#90fb952c4c30c09c8446076ba05991c89a3f0b01 code style: operator spacing List of files: /dokuwiki/inc/Search/Indexer.php Thu, 31 Aug 2023 20:38:07 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#7d34963b3e75ea04c63ec066a6b7a692e123cb53 coding style: control flow line breaks List of files: /dokuwiki/inc/Search/Indexer.php Thu, 31 Aug 2023 13:04:10 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#177d6836e2f75d0e404be9c566e61725852a1e07 coding style: control flow whitespaces List of files: /dokuwiki/inc/Search/Indexer.php Thu, 31 Aug 2023 12:22:35 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#a19c9aa0217112e3ab7ebc160354c7e9fbabe8eb recover comments in list List of files: /dokuwiki/inc/Search/Indexer.php Wed, 30 Aug 2023 22:25:09 +0000 Gerrit Uitslag <klapinklapin@gmail.com> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#dccd6b2bba7367e4d1d2d7aa84c9f9d15584b593 coding style: function call spacing List of files: /dokuwiki/inc/Search/Indexer.php Wed, 30 Aug 2023 16:41:45 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#b2c8ab476900a0c31b68ef5eed3749ec674892e2 coding style: loop declaration spacing List of files: /dokuwiki/inc/Search/Indexer.php Wed, 30 Aug 2023 16:27:09 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#d868eb89f182718a31113373a6272670bd7f8012 codestyle adjustments: function declaration braces/spaces List of files: /dokuwiki/inc/Search/Indexer.php Wed, 30 Aug 2023 15:09:14 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#8c7c53b0321a3cd3116b8d3b2ad27863a38dece7 codestyle adjustments: class declaration braces List of files: /dokuwiki/inc/Search/Indexer.php Wed, 30 Aug 2023 15:05:28 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#c1482d1c08360e6401534a1391da2b650c37d34d codestyle adjustments: function argument spacing List of files: /dokuwiki/inc/Search/Indexer.php Wed, 30 Aug 2023 15:03:06 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#24870174d2ee45460ba6bcfe5f5a0ae94715efd7 Apply rector fixes to the rest of inc List of files: /dokuwiki/inc/Search/Indexer.php Tue, 29 Aug 2023 17:42:15 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#ac1d8211a02511d00e948b75442a262b0e2fc39a fix some php 8.2 deprecation warnings List of files: /dokuwiki/inc/Search/Indexer.php Sun, 19 Mar 2023 20:11:05 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#173de31c3bf14853cb70e707959ba525db668eb4 Avoid some unnecessary index file writes.word_idx modified should be reset to false for each word index file, or all unchanged word index files after the first changed one will be resaved unnecessarily. List of files: /dokuwiki/inc/Search/Indexer.php Tue, 24 Jan 2023 03:35:17 +0000 Moritz Raguschat <moritz.raguschat@web.de> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#bd5391243cdd92d9e0abee5ba1a506170b18d072 :fire: fix the calculation of file permissonsOur config allows to set the values for `dmode` and `fmode` to allowusers to explicitly define which permissions directories and filesshould have.To avoid unnessary chmod operations, we check the current umask tocompare what permissions files and directories would get witout ourintervention. If the result is already what the user wants, no chmodswill happen later on. Otherwise we set new configs called `dperm` and`fperm` which will be used in chmod ops. This is done in`init_creationmodes()`When we created new directories, we used to pass the original `dmode`config to `mkdir()`. The system will then apply the umask to that`dmode`.This means the resulting directory will *always* have differentpermissions than `dmode`, *always* requiring a chmod operation.That's silly.**Breaking Change:** This patch removes the passing of `dmode` assecond parameter to all `mkdir` calls, making it default to `0700`which is also what we test against in `init_creationmodes()`.Plugins not relying on our `io_*` functions and do create their owndirectories and which currenlty pass `dmode` to it need to beadjusted to remove that second parameter.Users may want to reapply the proper file permissions to their datafolder.**Revert:** In 9fdcc8fcd87114ca59a1764a84d213a53c655c8c @movaticaintroduced a change to `init_creationmodes()` that compared the umaskagainst `fmode` instead of `0666`. I merged it because it looked logicalwhen compared to the code for directories which compared against `dmode`as described above. However we do not pass `fmode` to any file creationmethods (that's not possible).The result is that all changes made in the `fmode` setting resultedin the wrong permissions for newly created files as first reported inhttps://forum.dokuwiki.org/d/19463-setting-fmode-not-working-as-intendedI'm unsure about the orginal motivation behind @movatica's change. The"fix" however, is wrong.**Tests:** This patch introduces an integration test that will check theactual results of directory and file creations under various umask,`dmode` and `fmode` settings. List of files: /dokuwiki/inc/Search/Indexer.php Sat, 14 Aug 2021 09:06:31 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#7c3926398e2471c5ab02c0fbae2fa8ab7c9f7e68 Fix Undefined array key in Search/Indexer.php List of files: /dokuwiki/inc/Search/Indexer.php Wed, 27 Jan 2021 00:59:43 +0000 Damien Regad <dregad@mantisbt.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#23420346128e0894d85f8475f8e0488fb80cdb24 Fix Undefined array key "fperm" warningAlso removed a few, now unnecessary `!empty` checksFixes #3382 List of files: /dokuwiki/inc/Search/Indexer.php Tue, 26 Jan 2021 12:43:49 +0000 Damien Regad <dregad@mantisbt.org> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#3aa75874971939d1a5fde5d5cbca46695cb03af3 Fixed inconsistent handling of falsy values on fperm settingThe $conf['fperm'] value was checked in multiple files using different methods.This can cause permission trouble with restricted environments, i.e. when chmod is forbidden and file permissions are non-default.Now, all checks use implicit cast to boolean which leads to consistent behaviour.Also, a misleading variable was renamed in context to better understand one of the checks. List of files: /dokuwiki/inc/Search/Indexer.php Tue, 18 Feb 2020 18:29:53 +0000 movatica <c0d3@movatica.com> http://127.0.0.1:8080/history/dokuwiki/inc/Search/Indexer.php#6225b270e09ba8d1cb10e70c9cbdbd0fe690c253 Extract dokuwiki\Search\Indexer classNot sure why Doku_Indexer caused phpcs to complain about the class namenot being in PascalCase, but Doku_Handler didn't. ��The namespace and new class name was selected to be compatible with theupcoming changes in #2943. This should hpopefully reduce the overallhassle of touching the same code base. List of files: /dokuwiki/inc/Search/Indexer.php Sat, 28 Dec 2019 23:52:19 +0000 Michael Große <mic.grosse@googlemail.com>