en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/inc/Parsing/ParserMode/GfmHr.php#47a02a102092be9e1e6f1ddaf158bdfffdb13d4f Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/inc/Parsing/ParserMode/GfmHr.php Thu, 04 Jun 2026 12:27:59 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/inc/Parsing/ParserMode/GfmHr.php#13a62f810fbd091d15ab734b467eaec0a6bf829a rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'Symmetry with the existing 'dw+md' / 'md+dw' setting values. List of files: /dokuwiki/inc/Parsing/ParserMode/GfmHr.php Mon, 04 May 2026 10:18:11 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Parsing/ParserMode/GfmHr.php#3e6baeff313fa406e4d4b5dd2e5ab85ec7d7816d replace DW Hr with unified GfmHrSingle mode covers both DokuWiki (4+ dashes) and GFM (3+ of -/*/_)horizontal rules; pattern self-narrows on $conf['syntax']. Alwaysloaded across all four syntax settings, mirroring the GfmQuotereplacement pattern. Same `hr` handler call so renderers and thecall API are unchanged.Drops DW's old [ \t]* leading-whitespace tolerance — inert inpractice past 0-1 spaces (Preformatted at sort 20 interceptseverything ≥ 2 spaces or any tab).Spec examples 13, 20, 26-28, 224 turn green; 17, 21-24, 29, 30, 31go to skip.php as deliberate non-implementations (whitespacetolerance and list-precedence cases). List of files: /dokuwiki/inc/Parsing/ParserMode/GfmHr.php Thu, 30 Apr 2026 13:14:27 +0000 Andreas Gohr <andi@splitbrain.org>