Changes in GfmEscape.php

47a02a102092be9e1e6f1ddaf158bdfffdb13d4f - Parsing: make parse syntax a per-parse value, drop ModeInterface

Thu, 04 Jun 2026 12:27:59 +0000

Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/inc/Parsing/ParserMode/GfmEscape.php

65dd2042806255b56d4cf303530fd396ff38f151 - GfmEscape: defer \\ to DW Linebreak in mixed-syntax modes

Tue, 26 May 2026 19:27:33 +0000

GfmEscape: defer \\ to DW Linebreak in mixed-syntax modesBoth GfmEscape (sort 5) and DW Linebreak (sort 140) can claim thetwo backslashes of `\\` followed by space/tab/newline. The lexer'stie-breaker picked GfmEscape, so DW's forced linebreak silently lostits delimiter under dw+md and md+dw. Add a negative lookahead thatdeclines `\\[ \t\n]` whenever DW syntax is loaded — pure md keepsGFM-spec behavior. Mid-line `\\` (UNC paths etc.) still escapes. List of files: /dokuwiki/inc/Parsing/ParserMode/GfmEscape.php

d331a8396503a69ec91cd77124b1b8983c251c54 - GFM modes: follow CATEGORY_SUBSTITION → CATEGORY_SUBSTITUTION rename

Tue, 12 May 2026 14:12:38 +0000

GFM modes: follow CATEGORY_SUBSTITION → CATEGORY_SUBSTITUTION renameConstant was renamed on master (the typo'd 'substition' value is kept,but the constant name spells it correctly). Update GfmTable's use ofthe constant, plus stale docblock/comment references in GfmEscape,GfmHtmlEntity, GfmLinebreak, and GfmLinebreakTest. List of files: /dokuwiki/inc/Parsing/ParserMode/GfmEscape.php

74031e463764923581b9204cebc0fc3f34ce881f - add GfmEscape for GFM backslash escapes

Tue, 28 Apr 2026 17:08:30 +0000

add GfmEscape for GFM backslash escapesImplements GFM §6.1 backslash-escape handling. GfmEscape is a sort-5inline mode in CATEGORY_SUBSTITION that claims `\X` for any escapableASCII punctuation char before competing delimiters can match. Theshared character class lives on Helpers\Escape so the lexer patternand the post-hoc unescape stay in lockstep.Whole-span captures (GfmCode info string, GfmLink label/URL) bypassthe lexer; those modes call Escape::unescapeBackslashes() on therelevant slot. GfmLink skips the unescape when the URL classifies asa windowssharelink so the leading \\host survives intact.GfmTable cells get a separate per-cell `\|` to `|` pass in therewriter to honour the tables-extension rule that pipes alwaysunescape, even inside code spans where standard §6.1 escapes don'tfire. List of files: /dokuwiki/inc/Parsing/ParserMode/GfmEscape.php