Changes in Externallink.php

47a02a102092be9e1e6f1ddaf158bdfffdb13d4f - Parsing: make parse syntax a per-parse value, drop ModeInterface

Thu, 04 Jun 2026 12:27:59 +0000

Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

15429f02faae079ee2b0d8112fedf410ca65d9f2 - Externallink: GFM autolink extension - parens and entity-ref tail

Tue, 12 May 2026 14:03:56 +0000

Externallink: GFM autolink extension - parens and entity-ref tailIn Markdown-preferred mode, allow `(` and `)` inside URL char classesand consume an optional trailing entity reference via the sharedHtmlEntity::PATTERN. The Markdown-only post-processing peels offmismatched closing parens and decodes the trailing entity reference,emitting the peeled chars as cdata after the link. Refactors handle()to dispatch to handleAngleAutolink() and handleBareUrl(), with the newtrim logic in peelGfmTail() and the protocol-prefix step inaddProtocolPrefix(). DW-only mode behavior is unchanged.Brings GFM spec examples #624, #625, #626 to passing. List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

f9d3b7bd008099dc4c61ce262a02a0ed8bc94254 - Externallink: add per-scheme angle-bracket autolinks for MD syntax

Tue, 05 May 2026 14:16:44 +0000

Externallink: add per-scheme angle-bracket autolinks for MD syntaxAdds CommonMark §6.5 autolinks to Externallink, gated tomd/md+dw/dw+md syntax via ModeRegistry::isMdPreferred(). Per-schemepatterns share the existing conf/scheme.conf allow-list so unknownschemes fall through to literal cdata instead of being silentlydropped by the renderer. Internal whitespace inside the bracketsdisqualifies the autolink and the whole envelope is emitted ascdata to keep the bare-URL detector off the URL.LinksTest gains 5 cases covering success, internal-whitespace andleading-whitespace disqualification, unregistered scheme fallthrough,and the dw-only no-op path. SpecCompatRenderer URL encoder is updatedto match cmark-gfm's HREF_SAFE table (square brackets and a few othercharacters move from safe to encoded). skip.php loses the obsolete#356 entry and gains #605/#606/#607/#609 explaining the unregistered-scheme cases that the per-scheme regex naturally rejects. List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

71096e46fcbfaeaa808667aba794e77fe2780169 - move handler methods into ParserMode classes and rename Handler

Sat, 18 Apr 2026 15:35:30 +0000

move handler methods into ParserMode classes and rename HandlerEach ParserMode class now implements handle() from ModeInterface,containing the token handling logic that previously lived as individualmethods on Doku_Handler.The Handler class (formerly Doku_Handler) is the single dispatch point:Lexer passes tokens to Handler::handleToken() which routes to modeobjects, plugins, or returns false. The Lexer only tokenizes andresolves mapHandler aliases.Key changes:- Add handle() to ModeInterface, implemented by all mode classes- Move Doku_Handler to dokuwiki\Parsing\Handler namespace- File extends Code (shared parsing via $type property)- Quotes uses mapHandler() + Handler::getModeName() for sub-modes- Media::parseMedia() replaces Doku_Handler_Parse_Media()- Code::parseHighlightOptions() replaces parse_highlight_options()- Per-parse state (footnote, doublequote) stays on Handler- Deprecated wrappers kept for base/header/internallink/media- Class alias and rector rules added for backward compatibility List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

90fb952c4c30c09c8446076ba05991c89a3f0b01 - code style: operator spacing

Thu, 31 Aug 2023 20:38:07 +0000

code style: operator spacing List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

bcaec9f47d06126b3e653fea89a86d8b6a6cbef8 - Apply rector fixes to inc/Parsing

Tue, 29 Aug 2023 16:14:40 +0000

Apply rector fixes to inc/Parsing List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

206d3a69f56a6436df591e9818f4ec81de068734 - Merge pull request #2433 from splitbrain/issue2399

Tue, 13 Oct 2020 11:10:58 +0000

Merge pull request #2433 from splitbrain/issue2399Fixed broken link rendering for external links at start of line List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

5c99934fa496e741110e47e8fd4d9ef528851259 - Public access to patterns in external link parser

Wed, 12 Aug 2020 07:53:38 +0000

Public access to patterns in external link parser List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

4da6a3ce612d972b13310df55b55ba30a32071b6 - Fix php styling of too long regexp

Tue, 10 Mar 2020 00:42:56 +0000

Fix php styling of too long regexp List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

f216edae611a9a1677577709a8b2e33f231b6a7d - Fixed broken link rendering for external links at start of line

Thu, 21 Jun 2018 19:20:36 +0000

Fixed broken link rendering for external links at start of lineExternal links at the start of line like 'www.example.com' werenot rendered as links any more. The issue was introduced with PR #1988.Fixes #2399. List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php

be906b566b9bdfd92c032ee07c4fd077d820a8d1 - moved all parsing related namespaces to their own

Fri, 04 May 2018 12:22:09 +0000

moved all parsing related namespaces to their own List of files: /dokuwiki/inc/Parsing/ParserMode/Externallink.php