Changes in Deleted.php

1c00c02121477c81b95fe750b94acdf109cba20a - fix(parser): validate inline formatting closers with a single memoized scan

Thu, 09 Jul 2026 12:09:52 +0000

fix(parser): validate inline formatting closers with a single memoized scanThe inline formatting modes only open a span when a valid closer existsahead. That check was a lookahead built on CONTENT_UNTIL_PARA, testedcharacter by character up to the next paragraph break and re-evaluatedfrom scratch for every opener candidate — openers times paragraphlength. With pcre.jit=0 a crafted 32KB page took 16s and an ordinary34KB page with long paragraphs 37s; with the JIT on (the PHP default)the per-character lookahead exhausted the JIT stack, the match silentlyfailed, and the formatting — or everything after it — rendered as plaintext.The check also decided the wrong thing. It scanned raw text, so a closerlookalike inside content the lexer consumes atomically — a nowiki or %%span, a backtick code span, a link, a URL — counted as a real closereven though the mode's exit pattern can never fire there. And it ignoredthe enclosing span: an inner delimiter whose only closer lay past thecloser of the mode it sits in was entered anyway, so a stray delimiterpaired with one in a following sibling span and dragged the boundaryalong — the `*` in ''glob/*.conf'' joined the `*` of the next ''...''span and corrupted the paragraph; the same held for //, ** and __ insidemonospace, and an emphasis opened inside ((...)) ran past the footnote's)) and the enclosing bold's **.Each formatting mode now declares its closer throughLexer::addCloserPattern(), mirroring addExitPattern(), and the lexeranswers "does a valid closer exist ahead" with one anchored possessivescan per range instead of a lookahead per opener:- The scan runs left to right from the opener, hopping over opaque spans derived from already-registered patterns — a plain or special match is consumed in one step, an entry into a verbatim mode (nowiki, the backtick code spans) extends to that mode's first exit — so a closer lookalike inside consumed content is never mistaken for a closer. Each hop finds the earliest of boundary, closer, or opaque span in a single leftmost search, keeping the check linear.- An opener is rejected when the nearest enclosing mode that has a closer of its own would close before the opener's own closer, so a delimiter that can never close within its span stays literal. That ancestor is found by walking the mode stack past modes that declare no closer (plugins, footnotes); the nearest guarded ancestor suffices, as it was itself validated against its own when it opened.- Both verdicts are memoized and reset per parse() run: a proven closer validates every earlier candidate, and a proven closer-free range rejects every later candidate before the next boundary. With the lexer consuming each opened span, the whole parse is linear in document size.Closer patterns match the closing delimiter itself with flanking contextin lookarounds — the convention exit patterns already follow — so closerpositions compare exactly across modes and a closer directly after aninner opener is seen. AbstractFormatting derives the closer from the exitpattern and registers it with the paragraph break as the boundary,preserving the rule that formatting never spans paragraphs; a mode withother needs can pass a different boundary or none.Footnote declares its )) as a closer rather than guarding its (( entrywith a (?=.*)) lookahead, so the footnote becomes a boundary the scansees and formatting inside it no longer pairs across the )); its closertakes no paragraph boundary, as footnotes are block-level. GfmEmphasisgains a closer pattern so single * emphasis is validated the same way,while its entry lookahead still enforces CommonMark nearest-delimiterpairing. GfmEmphasis and GfmStrong span bodies cannot contain theirdelimiter, so their in-pattern lookaheads stay linear on their own; theGFM backtick span bodies get deterministic alternatives with possessivequantifiers, removing their per-character backtracking.CONTENT_UNTIL_PARA is removed: any entry pattern built with it recreatesthe quadratic scan. ParallelRegex gains escapePattern() so embeddedcloser fragments follow the lexer's bare-parenthesis convention, reportsPREG_JIT_STACKLIMIT_ERROR so a future JIT exhaustion surfaces instead ofsilently truncating, and no longer rewrites its registered patterns inplace while compiling the compound regex.The adversarial 32KB page drops to 0.1s, the 37-second benign page to0.1s, and a 128KB variant stays under 0.6s. List of files: /dokuwiki/inc/Parsing/ParserMode/Deleted.php

c3755410ab98ca2a05ee21de7b0df40f38c6a879 - require non-whitespace adjacency for inline formatting delimiters

Mon, 20 Apr 2026 17:25:53 +0000

require non-whitespace adjacency for inline formatting delimitersAn opening delimiter must now be followed by a non-whitespace character,and a closing delimiter must be preceded by one. Empty delimiter pairs(****, ____, '''', , , ) no longermatch and stay literal.Rationale: this matches Markdown's flanking-delimiterrules and eliminates accidental bolding of sequences like `** note**`at the start of a sentence. Well-formed uses (**bold**, //italic//,__underline__) are unchanged.Affected modes: Strong, Emphasis, Underline, Monospace, Subscript,Superscript, Deleted.BREAKING: content that was already malformed butpreviously rendered as formatted (e.g. `**foo bar **`) now staysliteral. List of files: /dokuwiki/inc/Parsing/ParserMode/Deleted.php

10fb3d6558c6f13ffaca18fede92dbc37fe3ede0 - prevent inline formatting from matching across paragraph boundaries

Mon, 20 Apr 2026 13:12:57 +0000

prevent inline formatting from matching across paragraph boundariesThe Lexer compiles all patterns with the `s` (DOTALL) flag viaParallelRegex::getPerlMatchingFlags(), which makes `.` match newlines.Inline formatting modes use lookaheads like `\*\*(?=.*\*\*)` to verifya closing delimiter exists, so with DOTALL a lone `**` happily matchedits "closer" many paragraphs later, swallowing blank lines into asingle run.Add CONTENT_UNTIL_PARA on AbstractMode — a regex snippet matching anycharacter unless it would start a paragraph break (blank line, possiblywith horizontal whitespace). Update all inline formatting entry patterns(Strong, Emphasis, Underline, Monospace, Subscript, Superscript,Deleted) to use it in their closing-delimiter lookaheads.Emphasis also gets a real closing-`//` check; its previous lookaheadjust verified "content exists with a non-colon char" without requiringthe closing delimiter at all.Single newlines inside a delimiter pair still match (multi-lineformatting); only blank lines end it.BREAKING: This means you no longer can mark multiple paragraphs as boldor strike them out. On the other hand it prevents accidentally breakingthe page layout by missing a closing delimiter (as reported many manytimes over the years) eg. #1025 #3588 #1056 List of files: /dokuwiki/inc/Parsing/ParserMode/Deleted.php

71096e46fcbfaeaa808667aba794e77fe2780169 - move handler methods into ParserMode classes and rename Handler

Sat, 18 Apr 2026 15:35:30 +0000
move handler methods into ParserMode classes and rename HandlerEach ParserMode class now implements handle() from ModeInterface,containing the token handling logic that previously lived as individualmethods on Doku_Handler.The Handler class (formerly Doku_Handler) is the single dispatch point:Lexer passes tokens to Handler::handleToken() which routes to modeobjects, plugins, or returns false. The Lexer only tokenizes andresolves mapHandler aliases.Key changes:- Add handle() to ModeInterface, implemented by all mode classes- Move Doku_Handler to dokuwiki\Parsing\Handler namespace- File extends Code (shared parsing via $type property)- Quotes uses mapHandler() + Handler::getModeName() for sub-modes- Media::parseMedia() replaces Doku_Handler_Parse_Media()- Code::parseHighlightOptions() replaces parse_highlight_options()- Per-parse state (footnote, doublequote) stays on Handler- Deprecated wrappers kept for base/header/internallink/media- Class alias and rector rules added for backward compatibility List of files: /dokuwiki/inc/Parsing/ParserMode/Deleted.php

1f44347694a1b2d0182a0aaa0ca79ba9930f1d2a - split Formatting into individual classes per formatting type

Thu, 16 Apr 2026 16:17:15 +0000
split Formatting into individual classes per formatting typeIntroduce AbstractFormatting as a base class and seven concreteclasses (Strong, Emphasis, Underline, Monospace, Subscript,Superscript, Deleted) that each define their own patterns andsort order. Delete the old Formatting class and update teststo use the new classes directly. ModeRegistry now treatsformatting modes as regular built-in modes. List of files: /dokuwiki/inc/Parsing/ParserMode/Deleted.php