Changes in AbstractListsRewriter.php

e7dae73bcd947f44c901faaac9dd45de67633a3b - fix: apply rector and code sniffer fixes

Tue, 12 May 2026 14:24:43 +0000

fix: apply rector and code sniffer fixes List of files: /dokuwiki/inc/Parsing/Handler/AbstractListsRewriter.php

f7c6e4acc95e3c5c24a819b2149a2bf3a7668f11 - add listo_open_start sibling method for GFM start numbers

Thu, 30 Apr 2026 08:11:04 +0000

add listo_open_start sibling method for GFM start numbersReverts the listo_open signature widening from 5a2118acc and insteadadds a sibling method `listo_open_start($start = 1)` on the rendererhierarchy. The base default delegates to listo_open() so renderersthat don't override it still produce a valid (but unnumbered) list;xhtml's override emits

rule. List of files: /dokuwiki/inc/Parsing/Handler/AbstractListsRewriter.php

bf6e4f0d2bea6ff572294f3280faef71d44e0917 - extract AbstractListsRewriter from Lists

Tue, 28 Apr 2026 06:21:05 +0000

extract AbstractListsRewriter from ListsThe list-block CallWriter rewriter mixed two concerns: a shared statemachine that turns flat list_open / list_item / list_close calls intothe nested listu_open / listo_open / listitem / listcontent shapethe renderers expect, and a syntax-specific marker parser that mapsthe captured indent + marker text to depth/type.Hoist the state machine onto a new abstract base classAbstractListsRewriter; Lists keeps only its DokuWiki marker parser(`*` unordered, `-` ordered, 2-space-per-level indent). The upcomingGfmLists will share the same base class with its own GFM markerparser.The interpretSyntax contract changes shape: protected function interpretSyntax($match, &$type): intto abstract protected function interpretSyntax(string $match): array; // returns ['depth' => int, 'type' => 'u'|'o', 'start'? => int]The optional `start` key carries the first ordered item's number forsyntaxes that support it (GFM); DokuWiki omits it and gets thedefault of 1. Plugins subclassing Lists that override interpretSyntaxneed to update — known affected: creole, markdowku, mediasyntax (percodesearch.dokuwiki.org). The migration is mechanical: replace theby-ref $type assignment and int return with an associative-arrayreturn.The protected listStart / listOpen / listEnd dispatch methods on theold Lists are gone (renamed handleListOpen / handleListItem /handleListClose on the base class), but no plugin in the ecosystemoverrides those, only interpretSyntax. List of files: /dokuwiki/inc/Parsing/Handler/AbstractListsRewriter.php