en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#47a02a102092be9e1e6f1ddaf158bdfffdb13d4f Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Thu, 04 Jun 2026 12:27:59 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#71096e46fcbfaeaa808667aba794e77fe2780169 move handler methods into ParserMode classes and rename HandlerEach ParserMode class now implements handle() from ModeInterface,containing the token handling logic that previously lived as individualmethods on Doku_Handler.The Handler class (formerly Doku_Handler) is the single dispatch point:Lexer passes tokens to Handler::handleToken() which routes to modeobjects, plugins, or returns false. The Lexer only tokenizes andresolves mapHandler aliases.Key changes:- Add handle() to ModeInterface, implemented by all mode classes- Move Doku_Handler to dokuwiki\Parsing\Handler namespace- File extends Code (shared parsing via $type property)- Quotes uses mapHandler() + Handler::getModeName() for sub-modes- Media::parseMedia() replaces Doku_Handler_Parse_Media()- Code::parseHighlightOptions() replaces parse_highlight_options()- Per-parse state (footnote, doublequote) stays on Handler- Deprecated wrappers kept for base/header/internallink/media- Class alias and rector rules added for backward compatibility List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Sat, 18 Apr 2026 15:35:30 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#c8dd1b9d24a2f9905db764a0ac4646fb1e172af4 introduce ModeRegistry to encapsulate parser mode categoriesReplace the global $PARSER_MODES definition in inc/parser/parser.phpwith a ModeRegistry singleton that initializes and manages the modecategories. The global array is still populated for backwardcompatibility with plugins that access it directly.Mode constructors now use ModeRegistry::getModesForCategories()instead of accessing the global directly. p_get_parsermodes() andp_sort_modes() are moved to inc/deprecated.php as thin wrappers. List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Thu, 16 Apr 2026 15:51:43 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#093fe67e98c0cdb4b73fd46938e49b64971483c2 updated rector and applied it List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Sat, 07 Mar 2026 20:26:13 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#efc3ac2fcd39bc94335ef5905e6d623f54944687 �� Rector and PHPCS fixes List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Thu, 07 Sep 2023 12:24:31 +0000 splitbrain <splitbrain@users.noreply.github.com> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#e6a82646f2de00d42f662031fafa7171f8513f01 fix syntax plugin loadingIt turns out our Syntax plugins never implemented the PluginInterface(though they did use the PluginTrait). With our stricter type checkingin the plugin loader, these plugins did not longer load. List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Sun, 03 Sep 2023 16:32:51 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#1490c177a0ca4ece26d483758a02b2f93a1441e0 Apply rector fixes to inc/Extension and inc/Debug List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Tue, 29 Aug 2023 12:15:12 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#903d43fe60f76e180b5d8ef35db7007bee2a8e5e Check code style against PSR12In 2019 PSR-12 was officially released and PSR-2 deprecated. We shouldadapt to that and check our files against that new coding standard. List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Tue, 31 Dec 2019 11:15:25 +0000 Michael Große <mic.grosse@googlemail.com> http://127.0.0.1:8080/history/dokuwiki/inc/Extension/SyntaxPlugin.php#e1d9dcc8b460b6f029ac9c8d5d3b8d23b6e73402 First go at moving the plugin classes into their own namespace List of files: /dokuwiki/inc/Extension/SyntaxPlugin.php Fri, 15 Jun 2018 15:05:16 +0000 Andreas Gohr <andi@splitbrain.org>