en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#01e8d739c8b53aeb1d0a653331d65eb1f8394002 refactor(changelog): persist external-edit detection on first readThis addresses the flaky test that makes tests randomly fail (mostly onwindows runners).The flake in common_saveWikiText_test::test_savesequence5 came fromthis line in ChangeLog::getCurrentRevisionInfo(): 'date' => max($lastRev + 1, time() - 1)The synthesized "external delete" entry was kept in memory only andonly persisted later, when saveWikiText next called detectExternalEdit.That meant the formula was evaluated twice on different ChangeLoginstances — once during the test's inspection, and again during thefollowing saveWikiText — and the two evaluations could pick differentseconds depending on how long the surrounding I/O took. The testcached the first result in $expectExternal and asserted it against theon-disk entry written during the second call. On the slower Windowsrunner the second call sometimes crossed a second boundary, producingthe off-by-one date mismatch.The questions I had was, why are we persisting external file deletions(or edits) only when a page is saved when we are obviously alreadydetecting it earlier during the changelog read already?Instead of recording the external delete at the time a new page iswritten, it makes sense to record it as soon as we detect it (when thechangelog is requested by a user or a bot). This will make the recodedtimestamp closer to the actual deletion.This patch refactors the changelog accordingly, but still tries to beminimal invasive (I think the changelog handling would need much morerefactoring, but that's beyond the scope of this change).To enable proper locking (when logging an external edit and copyingthe attic file), locking had to be moved to the Changelog class,duplicating some code of io_saveFile.PageFile::detectExternalEdit() and the deprecated procedural wrapperdetectExternalEdit() in inc/common.php are removed. A codesearch.dokuwiki.orgcheck confirmed no plugin calls the method directly; the only externalcaller of the procedural function is the farmsync plugin, which needsa parallel update. List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Sat, 25 Apr 2026 15:30:23 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#a835c93a8c9175f580c05a0aeb56b7664f5e8435 Let ChangeLog set the mode(media/page) for a revision log entry List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Sun, 24 Sep 2023 22:07:03 +0000 Gerrit Uitslag <klapinklapin@gmail.com> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#d4f83172d9533c4d84f450fe22ef630816b21d75 code style: line breaks List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Thu, 31 Aug 2023 20:44:40 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#8c7c53b0321a3cd3116b8d3b2ad27863a38dece7 codestyle adjustments: class declaration braces List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Wed, 30 Aug 2023 15:05:28 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#c1482d1c08360e6401534a1391da2b650c37d34d codestyle adjustments: function argument spacing List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Wed, 30 Aug 2023 15:03:06 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#0603e565f99519c35708bab370f1c5f3271c1365 Apply rector fixes to inc/ChangeLog List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Tue, 29 Aug 2023 12:26:54 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#eeda7ada8c965be1a48afa72ccc473ba9e1db91b some spelling List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Sun, 23 Jan 2022 20:46:39 +0000 Gerrit Uitslag <klapinklapin@gmail.com> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#79a2d7845d5e5e48fe3be8f192717de9294aaba5 import classes, replace dbglog, simplify, remove unused statements, and other warnings from IntelliJupdate phpdocs,rename dokuwiki/Ui/Draft to PageDraft List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Wed, 05 Jan 2022 23:59:00 +0000 Gerrit Uitslag <klapinklapin@gmail.com> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#1d11f1d3396b6d0e55489e568b4bb7028ff9f172 ChangeLogTrait- move ChangeLog low level methods into trait- static ChangeLog::parseLogLine() replaces parseChangeLogLine()- new ChangeLog::buildLogLine() List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Sat, 06 Nov 2021 02:56:15 +0000 Satoshi Sahara <sahara.satoshi@gmail.com> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#c71927663aade6cf69a15ca99cabe28d9a6db62f new method ChangeLog::addLogEntry()rewrite `detectExternalEdit()` in inc/common.php List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Thu, 04 Nov 2021 03:02:55 +0000 Satoshi Sahara <sahara.satoshi@gmail.com> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#e49fa56bf2db001a4fefcb366d1e886f4cfe66f6 use getFilename() method instead of wikiFN() List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Mon, 20 Sep 2021 07:24:40 +0000 Satoshi Sahara <sahara.satoshi@gmail.com> http://127.0.0.1:8080/history/dokuwiki/inc/ChangeLog/PageChangeLog.php#0c3a5702735953748f68955d51bb478538fb6eda split changelog classes into their own namespaceThe remaining functions in inc/changelog.php should be moved into autility class. List of files: /dokuwiki/inc/ChangeLog/PageChangeLog.php Fri, 15 Jun 2018 09:45:58 +0000 Andreas Gohr <andi@splitbrain.org>