4f58273652838cfc963b6bc02439e80fb969c594 - Add tests on sectionID and fixes #3436

Sat, 20 Mar 2021 18:12:19 +0000

Add tests on sectionID and fixes #3436This commit fixes a bug on sectionID which could lead to having duplicated id.Note that this commit changes the API a bit $check used to be a key-value array(with key=the origin id, and value=the number of time this id has been generated)and is now just an array of string. That's because the previous structurecouldn't work.As far as Dokuwiki sources are concerned, this change should have no impact because:- most call to sectionID are done with $check=false (and the behavior in this case isn't changed- only Doku_Renderer->_headerToLink passes an actual array to this method. But this array is initialized empty, it is only filled and read by sectionID itself. (this Doku_Renderer->headers array is protected but the classes which extends it aren't referring this array).It could still break usages of pluging that would call sectionID and rely on theformat of this array. But even if this commits kept $check as an array(for instance setting the values to 1) the semantic wouldn't be the same.To put it in a nutshell:- this change of API has 0 impact on the core of Dokuwiki- there is no evidence that it would impact other code- there doesn't seem to be a clean way to avoid this changeThis commit fixes #3436 List of files: /dokuwiki/_test/tests/inc/pageutils_sectionid.test.php

Changes in pageutils_sectionid.test.php

4f58273652838cfc963b6bc02439e80fb969c594 - Add tests on sectionID and fixes #3436