Changes in GfmLinkTest.php

47a02a102092be9e1e6f1ddaf158bdfffdb13d4f - Parsing: make parse syntax a per-parse value, drop ModeInterface

Thu, 04 Jun 2026 12:27:59 +0000

Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinkTest.php

4f32c45be746b2e49db6bcc6cc733a89bbd14d81 - GfmLink: allow soft line break inside link text

Tue, 26 May 2026 20:05:54 +0000

GfmLink: allow soft line break inside link textThe label character class explicitly forbade `\n`, so a CommonMarksoft line break inside link text (e.g. `[link withmore](url)`)fell through to literal text instead of producing a link. Loosen theclass to accept a bare `\n` as long as it is not followed by a blankline — soft breaks are spec-allowed inside link text, blank lines arenot, and refusing them also keeps `\n#`-anchored block modes (header,hr, ...) from being swallowed by a runaway link match.The `\n` survives into the label string and renders as a literal lineending in HTML, which browsers display as a single space. This softbreak behavior has been checked againsthttps://spec.commonmark.org/dingus/Note that this behavior differs from github where the line break isrendered as a hard break
. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinkTest.php

0f694376a45b6a9e3a163cf19dccda0c2dc008f0 - GfmLink: accept escaped brackets inside link labels

Tue, 05 May 2026 20:04:32 +0000

GfmLink: accept escaped brackets inside link labelsThe label slot used `[^\[\]\n]+`, which rejected `\[` / `\]` andleft labels with escaped brackets unmatched. Promote it to`(?:\\.|[^\[\]\n])+` — the same backslash-escape trick the URLslot already uses — so spec example 523 (`[link \[bar](/uri)`)matches and unescapes cleanly. The image-as-label sub-patterngets the same upgrade.handle() needs no change: the new class still rejects bare `]`,so the first literal `](` in the match is still the separator;Escape::unescapeBackslashes() was already collapsing `\[` to `[`before the label reached the link handler.Adds two GfmLinkTest cases for the `\[` / `\]` forms. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinkTest.php

13a62f810fbd091d15ab734b467eaec0a6bf829a - rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'

Mon, 04 May 2026 10:18:11 +0000

rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'Symmetry with the existing 'dw+md' / 'md+dw' setting values. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinkTest.php

74031e463764923581b9204cebc0fc3f34ce881f - add GfmEscape for GFM backslash escapes

Tue, 28 Apr 2026 17:08:30 +0000

add GfmEscape for GFM backslash escapesImplements GFM §6.1 backslash-escape handling. GfmEscape is a sort-5inline mode in CATEGORY_SUBSTITION that claims `\X` for any escapableASCII punctuation char before competing delimiters can match. Theshared character class lives on Helpers\Escape so the lexer patternand the post-hoc unescape stay in lockstep.Whole-span captures (GfmCode info string, GfmLink label/URL) bypassthe lexer; those modes call Escape::unescapeBackslashes() on therelevant slot. GfmLink skips the unescape when the URL classifies asa windowssharelink so the leading \\host survives intact.GfmTable cells get a separate per-cell `\|` to `|` pass in therewriter to honour the tables-extension rule that pipes alwaysunescape, even inside code spans where standard §6.1 escapes don'tfire. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinkTest.php

3440a8c07d59952439e180d2c33a32262fd3a84c - add GfmMedia and extend GfmLink with image-as-label form

Wed, 22 Apr 2026 14:28:30 +0000

add GfmMedia and extend GfmLink with image-as-label form- New GfmMedia parses `![alt](url)` with the full DokuWiki media-parameter vocabulary in the URL slot (?100x200, ?right, ?nolink, ?recache, …). Adds `?left`/`?right`/`?center` align keywords shared with DW `{{…}}` — gives pure-Markdown users a way to align inline images.- GfmLink now also matches `[![alt](img)](target)` — the GFM equivalent of `[[target|{{img}}]]`. Detection is post-entry, mirroring Internallink's `^{{…}}$` check; one mode covers the whole family.- LinkDispatch trait replaced by Helpers::classifyLink and Helpers::parseMediaParameters — two pure static methods, shared by DW and GFM counterparts.- Entry patterns for GfmLink / GfmMedia simplified (permissive URL slot, handle-time parsing), following DW's Internallink style.- GfmSpecTest drives a test-only SpecCompatRenderer that emits bare / instead of DW's wiki-wrapped HTML, recovering 13 spec tests that previously failed/skipped only because of renderer shape. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinkTest.php

e89aeebd5989e476b6a69236d9aabf72a9a01f14 - add GfmLink for GFM inline links `[text](url)`

Wed, 22 Apr 2026 10:30:14 +0000

add GfmLink for GFM inline links `[text](url)`Extracts the URL-classification ladder from Internallink into aLinkDispatch trait so both modes route identically across all sixDokuWiki link flavors (internal, external, interwiki, email,windowsshare, local anchor). GfmLink parses the `[text](url)` formwith optional `"title"` / `'title'` and hands the URL to the trait.The GFM title attribute is discarded — DokuWiki link instructionshave no slot for it. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinkTest.php