Changes in GfmLinebreakTest.php

47a02a102092be9e1e6f1ddaf158bdfffdb13d4f - Parsing: make parse syntax a per-parse value, drop ModeInterface

Thu, 04 Jun 2026 12:27:59 +0000

Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinebreakTest.php

d331a8396503a69ec91cd77124b1b8983c251c54 - GFM modes: follow CATEGORY_SUBSTITION → CATEGORY_SUBSTITUTION rename

Tue, 12 May 2026 14:12:38 +0000

GFM modes: follow CATEGORY_SUBSTITION → CATEGORY_SUBSTITUTION renameConstant was renamed on master (the typo'd 'substition' value is kept,but the constant name spells it correctly). Update GfmTable's use ofthe constant, plus stale docblock/comment references in GfmEscape,GfmHtmlEntity, GfmLinebreak, and GfmLinebreakTest. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinebreakTest.php

13a62f810fbd091d15ab734b467eaec0a6bf829a - rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'

Mon, 04 May 2026 10:18:11 +0000

rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'Symmetry with the existing 'dw+md' / 'md+dw' setting values. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinebreakTest.php

c4bcbc2e0c397783de26c1e3c211d82d1ac21bb4 - add GfmLinebreak for GFM hard line breaks

Mon, 04 May 2026 09:21:04 +0000

add GfmLinebreak for GFM hard line breaksTwo-or-more trailing spaces, or a single backslash, immediately beforea non-final newline render as a `
`. Both delimiter forms share asingle SUBSTITION mode at sort 140, loaded under any MD-active syntax(markdown, dw+md, md+dw); pure dokuwiki is unaffected.Reuses the existing `linebreak` handler call and renderer; no newinstructions or renderer changes. SpecCompatRenderer overrideslinebreak() to emit the spec's `
` shape. Examples 662, 663(line break inside a raw HTML tag) are skipped — raw HTML is notpassed through by default. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmLinebreakTest.php