en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php#4b31eadfd0dd82e519dd953a4cb0ad079114879d fix (parsing): avoid newline loss on GFM section editingThe GFM header parsing returned a byte position pointing at the newlinebefore the actual header resulting in the observed newline eatings asreported in https://github.com/dokuwiki/dokuwiki/pull/4636#issuecomment-4491970909Additionally this fixes an oddity of DW header parsing whichaccidentally allowed text on the line before the opening = chars.Whitespace is still allowed. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php Thu, 04 Jun 2026 14:35:00 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php#47a02a102092be9e1e6f1ddaf158bdfffdb13d4f Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php Thu, 04 Jun 2026 12:27:59 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php#13a62f810fbd091d15ab734b467eaec0a6bf829a rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'Symmetry with the existing 'dw+md' / 'md+dw' setting values. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php Mon, 04 May 2026 10:18:11 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php#8719732d06ab7306149725c7c5ea71deb8ff0382 add GfmHeader for ATX headings (`# text` through `###### text`)Opener must sit at column 0. GFM tolerates 0-3 spaces before the `#`but that collides with DokuWiki's 2-space-indent preformatted block,so the tolerance is dropped rather than plumbed across modes.Widen the XHTML renderer's section-node tracker from 5 slots to 6 soh6 doesn't hit "Undefined array key 5". Extend GfmSpecTest's HTMLnormalizer to strip DokuWiki's section-div wrappers, section-editcomments, and header id/class attributes so heading spec examplescan validate semantic correctness. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmHeaderTest.php Wed, 22 Apr 2026 08:50:19 +0000 Andreas Gohr <gohr@cosmocode.de>