Changes in GfmEmphasisUnderscoreTest.php

47a02a102092be9e1e6f1ddaf158bdfffdb13d4f - Parsing: make parse syntax a per-parse value, drop ModeInterface

Thu, 04 Jun 2026 12:27:59 +0000

Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmEmphasisUnderscoreTest.php

13a62f810fbd091d15ab734b467eaec0a6bf829a - rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'

Mon, 04 May 2026 10:18:11 +0000

rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'Symmetry with the existing 'dw+md' / 'md+dw' setting values. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmEmphasisUnderscoreTest.php

0244be5c08829b6ca187d7158bca94e7c2fd7be3 - add GfmDeleted mode for GFM strikethrough (`text`)

Tue, 21 Apr 2026 13:52:10 +0000

add GfmDeleted mode for GFM strikethrough (`~~text~~`)Shares the deleted_open/deleted_close instructions with DW's mode.Entry/exit anchors `(?

bcefb8ae61f4ff776efdbad9508c8ee8e5c548a6 - add GFM emphasis and underscore-delimited strong modes

Mon, 20 Apr 2026 18:52:28 +0000
add GFM emphasis and underscore-delimited strong modesThree new inline formatting modes for GitHub Flavored Markdown: GfmEmphasis `*text*` → GfmEmphasisUnderscore `_text_` → (MD-preferred only) GfmStrongUnderscore `__text__` → (MD-preferred only)All three emit the same handler instructions as DokuWiki's Emphasis /Strong, so existing renderers need no changes.Design notes:* Lexer mode names use snake_case (gfm_emphasis, gfm_emphasis_underscore, gfm_strong_underscore) to keep PascalCase readable at the class level. The asterisk variant emits `emphasis_open`/`emphasis_close` via the getInstructionName() hook, so DW's Emphasis (`//...//`) and GfmEmphasis (`*...*`) can coexist in mixed modes without a lexer state collision while still producing the same output.* Underscore variants gate on Markdown-preferred syntax (`markdown`, `md+dw`) because `__` otherwise means DW underline. GfmStrongUnderscore sorts at 70 (matching Strong) — below Underline at 90 — so when loaded it wins the lexer race for `__` runs. Underline is already gated out of MD-preferred modes in the previous commit.* Entry patterns enforce the simplified CommonMark flanking rules already shared across DW inline modes (non-whitespace adjacency, no paragraph-boundary crossing) plus the word-boundary check for underscore variants using NO_WORD_BEFORE / NO_WORD_AFTER. The positive non-word-char enumeration makes them multibyte-safe without requiring the `u` flag: `für_etwas` and `пристаням_стремятся_` correctly stay literal.Per-mode unit tests cover basic matching, single-char bodies,leading/trailing-whitespace rejection, empty-delimiter rejection,paragraph-boundary rejection, multibyte intraword protection, andsort values. ModeRegistryTest's gating data provider picks up thethree new rules. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/GfmEmphasisUnderscoreTest.php

Changes in GfmEmphasisUnderscoreTest.php

47a02a102092be9e1e6f1ddaf158bdfffdb13d4f - Parsing: make parse syntax a per-parse value, drop ModeInterface

13a62f810fbd091d15ab734b467eaec0a6bf829a - rename syntax flavors 'dokuwiki' / 'markdown' to 'dw' / 'md'

0244be5c08829b6ca187d7158bca94e7c2fd7be3 - add GfmDeleted mode for GFM strikethrough (`~~text~~`)

bcefb8ae61f4ff776efdbad9508c8ee8e5c548a6 - add GFM emphasis and underscore-delimited strong modes

0244be5c08829b6ca187d7158bca94e7c2fd7be3 - add GfmDeleted mode for GFM strikethrough (`text`)