en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/ParserMode/ExternallinkTest.php#47a02a102092be9e1e6f1ddaf158bdfffdb13d4f Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/_test/tests/Parsing/ParserMode/ExternallinkTest.php Thu, 04 Jun 2026 12:27:59 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/ParserMode/ExternallinkTest.php#465aec673bd9c2018b4df5364f08c816a70f03a7 Parsing tests: split LinksTest into per-ParserMode filesReplaces the monolithic LinksTest with one test class per ParserMode:CamelcaselinkTest, EmaillinkTest, ExternallinkTest, FilelinkTest,InternallinkTest, WindowssharelinkTest. Media-parser dispatch testsmove into the existing MediaTest alongside the audio/video coverage.ExternallinkTest also adds unit coverage for the GFM autolinkextension trim step: balanced parens, trailing entity refs (validnamed, numeric, and unknown round-trip), non-trailing entities stayinginside the URL, and mixed paren/entity peeling. List of files: /dokuwiki/_test/tests/Parsing/ParserMode/ExternallinkTest.php Tue, 12 May 2026 14:04:35 +0000 Andreas Gohr <andi@splitbrain.org>