en Copyright 2025 Java http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/HandlerTest.php#47a02a102092be9e1e6f1ddaf158bdfffdb13d4f Parsing: make parse syntax a per-parse value, drop ModeInterfaceThe active parse's syntax flavour is a per-parse question, not process-global state: within a single request a plugin can render bundledDokuWiki-syntax text inside an otherwise-Markdown page. Yet ModeRegistrywas a singleton that read $conf['syntax'] and the $PARSER_MODES global,and every mode reached it through ModeRegistry::getInstance() — so theflavour lived in shared mutable state that two parses in one requestwould fight over.Make the registry a short-lived value instead:- ModeRegistry is constructed once per parse with an explicit $syntax and injected into Parser, Handler and every mode. getSyntax() / isDwPreferred() / isMdPreferred() consult $this->syntax; the DOKU_UNITTEST-gated mode-list cache hack is gone (each registry is fresh, nothing to invalidate).- p_get_instructions() is now the single place in the pipeline where $conf['syntax'] is read; from there the flavour travels as a parameter. No code under inc/Parsing/ reads $conf['syntax'] directly anymore — the five syntax-reading modes (Preformatted, GfmHr, GfmEscape, Externallink, GfmQuote) route through $this->registry.Keep the two concepts apart, as documented in the ModeRegistry andAbstractMode docblocks: the user's configured *preference* stays in$conf['syntax'] for UI code (toolbar, settings), while the activeparse's syntax is a parameter carried by the registry.$PARSER_MODES is demoted to a deprecated, read-only mirror, publishedduring loadPluginModes() — third-party syntax plugins (columnlist,alphalist2, phpwikify, skipentity) and the bundled info plugin read theglobal directly, often from their constructors, so the taxonomy muststay visible there. No core code reads the mirror.Fold ModeInterface into AbstractMode while here: getSort()/handle() areabstract, the connect callbacks carry defaults, and the public $Lexer"FIXME should be done by setter" becomes setLexer()/getLexer() injectedby Parser::addMode() alongside the registry. Nested-content resolutionmoves to the allowedCategories()/filterAllowedModes() hooks, resolvedonce when the registry is attached.Tests build their own parser/registry through ParserTestBase::setSyntax()instead of mutating $conf and calling the removed ModeRegistry::reset(). List of files: /dokuwiki/_test/tests/Parsing/HandlerTest.php Thu, 04 Jun 2026 12:27:59 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/HandlerTest.php#f96e4aa0754e3a6b5b15635c0bd792764613f201 Merge branch 'master' into gfm* master: test: add tests to catch #4637 List of files: /dokuwiki/_test/tests/Parsing/HandlerTest.php Wed, 13 May 2026 09:26:15 +0000 Andreas Gohr <gohr@cosmocode.de> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/HandlerTest.php#36ba8eadc205a4e1af5099c74b747e2256faadd4 test: add tests to catch #4637Issue #4637 was fixed in 7686f2030b19f948d2e50df1613ef6592fa44b46 but Ididn't like that no test had caught the issue.This adds a specific test for the issue as a HandlerTest. Additionally asimple smoke test is added that renders the wiki:syntax page andinspects the created DOM. It's not comprehensive but might help flaggingsimilar issue in the future. List of files: /dokuwiki/_test/tests/Parsing/HandlerTest.php Tue, 12 May 2026 18:54:39 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/HandlerTest.php#9172eccff11a70df61d7aad697f84bbd815147ce add sub-parser support to Handler / Parser / ModeRegistryA block mode that wants to parse the body of one of its capturedmatches needs a second Parser instance configured with the activemodes minus whatever would re-enter the outer mode. Doing this byhand is verbose and easy to get wrong — modes hold a $Lexer slotthat addMode() overwrites, so the same mode object can't be sharedbetween the main parser and a sub-parser.Three small additions: Handler::reset() — clears calls, status, currentModeName, and installs a fresh CallWriter. Lets one Handler instance be parsed against repeatedly without state bleed. Parser::getHandler() — accessor; sub-parser callers need it to reach the handler for reset() and for harvesting the produced call list. ModeRegistry::getSubParser($excludeCategories, $excludeModes) — returns a cached Parser preconfigured with every active mode except those excluded. Mode objects are cloned before being attached so connectTo()'s assignment to $Lexer does not clobber the main parser's references. Cache key is the exclusion-set; default exclusion is CATEGORY_BASEONLY (no Header inside the sub-parsed content).Tests cover Handler::reset's full clear, sub-parser caching,default and custom exclusions, registry-reset propagation, andthe clone-not-share invariant for $Lexer. List of files: /dokuwiki/_test/tests/Parsing/HandlerTest.php Tue, 28 Apr 2026 06:22:27 +0000 Andreas Gohr <andi@splitbrain.org> http://127.0.0.1:8080/history/dokuwiki/_test/tests/Parsing/HandlerTest.php#71096e46fcbfaeaa808667aba794e77fe2780169 move handler methods into ParserMode classes and rename HandlerEach ParserMode class now implements handle() from ModeInterface,containing the token handling logic that previously lived as individualmethods on Doku_Handler.The Handler class (formerly Doku_Handler) is the single dispatch point:Lexer passes tokens to Handler::handleToken() which routes to modeobjects, plugins, or returns false. The Lexer only tokenizes andresolves mapHandler aliases.Key changes:- Add handle() to ModeInterface, implemented by all mode classes- Move Doku_Handler to dokuwiki\Parsing\Handler namespace- File extends Code (shared parsing via $type property)- Quotes uses mapHandler() + Handler::getModeName() for sub-modes- Media::parseMedia() replaces Doku_Handler_Parse_Media()- Code::parseHighlightOptions() replaces parse_highlight_options()- Per-parse state (footnote, doublequote) stays on Handler- Deprecated wrappers kept for base/header/internallink/media- Class alias and rector rules added for backward compatibility List of files: /dokuwiki/_test/tests/Parsing/HandlerTest.php Sat, 18 Apr 2026 15:35:30 +0000 Andreas Gohr <andi@splitbrain.org>