getGoogleQuery: remove legacy code for PHP 5.3

https://bugs.php.net/bug.php?id=49733 while we have 5.6+ minimum

getGoogleQuery: ignore if query includes a full URL

We don't want to split the URL to highlight the "query", especially when q is the URL of the page itself - e.g. Google Form's redirect https://www

getGoogleQuery: ignore if query includes a full URL

We don't want to split the URL to highlight the "query", especially when q is the URL of the page itself - e.g. Google Form's redirect https://www.google.com/url

This will also ignore queries like `syntax site:https://www.dokuwiki.org` but it should be fine. Just don't want to use a full parser here.

This fixes #2848.

show more ...

Include rev_id in new revision link in notification email

Older versions have a "This is an old revision of the document!" message on the top of the page. By including rev_id, user can always see th

Include rev_id in new revision link in notification email

Older versions have a "This is an old revision of the document!" message on the top of the page. By including rev_id, user can always see the version the email is referring to, while knowing if it is the latest version by looking at the wiki page.

A hint about this is also added to email text.

This fixes #2196.

show more ...

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed a problem that Scrutinizer complained about.

show more ...

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime, media and link output in xhtml renderer is adjusted, to show title text instead when src/href is null. In interwiki case, the title will be the "reference" part of the interwiki link.

This makes it possible to also support no URL cases in `interwiki.conf`. Before it will output a URL as `rawurlencode($reference)`, which doesn't make too much sense since it's encoded. However, I am not sure the use case under the current behavior (no URL, but text as `$reference`).

Docs needs to be added to warn renderer plugin developers of this situation.

This fixes #2588.

show more ...

css_compress: quote placeholder to simply quote protection

There are two ways of doing this:

1. "doku" > STR1 > "doku"
2. "doku" > "1" > "doku"

#1 is what I did before. I did replace STRN with a n

css_compress: quote placeholder to simply quote protection

There are two ways of doing this:

1. "doku" > STR1 > "doku"
2. "doku" > "1" > "doku"

#1 is what I did before. I did replace STRN with a new placeholder in the previous implementation so that there is no conflict. However #2 is more elegant, so this commit implements it.

Test is updated to address splitbrain's concern about placeholder string in the original text.

show more ...

css_compress: use placeholder to keep quoted strings, fixes #2517

The idea mainly comes from https://github.com/matthiasmullie/minify/blob/97f118c4c745c7c8e47207f2daf3bab13ca65404/src/Minify.php#L343

add quotes test for #2517

updated inc/auth.php

Updated the auth_pwgen password generator order to letters +
special character + number so that the password will not end with
a comma, full stop or other special character.

Fo

updated inc/auth.php

Updated the auth_pwgen password generator order to letters +
special character + number so that the password will not end with
a comma, full stop or other special character.

For example bacdefgih.15 instead of bacdefgih15.

show more ...

Fix #2883

Add failing unit test for #2883

ACL Plugin: make item formatter public again

The formatter needs to be public to be called from html_buildlist()

Do config backups with .php extension fixes #2446

added group internet to html validity checks

Because we use an online validator

Avoid flaky tests by waiting full seconds

The waitForTick() method tried to be clever and return early if a second
had passed since the last call already. Unfortunatel this did not work
reliably in

Avoid flaky tests by waiting full seconds

The waitForTick() method tried to be clever and return early if a second
had passed since the last call already. Unfortunatel this did not work
reliably in our tests and we often had failures on tests that required
unique revision numbers.

Pull requests for a reliable version welcome. Until the we wait a second
on each call.

show more ...

translation update

translation update

translation update

translation update

Check for null JS object on form field.

translation update

Rename _acl_add to _acl_addOrUpdate

because that's what this method actually does now

Fix #1115

without this patch calling _acl_add may result in a corrupted acl.auth.php file.
This is the case when we're adding a config for a user and a scope with an
existing config.

The fix is jus

Fix #1115

without this patch calling _acl_add may result in a corrupted acl.auth.php file.
This is the case when we're adding a config for a user and a scope with an
existing config.

The fix is just to call the _acl_del method before perming the addition.

Note that this _acl_add method is currently called from two places:
- from admin_plugin_acl.handle() which was explicitely calling _acl_del before
- from remote_plugin_acl.addAcl, which can actually result in a corrupted file

show more ...

translation update

translation update