| 36faf696 | 21-Jan-2020 |
Michael Große <mic.grosse@googlemail.com> |
Split out temporary code style excludes
Splitting them out allows for plugins to use _test/phpcs.xml as the basis for their own linting without having an overly permissive coding standard. Also, thi
Split out temporary code style excludes
Splitting them out allows for plugins to use _test/phpcs.xml as the basis for their own linting without having an overly permissive coding standard. Also, this makes it more obvious and painful that these are just intended as temporary exceptions and should be actually fixed.
The rule `Generic.ControlStructures.InlineControlStructure.NotAllowed` has its comment adjust to make it clear that this is an intended deviation from the PSR-2/PSR-12 coding standard.
The rule `PSR1.Classes.ClassDeclaration.MissingNamespace` has to remain in the DokuWiki coding standard as the plugin base classes can currently not reasonably be in namespaces.
show more ...
|
| a72f333f | 19-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
fix url parameter separator in gui::tabURL() |
| b0b7d196 | 19-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
revert aliasing FormWriter class |
| ad4abe1d | 19-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
lowercase variable name |
| 9fdcc8fc | 18-Feb-2020 |
movatica <c0d3@movatica.com> |
Respect fmode config setting
Fix hardcoded fmode overriding user config, which breaks with nondefault environments. |
| 3aa75874 | 18-Feb-2020 |
movatica <c0d3@movatica.com> |
Fixed inconsistent handling of falsy values on fperm setting
The $conf['fperm'] value was checked in multiple files using different methods. This can cause permission trouble with restricted environ
Fixed inconsistent handling of falsy values on fperm setting
The $conf['fperm'] value was checked in multiple files using different methods. This can cause permission trouble with restricted environments, i.e. when chmod is forbidden and file permissions are non-default. Now, all checks use implicit cast to boolean which leads to consistent behaviour.
Also, a misleading variable was renamed in context to better understand one of the checks.
show more ...
|
| b49dd295 | 18-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
set action attribute for form tags |
| bc580cbb | 18-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
label.block design compatibility
render <br> after <input> tag inside <label class="block"> elements. to be compatible with Doku_Form::form_textfield(), form_filefield() |
| 1d4a5a70 | 16-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
fix bundled extension list |
| cd80a505 | 14-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
bugfix: not work enable/disable plugin buttons |
| 67fb6a5d | 14-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
rewrite code using Form\Form class |
| 86e8f706 | 14-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
coding style |
| cf833595 | 11-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
PSR-12 coding style |
| 7be7cd38 | 11-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
respect conf['target'] for Docs and Bugs links
fix #2912 |
| f531b2b2 | 11-Feb-2020 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
better variable name |
| fc6b11d2 | 26-Jan-2020 |
Michael Große <mic.grosse@googlemail.com> |
Add feature flag for deferred javascript
This adds a feature flag for the jQuery and main-js requests added in #2786 and #2958. This adds only a single feature flag since deferring jQuery without d
Add feature flag for deferred javascript
This adds a feature flag for the jQuery and main-js requests added in #2786 and #2958. This adds only a single feature flag since deferring jQuery without deferring the main javascript request is likely to cause errors and confusion.
The feature flag defaults to "on" as this should be unproblematic except for a few plugins. Also, with this flag being on by default, it should see more usage and is more likely to uncover existing issues.
This feature flag should be removed once this feature is deemed safe.
show more ...
|
| 16ad9412 | 11-Jan-2020 |
Rainbow Spike <Dr-Yukon@users.noreply.github.com> |
CDN antibrake
GooglePage Speed Insights rank up 5-10 points Otherwise, the browser render is waiting for loading and compiling big CDN script libraries |
| cef1629d | 01-Jun-2019 |
Rainbow Spike <Dr-Yukon@users.noreply.github.com> |
Update template.php |
| 9d112640 | 24-Jan-2020 |
PBU <pbu@xs4all.nl> |
translation update |
| e28d66f8 | 23-Jan-2020 |
Жељко Тодоровић <zeljko_todorovic@mail.com> |
translation update |
| 1b008e87 | 14-Jan-2020 |
Michael Große <mic.grosse@googlemail.com> |
Restore some backwards compatibility for injected handlers
Some plugins, for example the move plugin, use their own handler class. We need to give these plugins time to adjust their code.
This shou
Restore some backwards compatibility for injected handlers
Some plugins, for example the move plugin, use their own handler class. We need to give these plugins time to adjust their code.
This should restore the functionality of the move plugin. We still need to extract the handler class itself.
It also adds another debug method for triggering the deprecation event, since none of the two existing methods are suitable here. This dbgCustomDeprecationEvent method should be used sparingly and only where the other two don't work.
Co-authored-by: Phy <git@phy25.com>
show more ...
|
| 0d088939 | 14-Jan-2020 |
Michael Große <mic.grosse@googlemail.com> |
Restore backwards compatibility for Doku_Parser
Apparently, #2358 introduced a breaking change to the constructor and usage of Doku_Parser, which broke some plugins, e.g. the move plugin in michitux
Restore backwards compatibility for Doku_Parser
Apparently, #2358 introduced a breaking change to the constructor and usage of Doku_Parser, which broke some plugins, e.g. the move plugin in michitux/dokuwiki-plugin-move#176
This patch should restore the legacy behavior of this deprecated class.
show more ...
|
| 246d3337 | 29-Jun-2018 |
Michael Große <grosse@cosmocode.de> |
♻️ Rename flag to better show actual effect
This flag only causes parameters with empty strings to be skipped, not all empty() values. |
| 4352f974 | 22-Jan-2020 |
Andreas Gohr <gohr@cosmocode.de> |
Better callable support in Event default actions
Instead of parsing the passed callback ourselves, this patch relies on call_user_func_array() instead to call an Event's default action. This ensures
Better callable support in Event default actions
Instead of parsing the passed callback ourselves, this patch relies on call_user_func_array() instead to call an Event's default action. This ensures all possible ways to define a callback (including static methods) can be used.
This should fix a problem mentioned in #2943
show more ...
|
| b5f2c105 | 21-Jan-2020 |
Michael Große <mic.grosse@googlemail.com> |
Run code style checks on pull requests, too
This should make the code style checks also run on pull requests the come from forks. Maybe also on old pull requests? |