simplify media manager panel height

The height of the panel was calculated in JavaScript, trying to use the
remaining space. With larger headers that lead to a relatively small
area. In addition the

simplify media manager panel height

The height of the panel was calculated in JavaScript, trying to use the
remaining space. With larger headers that lead to a relatively small
area. In addition the height calculation behaved weirdly on certain
resolutions (in some templates) resulting in a decreasing height on each
image interaction.

This patch simply sets the panel height 60% of the browser window using
the vh unit (which was not available when the media manager was
written).

To keep backward compatibility and not accidentally break a bunch of
templates, the height is still set from JavaScript but only once instead
of updating it on every resize operation.

A proper refactoring of the whole media manager code is still something
we need to tackle in the future, but this change should make it slightly
better.

show more ...

translation update

Do not reminify minified plugin scripts

Adresses point 5) of #3645

extracted JS compressor into its own library

This moves our JavaScript compressor into its own composer dependency.

translation update

Correction to fix of corner case

Fixes https://github.com/dokuwiki/dokuwiki/pull/3928/commits/e7794be61135b07c6227c367ebf735ba94a2b200

IMHO paying the test on the same variable (`$size`) as in th

Correction to fix of corner case

Fixes https://github.com/dokuwiki/dokuwiki/pull/3928/commits/e7794be61135b07c6227c367ebf735ba94a2b200

IMHO paying the test on the same variable (`$size`) as in the original test in https://github.com/dokuwiki/dokuwiki/blob/775003a7dfc8824e655f040724abfb8255c6da03/lib/plugins/logviewer/admin.php#L143 is better/more clear than basing it on something caused as a result of that test, i.e. `$toread` having a specific value.

show more ...

Always close log file

Close the log file even when exceptions are thrown when trying to read from it.

Fix a corner case

When the log file is exactly 1 MB (MAX_READ_SIZE) In size, the first line(s) would not be shown.

Avoid out-of-memory problems in log viewer

fixes #3919

Squashed commit of the following:

commit 322d0846f39b0641ab7af69e24d1bd70a95b58b5
Author: Andreas Gohr <andi@splitbrain.org>
Date: Mon Mar

Avoid out-of-memory problems in log viewer

fixes #3919

Squashed commit of the following:

commit 322d0846f39b0641ab7af69e24d1bd70a95b58b5
Author: Andreas Gohr <andi@splitbrain.org>
Date: Mon Mar 20 18:45:30 2023 +0100

some more simplifications for the log viewer

* use exceptions to abort on read errors
* use the same fread call regardless of log size

commit b8a3dfbd90a77811db380510cc279f973c92bd01
Author: Hamid <hamid0x4c@gmail.com>
Date: Mon Mar 20 17:49:41 2023 +0330

Fix code style

commit aa0e5b6692f9c26a9c22875111760803e280c9ac
Merge: 23b372c94 ac1d8211a
Author: Hamid <hamid0x4c@gmail.com>
Date: Mon Mar 20 17:39:05 2023 +0330

Merge branch 'dokuwiki:master' into fix-display-large-log

commit 23b372c94d466ff3436177bf8386c879b78c5777
Merge: d82b8818c e410a7b8f
Author: Hamid Adibzadeh <hamid0x4c@gmail.com>
Date: Mon Mar 20 17:35:07 2023 +0330

Merge branch 'fix-display-large-log' of github.com:Adibzadeh/dokuwiki into fix-display-large-log

commit d82b8818c86f614f7d504cf19ad6d0492bb6d92f
Author: Hamid Adibzadeh <hamid0x4c@gmail.com>
Date: Mon Mar 20 17:29:43 2023 +0330

Use only fopen to read logfile

commit e410a7b8fa7663039bbdcfd6a90aed89877bb744
Author: Hamid <hamid0x4c@gmail.com>
Date: Sat Mar 18 10:30:19 2023 +0330

White-space removed

commit 8f1ad23f785b1cccb790b39371b8989514777a38
Author: Hamid Adibzadeh <hamid0x4c@gmail.com>
Date: Sat Mar 18 10:12:16 2023 +0330

Refactoring getLogLines and code improvements

commit 37a0e60c920343ff45ed12ede2cf96c2251108a3
Author: Hamid Adibzadeh <hamid0x4c@gmail.com>
Date: Sat Mar 18 00:27:27 2023 +0330

Refactoring and improve error handling

commit 25d3465289053130546c9066c82b0b620f596c33
Author: Hamid Adibzadeh <hamid0x4c@gmail.com>
Date: Sat Mar 18 00:00:59 2023 +0330

Translation for log errors in Fa and En

commit cc96b9babee12e4f4678380208685b3497a29b70
Author: Hamid Adibzadeh <hamid0x4c@gmail.com>
Date: Fri Mar 17 00:34:06 2023 +0330

code improve

commit 9c0e42285fc8d553e26c030d407d46f69f8c3d91
Author: Hamid <hamid0x4c@gmail.com>
Date: Tue Mar 14 18:16:23 2023 +0330

variable name fixed

commit 89124317ba2cccc12cb506f4d641a9e6288969e1
Author: Hamid <hamid0x4c@gmail.com>
Date: Tue Mar 14 18:13:30 2023 +0330

tab indent fix

commit b154bfde3ecd2039c16b8f8002ada291301e19b2
Author: Hamid Adibzadeh <hamid0x4c@gmail.com>
Date: Tue Mar 14 17:21:09 2023 +0330

fix #3919 log viewer runs into OOM

show more ...

translation update

Fix: Do not garbage collect the JpegMeta object after reading a tag

jQuery and jQuery UI updates

MediaManager: remove check for removed option

The refshow option has been removed in
3e7e02779454686e1c639eb366a195bd1ab50458 and should not have been
checked anymore. This fixes a warning on PHP8 w

MediaManager: remove check for removed option

The refshow option has been removed in
3e7e02779454686e1c639eb366a195bd1ab50458 and should not have been
checked anymore. This fixes a warning on PHP8 when deleting a media
file.

Replaces #3912

show more ...

translation update

translation update

translation update

translation update

AuthPlain user parsing fix. #3833

This removes workarounds we had for old PCRE versions. All modern PHP
releases should be workable with the Regex we have.

If splitting the user line results in les

AuthPlain user parsing fix. #3833

This removes workarounds we had for old PCRE versions. All modern PHP
releases should be workable with the Regex we have.

If splitting the user line results in less than 5 results, we log an
error and pad the result for further use.

show more ...

translation update

translation update

Avoid indexing into log line

Should fix #3868

A log file should be treated as untrusted input. Thus we can make no assumptions about its content. Assuming a line has at least 2 characters length

Avoid indexing into log line

Should fix #3868

A log file should be treated as untrusted input. Thus we can make no assumptions about its content. Assuming a line has at least 2 characters length is an assumption we can avoid by using `substr($line, 0, 2) === ' '` instead of `$line[0] === ' ' && $line[1] === ' '`. No need to separately check for empty or `null` either.

show more ...

use POSIX standard 'dot' built-in rather than 'source'

translation update

translation update

Update lib/plugins/authldap/auth.php

I'm fine with that. Other functions returned an empty array() in an error state so I assumed that's what the parent function wanted.

Co-authored-by: Dominik E

Update lib/plugins/authldap/auth.php

I'm fine with that. Other functions returned an empty array() in an error state so I assumed that's what the parent function wanted.

Co-authored-by: Dominik Eckelmann <deckelmann@gmail.com>

show more ...