PHP8 fix part 1: Trying to access array offset on value of type bool/null

translation update

translation update

translation update

translation update

translation update

translation update

make addPluginCall accessible again

Some plugins are using this method.

make addCall accessible again. fixes #2887

It also reintroduces _addCall() as a deprecated alias.

Fix curly brace syntax. PHP 7.3 deprecations in inc/ directory.

translation update

translation update

fix php errors

remove unnecessary "public"

sort plugins in plugin_list()

translation update

Update template.php

Kind of applied given suggestion but switched $fallback to boolean to reduce possible values.

Added "Date of New Revision" text in notification email

reduce noises in email and provide stronger indication of time dependent version. Thanks @Klap-in!

Update template.php

Here is a solution attempt, sorry for the long delay.
According to my tests, absolute path isn't required

Improve tpl_getMediaFile()

Previously, if no candidate is found, the result would still always be last candidate url even if it doesn't exist (and function would trigger a Warning for trying to geti

Improve tpl_getMediaFile()

Previously, if no candidate is found, the result would still always be last candidate url even if it doesn't exist (and function would trigger a Warning for trying to getimagesize() on a file that doesn't exist)

show more ...

clientIP: add trustedproxy, return first untrusted IP instead of the last one

This fixes #2828, where malicious clients passed in customized HTTP header to keep its IP address off records.

This is

clientIP: add trustedproxy, return first untrusted IP instead of the last one

This fixes #2828, where malicious clients passed in customized HTTP header to keep its IP address off records.

This is inspired by Sympony's Request::setTrustedProxies, but I don't want to implement everything including IP CIDR matching (IPv4 + IPv6), so I decided to reuse the local IP checker in place powered by regexp. Now admins can customize this "local" (trusted) proxy list using $conf['trustedproxy'], and by default it will allow any local IPs.

If in the future there is a need to implement array-based CIDR matching, $conf['trustedproxies'] can be used for the new config name.

show more ...

getGoogleQuery: remove legacy code for PHP 5.3

https://bugs.php.net/bug.php?id=49733 while we have 5.6+ minimum

getGoogleQuery: ignore if query includes a full URL

We don't want to split the URL to highlight the "query", especially when q is the URL of the page itself - e.g. Google Form's redirect https://www

getGoogleQuery: ignore if query includes a full URL

We don't want to split the URL to highlight the "query", especially when q is the URL of the page itself - e.g. Google Form's redirect https://www.google.com/url

This will also ignore queries like `syntax site:https://www.dokuwiki.org` but it should be fine. Just don't want to use a full parser here.

This fixes #2848.

show more ...

Include rev_id in new revision link in notification email

Older versions have a "This is an old revision of the document!" message on the top of the page. By including rev_id, user can always see th

Include rev_id in new revision link in notification email

Older versions have a "This is an old revision of the document!" message on the top of the page. By including rev_id, user can always see the version the email is referring to, while knowing if it is the latest version by looking at the wiki page.

A hint about this is also added to email text.

This fixes #2196.

show more ...

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed a problem that Scrutinizer complained about.

show more ...

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime, media and link output in xhtml renderer is adjusted, to show title text instead when src/href is null. In interwiki case, the title will be the "reference" part of the interwiki link.

This makes it possible to also support no URL cases in `interwiki.conf`. Before it will output a URL as `rawurlencode($reference)`, which doesn't make too much sense since it's encoded. However, I am not sure the use case under the current behavior (no URL, but text as `$reference`).

Docs needs to be added to warn renderer plugin developers of this situation.

This fixes #2588.

show more ...