Imports may not be named like local classes. fixes #4200

For compatibility reasons we let our old `cache` class inherit from
`dokuwiki\Cache\Cache` but `cache` equals `Cache`. At least on some PHP
v

Imports may not be named like local classes. fixes #4200

For compatibility reasons we let our old `cache` class inherit from
`dokuwiki\Cache\Cache` but `cache` equals `Cache`. At least on some PHP
versions? I did not see any problem on my local machine running PHP 8.2
but the problem was visible on a machine running 8.1.27

show more ...

sprintf expects ...args instead of an array. fixes #4193

gracefully handle decryption errors

This should fix #4198

API: legacy compatibility fix

wiki.getAllPages and dokuwiki.getPagelist differed in how the last
modification timestamp was communicated.

This should fix splitbrain/dokuwiki-plugin-sync#70

Reintroduce the FEED_DATA_PROCESS event

As explained here:
https://github.com/dokuwiki/dokuwiki/issues/4191

fix overeager optimization in Table handler. fixes #4186

This reverts an optimization introduced in
bcaec9f47d06126b3e653fea89a86d8b6a6cbef8

The number of elements in $this->tableCalls may change d

fix overeager optimization in Table handler. fixes #4186

This reverts an optimization introduced in
bcaec9f47d06126b3e653fea89a86d8b6a6cbef8

The number of elements in $this->tableCalls may change during the loop,
so they need to be recounted on every step. To protect it from being
"optimized" again, the loop was changed into a while loop.

Ultimately it should be checked if this method could be optimized in
another way.

show more ...

adjust group type hint for User API response

fix User response object in API

�� Rector and PHPCS fixes

Fix false errors when calling getInfo() from some plugins

inc/fulltext Result from splice could be empty

The code for `AND` and `OR` assumes the call to splice will always
return 2 elements, which isn't the case if no terms are found.

Example log messages

inc/fulltext Result from splice could be empty

The code for `AND` and `OR` assumes the call to splice will always
return 2 elements, which isn't the case if no terms are found.

Example log messages:

PHP Warning: Undefined array key 0 in .../dokuwiki/inc/fulltext.php on line 134
PHP Warning: Undefined array key 1 in .../dokuwiki/inc/fulltext.php on line 134
PHP Warning: foreach() argument must be of type array|object, null given in .../dokuwiki/inc/fulltext.php on line 614

Simplified example, via `php -a`:

php > $arr = [];
php > [$a, $b] = array_splice($arr, -2);
PHP Warning: Undefined array key 0 in php shell code on line 1
PHP Warning: Undefined array key 1 in php shell code on line 1

To clear the warning we check if the result is empty and break early,
otherwise we pass the result into `ft_resultCombine` or
`ft_resultUnite`, which both handle the length 1 arrays.

show more ...

translation update

translation update

translation update

io_deleteFromFile: pass a string not null

�� Rector and PHPCS fixes

fix is_ssl() check

There was a global statement missing? This seems to have to been
broken in one of the recent merges.

Tests have been cleaned up but not changes in logic.

�� Rector and PHPCS fixes

feed: use default favicon as very last resort

The dokuwiki logos we deliver in the wiki namespace are preferable.

feed: set item date. fixes #2960

The date was completely missing in the recent refactor. This readds it
and uses a unix timestamp as suggested in #2960

style fixes

feed: set tagline as subtitle. fixes #2239

Feed creation refactoring

This breaks up the humongous functions from feed.php into multiple
classes. To keep compatibility with existing Plugin events, the basic
principle of how the feed is assemb

Feed creation refactoring

This breaks up the humongous functions from feed.php into multiple
classes. To keep compatibility with existing Plugin events, the basic
principle of how the feed is assembled has not been changed:

* depending on the given mode and other options lose arrays of items are
gathered
* these items are then converted (again based on the various options)
into proper FeedItems
* the FeedItems are then added to the Feed

The conversion from loosely typed item data to something more structured
is now done by the FeedItemProcessor classes. Some very basic tests have
been added. It does not cover erverything but covers more than before
(which was nothing).

Manual testing before merging this is highly recommended. I am not
confident that I ported over everything correctly.

No new features have been added, but especially media support could and
should be improved in the future.

show more ...

fall back to empty (root) dir for base dir detection

When a basedir could not be detected, the default previously was '.'
resulting in a valid but weird URL (http://example.com/./doku.php). We
now d

fall back to empty (root) dir for base dir detection

When a basedir could not be detected, the default previously was '.'
resulting in a valid but weird URL (http://example.com/./doku.php). We
now default to an empty dir, resulting in a more sensible URL of
http://example.com/doku.php

This should not matter in real web server setups but will be in effect
while testing.

show more ...

adjust AES encryption to match phpseclib version2

See https://github.com/phpseclib/phpseclib/discussions/1974#discussioncomment-8107663