add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions

add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions if it's about argument
missing.

show more ...

catch ArgumentCountError and return XML error message for remoteAPI, fixes #2545

This is caused by a PHP 7.1 change:
https://www.php.net/manual/en/migration71.incompatible.php
#migration71.incompati

catch ArgumentCountError and return XML error message for remoteAPI, fixes #2545

This is caused by a PHP 7.1 change:
https://www.php.net/manual/en/migration71.incompatible.php
#migration71.incompatible.too-few-arguments-exception

Previously call_user_func_array will make those missing arguments
to NULL without throwing an exception.

show more ...

set default argument value for some of remote methods

most are array params and one int. Note that before if they were not present
from the remote request, a null will be applied to the argument, so

set default argument value for some of remote methods

most are array params and one int. Note that before if they were not present
from the remote request, a null will be applied to the argument, so this is
actually applying the correct data type on the arguments.

show more ...

relax Revert permission to EDIT from manager

Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check.

Than

relax Revert permission to EDIT from manager

Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check.

Thank you @Klap-in for pointing this out.

show more ...

Remove obsolete attributes at <script> tag

Nowadays it is not necessary to specify "type" or "charset" attribute at <script> tag:

1. "type" attribute defaults to "application/javascript", so there

Remove obsolete attributes at <script> tag

Nowadays it is not necessary to specify "type" or "charset" attribute at <script> tag:

1. "type" attribute defaults to "application/javascript", so there is no need to specify that. The recent value "text/javascript" is obsolete in favor of the default "application/javascript", as stated e.g. here: https://www.iana.org/assignments/media-types/media-types.xhtml#text

2. "charset" attribute of the <script> tag defaults to encoding be the same as the encoding of the script element's node document. As DokuWiki's default encoding is "utf-8", there is no need to specify this encoding in external resources. See: https://html.spec.whatwg.org/multipage/scripting.html#the-script-element

Manual merging, closes #2921.

Co-Authored-By: petrkajzar <58340153+petrkajzar@users.noreply.github.com>

show more ...

Prevent double encoding audio/video titles

Use getters instead of deprecated property

Add random_bytes check in installer

Fixes #1892. This will be triggered by:

- PHP 7+: "If an appropriate source of randomness cannot be found, an Exception will be thrown"
- paragonie/random_compat

Add random_bytes check in installer

Fixes #1892. This will be triggered by:

- PHP 7+: "If an appropriate source of randomness cannot be found, an Exception will be thrown"
- paragonie/random_compat: PHP 5.6 support will fail if urandom is not readable

show more ...

Consistent capilization of io_saveFile and psr-2 formatting

Show pencil symbol on preview

translation update

Respect fmode config setting

Fix hardcoded fmode overriding user config, which breaks with nondefault environments.

Fixed inconsistent handling of falsy values on fperm setting

The $conf['fperm'] value was checked in multiple files using different methods.
This can cause permission trouble with restricted environ

Fixed inconsistent handling of falsy values on fperm setting

The $conf['fperm'] value was checked in multiple files using different methods.
This can cause permission trouble with restricted environments, i.e. when chmod is forbidden and file permissions are non-default.
Now, all checks use implicit cast to boolean which leads to consistent behaviour.

Also, a misleading variable was renamed in context to better understand one of the checks.

show more ...

Add feature flag for deferred javascript

This adds a feature flag for the jQuery and main-js requests added in
#2786 and #2958. This adds only a single feature flag since deferring
jQuery without d

Add feature flag for deferred javascript

This adds a feature flag for the jQuery and main-js requests added in
#2786 and #2958. This adds only a single feature flag since deferring
jQuery without deferring the main javascript request is likely to cause
errors and confusion.

The feature flag defaults to "on" as this should be unproblematic except
for a few plugins. Also, with this flag being on by default, it should
see more usage and is more likely to uncover existing issues.

This feature flag should be removed once this feature is deemed safe.

show more ...

CDN antibrake

GooglePage Speed Insights rank up 5-10 points
Otherwise, the browser render is waiting for loading and compiling big CDN script libraries

Update template.php

translation update

translation update

Restore some backwards compatibility for injected handlers

Some plugins, for example the move plugin, use their own handler class.
We need to give these plugins time to adjust their code.

This shou

Restore some backwards compatibility for injected handlers

Some plugins, for example the move plugin, use their own handler class.
We need to give these plugins time to adjust their code.

This should restore the functionality of the move plugin. We still need
to extract the handler class itself.

It also adds another debug method for triggering the deprecation event,
since none of the two existing methods are suitable here. This
dbgCustomDeprecationEvent method should be used sparingly and only where
the other two don't work.

Co-authored-by: Phy <git@phy25.com>

show more ...

Restore backwards compatibility for Doku_Parser

Apparently, #2358 introduced a breaking change to the constructor and
usage of Doku_Parser, which broke some plugins, e.g. the move plugin in
michitux

Restore backwards compatibility for Doku_Parser

Apparently, #2358 introduced a breaking change to the constructor and
usage of Doku_Parser, which broke some plugins, e.g. the move plugin in
michitux/dokuwiki-plugin-move#176

This patch should restore the legacy behavior of this deprecated class.

show more ...

♻️ Rename flag to better show actual effect

This flag only causes parameters with empty strings to be skipped,
not all empty() values.

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures all possible ways to define a callback (including static
methods) can be used.

This should fix a problem mentioned in #2943

show more ...

translation update

removed unused 'salt' parameter from function definition...

Added password change support for argon2i/argon2id, added matching config options and hash_X functions